Solved Need help with wand script

[sharpy]

I am trying to make a new wand script using this code:

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SMALLHOLY)

function onGetFormulaValues(cid, level, maglevel)
min = -(level * 1 + maglevel * 1) * 1
max = -(level * 2 + maglevel * 2) * 2
	return min, max
end
 
setCombatCallback(combat, CALLBACK_PARAM_LEVELMAGICVALUE, "onGetFormulaValues")
function onUseWeapon(cid, var)
return doCombat(cid, combat, var)
end

what I need to know is, if there is a way to set a maximum amount that min and max could be?

I tried making the script like this:

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SMALLHOLY)

function onGetFormulaValues(cid, level, maglevel)
low = -(level * 1 + maglevel * 1) * 1
high = -(level * 2 + maglevel * 2) * 2
	if low > -100 then
		min = -100
	elseif low <= -100 then
		min = low
	end
	if high > -300 then
		max = -300
	elseif high <= -300 then
		max = high
	end
	return min, max
end
 
setCombatCallback(combat, CALLBACK_PARAM_LEVELMAGICVALUE, "onGetFormulaValues")
function onUseWeapon(cid, var)
return doCombat(cid, combat, var)
end

it doesn't return any errors however it only returns low and high for min and max and ignores the max limits I set..

does anyone know if this is possible or what i am doing wrong?

 

[Evan]

Let me know if this works, I have not tested and I can't guarantee it will work, but it is my morning guess.
This is also assuming that you want the max to be 300 and min to be 100.

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SMALLHOLY)
 
function onGetFormulaValues(cid, level, maglevel)
min = -(level * 1 + maglevel * 1) * 1
max = -(level * 2 + maglevel * 2) * 2
	return (min < 100 ? 100 : min), (max > 300 ? 300 : max)
end
 
setCombatCallback(combat, CALLBACK_PARAM_LEVELMAGICVALUE, "onGetFormulaValues")
function onUseWeapon(cid, var)
return doCombat(cid, combat, var)
end

EDIT: No, that won't work, give me a few minutes.

 

[Amino12]

Let me know if this works, I have not tested and I can't guarantee it will work, but it is my morning guess.
This is also assuming that you want the max to be 300 and min to be 100.

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SMALLHOLY)
 
function onGetFormulaValues(cid, level, maglevel)
min = -(level * 1 + maglevel * 1) * 1
max = -(level * 2 + maglevel * 2) * 2
	return (min < 100 ? 100 : min), (max > 300 ? 300 : max)
end
 
setCombatCallback(combat, CALLBACK_PARAM_LEVELMAGICVALUE, "onGetFormulaValues")
function onUseWeapon(cid, var)
return doCombat(cid, combat, var)
end

EDIT: No, that won't work, give me a few minutes.

Your code is good, just your values must be negative.

return (min < -100 ? -100 : min), (max < -300 ? -300 : max)

 

[sharpy]

I figured it out

here is what the new script looks like:

local combat = createCombatObject()
setCombatParam(combat, COMBAT_PARAM_TYPE, COMBAT_HOLYDAMAGE)
setCombatParam(combat, COMBAT_PARAM_DISTANCEEFFECT, CONST_ANI_SMALLHOLY)

function onGetFormulaValues(cid, level, maglevel)
local config = {
	minimum = -(level * 1 + maglevel * 1) * 1,
	maximum = -(level * 2 + maglevel * 2) * 2
}
	if config.minimum < -100 or config.maximum < -300 then
		return -100, -300
	elseif config.minimum >= -100 and config.maximum >= -300 then
		return config.minimum, config.maximum
	end
end
 
setCombatCallback(combat, CALLBACK_PARAM_LEVELMAGICVALUE, "onGetFormulaValues")
function onUseWeapon(cid, var)
return doCombat(cid, combat, var)
end

it could be fixed better I am sure but I'm still learning Lua

 

[Powtreeman]

i tried doing this on one of my weapons but it wouldnt work. probably messed it up by trying to turn a club into a wand

 

[sharpy]

Lol, you might be able to do that if you change the item attributes in items.xml from <attribute key="weaponType" value="club"/> to <attribute key="weaponType" value="wand"/>