C++ Nostalrius 7.7 based on tfs 1.2 container bug

[Manigold]

This bug only happens with normal characters ,gamemasters works fine .The bug happens when you have a container full of items, and inside this container a slot with some stackable item, for example a meat ,if i try to move a meat from the ground to the slot with the meat in my backpack i receive "you cannot put more objects in this container" even if i have capacity, and the slot is not full.
I'm using the files without any modificatiosn from here TwistedScorpio/Nostalrius (https://github.com/TwistedScorpio/Nostalrius)

 

[Manigold]

This bug seem to be related to this Container::queryMaxCount() failing in special cases. · Issue #1561 · otland/forgottenserver (https://github.com/otland/forgottenserver/issues/1561)
If the player has a large capacity left he can get the item, but if the capacity is low, even having enough to get the item he cannot .

EDIT:
I took a look at many servers based on tfs 1.3 and this bug is present in all the servers I looked at, could someone confirm if this bug is present in the current tfs 1.3 otland/forgottenserver (https://github.com/otland/forgottenserver) ? (i don't have the current tfs compiled )

 

[Manigold]

Already fixed by Nekiro Fix Container::queryMaxCount() bug by nekiro · Pull Request #2953 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/2953/commits/6760584035408833e14d300580c7340835af0394)

 

[wizinx]

Already fixed by Nekiro Fix Container::queryMaxCount() bug by nekiro · Pull Request #2953 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/2953/commits/6760584035408833e14d300580c7340835af0394)

Thanks, I was looking for this: D.

I have another question, how is it done to modify that the items go to the backpacks that are empty in the main backpack. Because when you have the main backpack with an empty one inside, when you buy for example 21 mana potion the one that is left over falls to the ground.


(I am using Google Translate. )

 

[emil92b]

there is one bug related to that fix:

if you try to take one or more items from a stack that weighs more than you have capacity for, regardless if you have space or capacity for those items that you want to take from that stack, it will return "This object is too heavy".

example: x100 ham on ground (2000 oz), your capacity is 250 cap, you have available container slots, you want to take x3 ham (60 oz) from that x100 stack, wont work.

 

[Nekiro]

there is one bug related to that fix:

if you try to take one or more items from a stack that weighs more than you have capacity for, regardless if you have space or capacity for those items that you want to take from that stack, it will return "This object is too heavy".

example: x100 ham on ground (2000 oz), your capacity is 250 cap, you have available container slots, you want to take x3 ham (60 oz) from that x100 stack, wont work.

I fixed it too later