Not to throw items through the teleporters C++

[alexxxxxxx]

The name already says it all: anyone who throws items into the teleporter of your OTServ, it will be removed, like those trash cans, however, this system is implemented in the source code, excluding .LUA scripts. TFS 0.4


In teleport.cpp, find

void Teleport::__addThing(Creature* actor, int32_t, Thing* thing)
{
    if(!thing || thing->isRemoved())
        return;

    Tile* destTile = g_game.getTile(destination);
    if(!destTile)
        return;

    if(Creature* creature = thing->getCreature())
    {
        g_game.addMagicEffect(creature->getPosition(), MAGIC_EFFECT_TELEPORT, creature->isGhost());
        creature->getTile()->moveCreature(actor, creature, destTile);
        g_game.addMagicEffect(destTile->getPosition(), MAGIC_EFFECT_TELEPORT, creature->isGhost());
    }
    else if(Item* item = thing->getItem())
    {
        g_game.addMagicEffect(item->getPosition(), MAGIC_EFFECT_TELEPORT);
        g_game.internalMoveItem(actor, item->getTile(), destTile, INDEX_WHEREEVER, item, item->getItemCount(), NULL);
        g_game.addMagicEffect(destTile->getPosition(), MAGIC_EFFECT_TELEPORT);
    }
}

Change it all to:

void Teleport::__addThing(Creature* actor, int32_t, Thing* thing)
{
    if (!thing || thing->isRemoved())
        return;

    Tile* destTile = g_game.getTile(destination);
    if (!destTile)
        return;

    if (Creature* creature = thing->getCreature())
    {
        g_game.addMagicEffect(creature->getPosition(), MAGIC_EFFECT_TELEPORT, creature->isGhost());
        creature->getTile()->moveCreature(actor, creature, destTile);
        g_game.addMagicEffect(destTile->getPosition(), MAGIC_EFFECT_TELEPORT, creature->isGhost());
    }
    else
    {
        Player* player = dynamic_cast<Player*>(actor);
        if (player)
        {
            player->sendTextMessage(MSG_STATUS_SMALL, "You cannot teleport items.");
            
            // Remover o item
            Item* item = dynamic_cast<Item*>(thing);
            if (item) {
                g_game.internalRemoveItem(actor, item);
            }
        }
        return;
    }
}

Now just compile in rebuild mode and start the server, credits to me, alexxxxxxx ~ L3K0T, for the changes.

 

[Marko999x]

Does old tfs not have onMoveItem function?

 

[alexxxxxxx]

So, I prefer not to use 'onmove'; I prefer to do it through the source code and avoid many .lua files.

 

[Marko999x]

So, I prefer not to use 'onmove'; I prefer to do it through the source code and avoid many .lua files.

You are prob the only one

 

[alexxxxxxx]

You are prob the only one

 

[Codinablack]

Nah, I would prefer this too, but for the sake of taking everyone's opinion into consideration, we could modify to only apply the new logic if in config.lua its enabled! Boom! Much better than onMove!