• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Lua NPC travel by storage not working

drafenous

drafenous

New Member
Joined
Nov 8, 2017
Messages
7
Reaction score
1
Hello my friends!
I'm making a NPC for travel to Gengia, Pyro and Oken in my server.

But my npc can't travel to destination on say "yes".

Here is my script:

Lua: 
    if (msgcontains(msg, "gengia")) then
        if(vip.hasVip(cid) == true) then
               npcHandler:say("Do you want to sail to Gengia for free?",cid)
            Topic[cid] = 4
        elseif (Topic[cid] == 4) then
        if (msgcontains(msg, 'yes')) then
            doTeleportThing(cid,{x = 31270, y = 31181, z = 6})
            doSendMagicEffect({x = 31270, y = 31181, z = 6},CONST_ME_TELEPORT)
        else
            npcHandler:say("You dont have enough of gold.",cid)
        end
        else
            npcHandler:say("Sorry, only VIP Players can travel there.",cid)
        end
    end

Here is the NPC interaction:
vr6WCOt.png
 
Solution
Xikini
The above code should work correctly, and Mummrik fixed a couple of other errors as well.
(putting the topic check and message check into the same line, removing the gold message (since it will never be reached), and reorganising the script to flow better.)
The only thing I'd change is removing the multiple extra parentheses.

This is why proper indentation is the first thing you should take care to learn.
When you properly indent the provided code, the issue becomes clear quickly.
Your 'yes' & 'topic[cid] == 4' if statements are hidden inside another if statement and due to this, the script never finds it when you reply to the npc.

your script properly tabbed, for demonstration.
Lua: 
if (msgcontains(msg, "gengia")) then...
Sort by date Sort by votes
drafenous said:
Hello my friends!
I'm making a NPC for travel to Gengia, Pyro and Oken in my server.

But my npc can't travel to destination on say "yes".

Here is my script:

Lua: 
    if (msgcontains(msg, "gengia")) then
        if(vip.hasVip(cid) == true) then
               npcHandler:say("Do you want to sail to Gengia for free?",cid)
            Topic[cid] = 4
        elseif (Topic[cid] == 4) then
        if (msgcontains(msg, 'yes')) then
            doTeleportThing(cid,{x = 31270, y = 31181, z = 6})
            doSendMagicEffect({x = 31270, y = 31181, z = 6},CONST_ME_TELEPORT)
        else
            npcHandler:say("You dont have enough of gold.",cid)
        end
        else
            npcHandler:say("Sorry, only VIP Players can travel there.",cid)
        end
    end

Here is the NPC interaction:
vr6WCOt.png
Click to expand...

This should work

Lua: 
    if (msgcontains(msg, "gengia")) then
        if(vip.hasVip(cid) == true) then
            npcHandler:say("Do you want to sail to Gengia for free?",cid)
            Topic[cid] = 4
       else
            npcHandler:say("Sorry, only VIP Players can travel there.",cid)
       end
    elseif (Topic[cid] == 4 and msgcontains(msg, 'yes')) then
       doTeleportThing(cid,{x = 31270, y = 31181, z = 6})
       doSendMagicEffect({x = 31270, y = 31181, z = 6},CONST_ME_TELEPORT)
       Topic[cid] = nil
   end
 
Upvote 0 Downvote
The above code should work correctly, and Mummrik fixed a couple of other errors as well.
(putting the topic check and message check into the same line, removing the gold message (since it will never be reached), and reorganising the script to flow better.)
The only thing I'd change is removing the multiple extra parentheses.

This is why proper indentation is the first thing you should take care to learn.
When you properly indent the provided code, the issue becomes clear quickly.
Your 'yes' & 'topic[cid] == 4' if statements are hidden inside another if statement and due to this, the script never finds it when you reply to the npc.

your script properly tabbed, for demonstration.
Lua: 
if (msgcontains(msg, "gengia")) then
   if(vip.hasVip(cid) == true) then
       npcHandler:say("Do you want to sail to Gengia for free?",cid)
       Topic[cid] = 4
   elseif (Topic[cid] == 4) then
       if (msgcontains(msg, 'yes')) then
           doTeleportThing(cid,{x = 31270, y = 31181, z = 6})
           doSendMagicEffect({x = 31270, y = 31181, z = 6},CONST_ME_TELEPORT)
       else
           npcHandler:say("You dont have enough of gold.",cid)
       end
   else
       npcHandler:say("Sorry, only VIP Players can travel there.",cid)
   end
end

Mummricks code without the extra parentheses.
Lua: 
if msgcontains(msg, "gengia") then
   if vip.hasVip(cid) == true then
       npcHandler:say("Do you want to sail to Gengia for free?", cid)
       Topic[cid] = 4
   else
       npcHandler:say("Sorry, only VIP Players can travel there.", cid)
   end
elseif Topic[cid] == 4 and msgcontains(msg, "yes") then
   doTeleportThing(cid, {x = 31270, y = 31181, z = 6})
   doSendMagicEffect({x = 31270, y = 31181, z = 6}, CONST_ME_TELEPORT)
   Topic[cid] = nil
end

ps: give best answer to above, I'm just trying to help you learn where the error was.
 
Upvote 0 Downvote
Solution
Xikini said:
The above code should work correctly, and Mummrik fixed a couple of other errors as well.
(putting the topic check and message check into the same line, removing the gold message (since it will never be reached), and reorganising the script to flow better.)
The only thing I'd change is removing the multiple extra parentheses.

This is why proper indentation is the first thing you should take care to learn.
When you properly indent the provided code, the issue becomes clear quickly.
Your 'yes' & 'topic[cid] == 4' if statements are hidden inside another if statement and due to this, the script never finds it when you reply to the npc.

your script properly tabbed, for demonstration.
Lua: 
if (msgcontains(msg, "gengia")) then
   if(vip.hasVip(cid) == true) then
       npcHandler:say("Do you want to sail to Gengia for free?",cid)
       Topic[cid] = 4
   elseif (Topic[cid] == 4) then
       if (msgcontains(msg, 'yes')) then
           doTeleportThing(cid,{x = 31270, y = 31181, z = 6})
           doSendMagicEffect({x = 31270, y = 31181, z = 6},CONST_ME_TELEPORT)
       else
           npcHandler:say("You dont have enough of gold.",cid)
       end
   else
       npcHandler:say("Sorry, only VIP Players can travel there.",cid)
   end
end

Mummricks code without the extra parentheses.
Lua: 
if msgcontains(msg, "gengia") then
   if vip.hasVip(cid) == true then
       npcHandler:say("Do you want to sail to Gengia for free?", cid)
       Topic[cid] = 4
   else
       npcHandler:say("Sorry, only VIP Players can travel there.", cid)
   end
elseif Topic[cid] == 4 and msgcontains(msg, "yes") then
   doTeleportThing(cid, {x = 31270, y = 31181, z = 6})
   doSendMagicEffect({x = 31270, y = 31181, z = 6}, CONST_ME_TELEPORT)
   Topic[cid] = nil
end

ps: give best answer to above, I'm just trying to help you learn where the error was.
Click to expand...
I like that you explain what was wrong and hopefully teach people how to code/script :)
Edit:
I should follow your lead :D
 
Upvote 0 Downvote
Xikini said:
The above code should work correctly, and Mummrik fixed a couple of other errors as well.
(putting the topic check and message check into the same line, removing the gold message (since it will never be reached), and reorganising the script to flow better.)
The only thing I'd change is removing the multiple extra parentheses.

This is why proper indentation is the first thing you should take care to learn.
When you properly indent the provided code, the issue becomes clear quickly.
Your 'yes' & 'topic[cid] == 4' if statements are hidden inside another if statement and due to this, the script never finds it when you reply to the npc.

your script properly tabbed, for demonstration.
Lua: 
if (msgcontains(msg, "gengia")) then
   if(vip.hasVip(cid) == true) then
       npcHandler:say("Do you want to sail to Gengia for free?",cid)
       Topic[cid] = 4
   elseif (Topic[cid] == 4) then
       if (msgcontains(msg, 'yes')) then
           doTeleportThing(cid,{x = 31270, y = 31181, z = 6})
           doSendMagicEffect({x = 31270, y = 31181, z = 6},CONST_ME_TELEPORT)
       else
           npcHandler:say("You dont have enough of gold.",cid)
       end
   else
       npcHandler:say("Sorry, only VIP Players can travel there.",cid)
   end
end

Mummricks code without the extra parentheses.
Lua: 
if msgcontains(msg, "gengia") then
   if vip.hasVip(cid) == true then
       npcHandler:say("Do you want to sail to Gengia for free?", cid)
       Topic[cid] = 4
   else
       npcHandler:say("Sorry, only VIP Players can travel there.", cid)
   end
elseif Topic[cid] == 4 and msgcontains(msg, "yes") then
   doTeleportThing(cid, {x = 31270, y = 31181, z = 6})
   doSendMagicEffect({x = 31270, y = 31181, z = 6}, CONST_ME_TELEPORT)
   Topic[cid] = nil
end

ps: give best answer to above, I'm just trying to help you learn where the error was.
Click to expand...


OMG, thanks!
It's work fine alot...
i'm trying to learn LUA Script and this is my frist try for create an NPC with storage check to travel for vip areas.

I also liked that you explained to me how it works, what in the Brazilian forums about Open Tibia the staff does not do very often ... What made me even more grateful!

Thanks alot!
 
Upvote 0 Downvote

Similar threads

V
  • Question
npc travel
Replies
2
Views
295
vitorelias1
V
F
  • Question
script npc modification
Replies
5
Views
345
Mateus Robeerto
Mateus Robeerto
J
  • Question
Npc Problem Help Please
Replies
2
Views
324
Mateus Robeerto
Mateus Robeerto
K
  • Solved
Lua NPC give first weapon for knight (my first script)
Replies
2
Views
277
kibo433
K
H
  • Question
TFS 1.X+ data/npc/lib/npcsystem/modules items[itemid] == nil error
Replies
6
Views
310
Mateus Robeerto
Mateus Robeerto
Lbtg
  • Question
TFS 1.X+ Npc glitches
Replies
5
Views
599
Lbtg
Lbtg
bpm91
  • Solved
Lua npc no answer
Replies
4
Views
213
bpm91
bpm91
SixNine
  • Solved
TFS 1.X+ Trying to add storage and mission to Trader
Replies
7
Views
369
SixNine
SixNine
J
  • Solved
xodet not giving first wand
Replies
15
Views
647
Jeyci
J
A
  • Question
NPC shows items to sell that the player doesn't have in their backpack
Replies
10
Views
734
VitoxMaster
VitoxMaster
Back
Top