• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

RevScripts Protection by % based on a storage value.

nefinoo

nefinoo

Carnage.flv
Joined
Sep 11, 2010
Messages
549
Solutions
1
Reaction score
58
Location
Lo Mochis, Sinaloa
Could you help me with a revscript to protect those who have a 30% "score" lower than other players? I am using storage 757557, for example if the attacking player has a score of 300, and the attacked player has a score less than 200, he does not suffer damage or activate pk on the attacker.
 
Solution
Sarah Wesker
more or less:
data/scripts/script.lua
Lua: 
local storage = 757557
local difference = 30 -- 30%

local ec = EventCallback

function ec.onTargetCombat(creature, target)
    if creature and target and creature:isPlayer() and target:isPlayer() then
        local creatureScore = creature:getStorageValue(storage)
        if math.abs((creatureScore - target:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return RETURNVALUE_NOERROR
end

ec:register(-777)
The players that differ more than defined in the difference = 30% variable cannot attack each other.
Sort by date Sort by votes
more or less:
data/scripts/script.lua
Lua: 
local storage = 757557
local difference = 30 -- 30%

local ec = EventCallback

function ec.onTargetCombat(creature, target)
    if creature and target and creature:isPlayer() and target:isPlayer() then
        local creatureScore = creature:getStorageValue(storage)
        if math.abs((creatureScore - target:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return RETURNVALUE_NOERROR
end

ec:register(-777)
The players that differ more than defined in the difference = 30% variable cannot attack each other.
 
Upvote 0 Downvote
Solution
Sarah Wesker said:
more or less:
data/scripts/script.lua
Lua: 
local storage = 757557
local difference = 30 -- 30%

local ec = EventCallback

function ec.onTargetCombat(creature, target)
    if creature and target and creature:isPlayer() and target:isPlayer() then
        local creatureScore = creature:getStorageValue(storage)
        if math.abs((creatureScore - target:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return RETURNVALUE_NOERROR
end

ec:register(-777)
The players that differ more than defined in the difference = 30% variable cannot attack each other.
Click to expand...
Not working :S
 
Upvote 0 Downvote
And if you try this one?... (this is a modified version of the script that @Sarah Wesker have created), thanks Sarah, also hope this works.

Lua: 
local storage = 757557
local difference = 30 -- 30%

local ec = EventCallback

function ec.onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
    if attacker and creature and attacker:isPlayer() and creature:isPlayer() then
        local creatureScore = attacker:getStorageValue(storage)
        if math.abs((creatureScore - creature:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return primaryDamage, primaryType, -secondaryDamage, secondaryType, origin
end

ec:register(-777)
 
Upvote 0 Downvote
lokolokio said:
And if you try this one?... (this is a modified version of the script that @Sarah Wesker have created), thanks Sarah, also hope this works.

Lua: 
local storage = 757557
local difference = 30 -- 30%

local ec = EventCallback

function ec.onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
    if attacker and creature and attacker:isPlayer() and creature:isPlayer() then
        local creatureScore = attacker:getStorageValue(storage)
        if math.abs((creatureScore - creature:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return primaryDamage, primaryType, -secondaryDamage, secondaryType, origin
end

ec:register(-777)
Click to expand...
Got this:

Lua: 
Lua Script Error: [Scripts Interface]
C:\Users\Nefi\OneDrive\Escritorio\Minecraft files\data\scripts\CUSTOMS\PROTECTION.lua
LuaScriptInterface::luaDebugPrint(). [Warning - EventCallback::onHealthChange] is not a valid callback.
stack traceback:
        ...rio\Minecraft files\data\scripts/lib\event_callbacks.lua:99: in function '__newindex'
        ...orio\Minecraft files\data\scripts\CUSTOMS\PROTECTION.lua:6: in main chunk
        [C]: in function 'reload'
        data/talkactions/scripts/reload.lua:81: in function <data/talkactions/scripts/reload.lua:59>

Lua Script Error: [Scripts Interface]
C:\Users\Nefi\OneDrive\Escritorio\Minecraft files\data\scripts\CUSTOMS\PROTECTION.lua
LuaScriptInterface::luaDebugPrint(). [Warning - EventCallback::register] need to setup a callback before you can register.
stack traceback:
        ...rio\Minecraft files\data\scripts/lib\event_callbacks.lua:67: in function 'register'
        ...orio\Minecraft files\data\scripts\CUSTOMS\PROTECTION.lua:16: in main chunk
        [C]: in function 'reload'
        data/talkactions/scripts/reload.lua:81: in function <data/talkactions/scripts/reload.lua:59>
 
Upvote 0 Downvote
and if try to remove the callback?... just this line... "local ec = EventCallback"

and change this ...
function ec.onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)

for this...

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)

:'(

if not work, you may try this "creatureevent"

Lua: 
local creatureEvent = CreatureEvent("HolyProtection")
function creatureEvent.onPrepareDeath(creature, killer)
    if creature and killer and creature:isPlayer() and killer:isPlayer() then
        local creatureScore = creature:getStorageValue(storage)
        if math.abs((creatureScore - killer:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return RETURNVALUE_NOERROR
end
creatureEvent:register()

local creatureEvent = CreatureEvent("HolyProtectionLogin")
function creatureEvent.onLogin(player)
    player:registerEvent("HolyProtection")
    return true
end
creatureEvent:register()
 
Last edited:
Upvote 0 Downvote
I'm a JavaScript dev but shouldn't it be ec = EventCallback() so you call the constructor and actually instantiate the object before registering the callback? I'd assume without the parens you're just referring to the constructor itself and not your new EventCallback instance

Like this:
Lua: 
local storage = 757557
local difference = 30 -- 30%

local ec = EventCallback()

function ec.onTargetCombat(creature, target)
    if creature and target and creature:isPlayer() and target:isPlayer() then
        local creatureScore = creature:getStorageValue(storage)
        if math.abs((creatureScore - target:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return RETURNVALUE_NOERROR
end

ec:register(-777)
 
Upvote 0 Downvote
Sarah Wesker said:
more or less:
data/scripts/script.lua
Lua: 
local storage = 757557
local difference = 30 -- 30%

local ec = EventCallback

function ec.onTargetCombat(creature, target)
    if creature and target and creature:isPlayer() and target:isPlayer() then
        local creatureScore = creature:getStorageValue(storage)
        if math.abs((creatureScore - target:getStorageValue(storage)) / creatureScore * 100) <= difference then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return RETURNVALUE_NOERROR
end

ec:register(-777)
The players that differ more than defined in the difference = 30% variable cannot attack each other.
Click to expand...
does this onTargetCombat work with area damages, that you can use without a specific target?
lets say you use an ultimate explosion without a target, would the player still be protected?
 
Upvote 0 Downvote
sururuts said:
does this onTargetCombat work with area damages, that you can use without a specific target?
lets say you use an ultimate explosion without a target, would the player still be protected?
Click to expand...
Yes, it will trigger once for each creature that is hit by the AOE.
 
Upvote 0 Downvote
forgee said:
Sarah's script is correct, except on line 9 <= should be >=.
Click to expand...
Its not working for me :/ and dont send any error
Solved, i have onTargetCombat disable on events.xml

Lua: 
local storage = 757557
local difference = 25 -- 30%

local ec = EventCallback

function ec.onTargetCombat(creature, target)
    if creature and target and creature:isPlayer() and target:isPlayer() then
        local creatureScore = creature:getStorageValue(storage)
        local comparation = math.abs(creatureScore * (difference / 100))
        if target:getStorageValue(storage) <= comparation then
            return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER
        end
    end
    return RETURNVALUE_NOERROR
end

ec:register(-777)
This is what i a want, but i cant attack anyone with a high score or low score

instead of returning a value RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER with a msg "You may not attack this player" says "You may not attack this creature"
 
Last edited:
Upvote 0 Downvote

Similar threads

potinho
  • Question
Lua [TFS 0.X] Improve Reward Chest System
Replies
1
Views
224
potinho
potinho
ralke
  • Question
C++ Chance to automatically cast a spell on every base attack based on vocation
Replies
1
Views
406
Dakos
D
M
  • Question
RevScripts Npc Tereban problem
Replies
1
Views
202
Manuel Audaz
M
wearetibia
[CANADA] [Custom / 8.0] WeAreDragons SCATHA | F2P REMOVED BOXES | Reborns | 19 MAY 18:00 CET
Replies
3
Views
1K
Shade ~
Shade ~
erikbs
Weapon auto upgrade
Replies
3
Views
532
Gubailovo
Gubailovo
xixigisi
  • Question
onDroploot and bags question
Replies
3
Views
490
Xikini
Xikini
Klank
Feature TFS[1.4.2] Questlog/Task counter: Storage tracker in description as string
Replies
2
Views
1K
Tenzhiro
Tenzhiro
Back
Top