TFS 1.X+ Random server and client crashes

[OTHst]

Hi,

I get seemingly random server and client crashes. Server crashes might have something to do with monster corpses but I'm not sure.

I'm using latest TFS 1.3 with this datapack: [10.77] - ORTS | Real Map Data Pack for latest TFS (https://otland.net/threads/10-77-orts-real-map-data-pack-for-latest-tfs.274769/)

Client used is 10.98

Edit: now getting crashes without killing monsters so it's not that

 

[OTHst]

nice! it is now, merged some hours ago. hopefully this solves the issues i'm having aswell

oh damn, I misread... that change was 14 hours ago, thought it was an old change... sorry!

 

[Evil Puncker]

oh damn, I misread... that change was 14 hours ago, thought it was an old change... sorry!

what about client crashes?

 

[torresmon]

i've been abusing it and it seems stable so far

 

[Nekiro]

Yeah, it was data race, that's why it crashed. It should be okay now.

 

[OTHst]

Very stable so far... only that one single client crash earlier

 

[torresmon]

Very stable so far... only that one single client crash earlier

yep. take a look at memory usage on linux. mine was about 2.8gb on win x64 now it's using only 305mb-ish
it went down to 170mb and i restarted it to see what happens, using about 2.6gb now

 

[OTHst]

yep. take a look at memory usage on linux. mine was about 2.8gb on win x64 now it's using only 305mb-ish
it went down to 170mb and i restarted it to see what happens, using about 2.6gb now

Memory usage is fine, I increased the virtual servers ram to a lot just to be safe and monitored the ram earlier. Never went over 3gb of usage

Post automatically merged: Feb 17, 2021

Update: Client crashes has been occuring when I've been playing with my friends. Not too bad but still annoying, also experienced the character being logged out and the character list shows up

 

[Evil Puncker]

Memory usage is fine, I increased the virtual servers ram to a lot just to be safe and monitored the ram earlier. Never went over 3gb of usage

Post automatically merged: Feb 17, 2021

Update: Client crashes has been occuring when I've been playing with my friends. Not too bad but still annoying, also experienced the character being logged out and the character list shows up

are they getting client crash as well? are they using official 10.98 client or the one with updated sprites?

 

[OTHst]

are they getting client crash as well? are they using official 10.98 client or the one with updated sprites?

Yes they are getting crashes, we're all using the official 10.98 client.
Edit: I don't know if this is relevant or even useful but it seems like the minimap on the client partially gets reset when the client crashes

 

[torresmon]

need more details about what was happenning at the time of the crash; monsters, npcs, location, tools used, etc. i'd try a fresh installation, database, other client versions and otc client too.
i've been trying to crash it or even get console errors since Fix data race on addEvent with no succes, it's getting harder and harder to break it on my setup. it got kinda laggy during one invasion but that's it. hours hunting, idle, exploring with zero errors

 

[OTHst]

need more details about what was happenning at the time of the crash; monsters, npcs, location, tools used, etc. i'd try a fresh installation, database, other client versions and otc client too.
i've been trying to crash it or even get console errors since Fix data race on addEvent with no succes, it's getting harder and harder to break it on my setup. it got kinda laggy during one invasion but that's it. hours hunting, idle, exploring with zero errors

ORTS datapack, TFS latest items.otb, cipsoft 10.98 client (vanilla).
Three people all getting client crashes.

 

[Simonalina]

here is some more information about client crash!

btw, how do i change ram? i have 64gb but i dont know how much the server goes on? where to change?

 

[SorketROrk]

View attachment 56007
here is some more information about client crash!

btw, how do i change ram? i have 64gb but i dont know how much the server goes on? where to change?

Did you fix this issue? Im having the same problem i think..

 

[Evil Puncker]

Did you fix this issue? Im having the same problem i think..

nope, the client crash is still there ;(

 

[SorketROrk]

nope, the client crash is still there ;(

If the issue is the same ive got, from the thread I recently made with a screenshot attached, I found out that its not causing crash on otclient, how come?

 

[Evil Puncker]

I found out that its not causing crash on otclient, how come?

OTClient was made to not crash but the issue is still somewhere and need to be fixed

 

[forgee]

View attachment 55118

a few errors message from OTC console

I had a look at this crash today. Big thank you for those error messages, they gave me a good idea of where to start. I don't know why it would only affect the ORTS datapack, but I think I have figured out what happens.

How to reliably reproduce the crash/error:
Spawn a monster with a God, walk off-screen, then kill the monster with another character. The key is that you "see" the monster, then walk off-screen before killing it. In this case the God's client will either crash (Cip client) or show the "no thing" error (otclient).

The server sends 'GameServerDeleteOnMap' opcode (108/0x6C) to remove the creature from the map, but the creature doesn't seem to exist on the client (already removed because it's outside view range?). The crash does not happen with items and while backtracing the network message I noticed that ProtocolGame::sendRemoveTileThing checks if the player canSee(pos) while ProtocolGame::sendRemoveTileCreature does not.

I will see if I can reproduce with default TFS datapack and test with a canSee check in sendRemoveTileCreature.