Well two codes do not prove an entire spectrum of optimization to be valid for this game. You even said it yourself:Optimizations have nothing to do with what the game is. Check this analogy:
Doesn't this two codes do the exact same thing? I haven't changed what they are, just how they do it. This is a very simple example but you can extend it to many kinds of optimizations (design, readability, time, memory)Lua:
function Sum100(x) return x + 100 end function Sum100(x) for i = 1, 100 do x = x + 1 end return x end
By optimizating the dialogues like this, you're essentially changing the game as we know it, in one way or another, even if it's just a small change.[...] If I'm already promoted why the npc would ask if I want to get promoted and wait for me to confirm before saying I can't do that? [...]
But sure I do agree with you it probably could be done to optimize the whole shenanigans, but who will do it for free? As I stated earlier, I think you're a bit too overambitious.
We should work with what we have, since it's actually working... If you'd be down to change the world for us, by all means, do so. I just think it's highly unlikely that it will happen.