TFS 1.X+ Reward Chest TFS 1.5

Extrodus · Sep 29, 2022

Hurro; quick question guys!

Would the following system be safe to implement on TFS 1.5 [Downgrade 8.6] with changed container/reward itemID's or would it be safer to update/optimize the system first before adding it? As I see a few suggested edits in the comments.

Reward Chest System:

Reward System [remake of #1628] by cezarguimaraes · Pull Request #1641 · otland/forgottenserver

Remake of #1628 Reasoning After seeing a few reward systems on OTLand try and fail to replicate the original one, I decided to give it a try myself. Some images of the result: How I did it...

github.com

Seems there is also a Loot Issue Patch Here:

Tfs 1.2 Reward Chest

So im using this reward chest https://github.com/otland/forgottenserver/pull/1641 and everything seems to be working fine. It goes to the reward chest, unique drops drop only once (like ferumbrass hat) but I tested the script with 2 players kill ferumbras and it seems that the loot of ferumbras...

otland.net

Extrodus · Sep 30, 2022

Managed to get the system to compile on TFS 1.5; however it seems in monsters.cpp createLoot has been moved to lua; so I am unable to add:

Code:

    if (isRewardBoss) {
        auto timestamp = time(nullptr);
        Item* rewardContainer = Item::CreateItem(ITEM_REWARD_CONTAINER);
        rewardContainer->setIntAttr(ITEM_ATTRIBUTE_DATE, timestamp);    
        corpse->setIntAttr(ITEM_ATTRIBUTE_DATE, timestamp);
        corpse->internalAddThing(rewardContainer);
        corpse->setRewardCorpse();
        corpse->startDecaying();
        return;
    }

Does anyone have ideas how to convert this to LUA?

Sarah Wesker · Sep 30, 2022

data/scripts/eventcallbacks/monster/default_onDropLoot.lua

LUA:

    local mType = self:getType()
    if mType:isRewardBoss() then
        local timestamp = os.time()
        local rewardContainer = Game.createItem(ITEM_REWARD_CONTAINER)
        rewardContainer:setAttribute(ITEM_ATTRIBUTE_DATE, timestamp)
        corpse:setAttribute(ITEM_ATTRIBUTE_DATE, timestamp)
        corpse:addItemEx(rewardContainer)
        corpse:setAttribute(ITEM_ATTRIBUTE_CORPSEOWNER, 0xFFFFFFFF)
        corpse:decay()
        return
    end

Azerty · Oct 13, 2022

Extrodus said:
Hurro; quick question guys!

Would the following system be safe to implement on TFS 1.5 [Downgrade 8.6] with changed container/reward itemID's or would it be safer to update/optimize the system first before adding it? As I see a few suggested edits in the comments.

Reward Chest System:

Reward System [remake of #1628] by cezarguimaraes · Pull Request #1641 · otland/forgottenserver

Remake of #1628 Reasoning After seeing a few reward systems on OTLand try and fail to replicate the original one, I decided to give it a try myself. Some images of the result: How I did it...

github.com

Seems there is also a Loot Issue Patch Here:

Tfs 1.2 Reward Chest

So im using this reward chest https://github.com/otland/forgottenserver/pull/1641 and everything seems to be working fine. It goes to the reward chest, unique drops drop only once (like ferumbrass hat) but I tested the script with 2 players kill ferumbras and it seems that the loot of ferumbras...

otland.net

How did you manage to get this system into TFS 1.5? provide a tutorial?

Extrodus · Oct 13, 2022

Azerty said:
How did you manage to get this system into TFS 1.5? provide a tutorial?

Rebuilt it from scratch.

Azerty · Apr 13, 2023

Extrodus said:
Rebuilt it from scratch.

Can you make your iologindata.cpp available?

Marco Oliveira · Apr 13, 2023

We would all be immensely happy if Sarah would write the reward code again and adapt it for TFS 1.5. After all, she and her codes are beautiful and magnificent. And of course I'm not just trying to please her to get the reward.

Forkz · Feb 24, 2025

Extrodus said:
Rebuilt it from scratch.

Why commit to the rewards system?

Mateus Robeerto · Feb 24, 2025

Forkz said:
Why commit to the rewards system?

This Reward system, which is more updated and improved, I have already added to my TFS 1.4.2 1098, 1.5 8.60 Nekiro, and 1.7 8.60, and it's working fine. You can check it out here and add it to your TFS.

Added Reward Container & Boss System (#14) · Black-Tek/BlackTek-Server@0da6263

-Added Reward Container -Added Unique Loot -Created Boss Type monsters -Boss loot based on participation -Added a Reward Chest, and placed on map -Add configurations in config.lua

github.com

3alola1 · May 8, 2025

Mateus Robeerto said:
This Reward system, which is more updated and improved, I have already added to my TFS 1.4.2 1098, 1.5 8.60 Nekiro, and 1.7 8.60, and it's working fine. You can check it out here and add it to your TFS.

Added Reward Container & Boss System (#14) · Black-Tek/BlackTek-Server@0da6263

-Added Reward Container -Added Unique Loot -Created Boss Type monsters -Boss loot based on participation -Added a Reward Chest, and placed on map -Add configurations in config.lua

github.com

how did you solve the too few arguments in the rewardchest.cpp? using 8.60 tfs 1.5

Post automatically merged: May 8, 2025

Mateus Robeerto · May 8, 2025

3alola1 said:
how did you solve the too few arguments in the rewardchest.cpp? using 8.60 tfs 1.5

The only error was in iologindata.cpp, which wasn’t compatible with your base. But you should look for this line:

LUA:

bool IOLoginData::addRewardItems(uint32_t playerId, const ItemBlockList& itemList, DBInsert& query_insert, PropWriteStream& propWriteStream)

and replace everything with this version here.

C++:

bool IOLoginData::addRewardItems(uint32_t playerId, const ItemBlockList& itemList, DBInsert& query_insert, PropWriteStream& propWriteStream)
{
    using ContainerBlock = std::pair<Container*, int32_t>;
    std::list<ContainerBlock> queue;
    Database& db = Database::getInstance();
    DBResult_ptr result = db.storeQuery(fmt::format("SELECT MAX(pid) as max_pid FROM `player_rewarditems` WHERE `player_id` = {:d}", playerId));
    int32_t runningId = 1;
    int32_t pidCounter = 1;
    if (result) {
        int32_t maxPid = result->getNumber<int32_t>("max_pid");
        if (maxPid > 0) {
            pidCounter = maxPid + 1;
        }
    }
    int32_t parentPid = pidCounter;
    for (const auto& it : itemList) {
        Item* item = it.second;
        propWriteStream.clear();
        item->serializeAttr(propWriteStream);

        size_t streamSize;
        if (!query_insert.addRow(fmt::format("{:d}, {:d}, {:d}, {:d}, {:d}, {:s}",
            playerId, parentPid, runningId, item->getID(), item->getSubType(), db.escapeString(propWriteStream.getStream(streamSize))))) {
            return false;
        }

        if (Container* container = item->getContainer()) {
            queue.emplace_back(container, runningId);
        }
        ++runningId; // Always increment SID upwards
    }
    while (!queue.empty()) {
        const ContainerBlock& cb = queue.front();
        Container* container = cb.first;
        int32_t parentId = cb.second;
        queue.pop_front();
        for (Item* item : container->getItemList()) {
            propWriteStream.clear();
            item->serializeAttr(propWriteStream);

            size_t streamSize;
            if (!query_insert.addRow(fmt::format("{:d}, {:d}, {:d}, {:d}, {:d}, {:s}",
                playerId, parentId, runningId, item->getID(), item->getSubType(), db.escapeString(propWriteStream.getStream(streamSize))))) {
                return false;
            }
            Container* subContainer = item->getContainer();
            if (subContainer) {
                queue.emplace_back(subContainer, runningId);
            }
            ++runningId; // Always increment SID upwards
        }
    }
    return query_insert.execute();
}

Recompile and test — be happy.

3alola1 · May 8, 2025

Mateus Robeerto said:

The only error was in iologindata.cpp, which wasn’t compatible with your base. But you should look for this line:

LUA:

bool IOLoginData::addRewardItems(uint32_t playerId, const ItemBlockList& itemList, DBInsert& query_insert, PropWriteStream& propWriteStream)

and replace everything with this version here.

C++:

bool IOLoginData::addRewardItems(uint32_t playerId, const ItemBlockList& itemList, DBInsert& query_insert, PropWriteStream& propWriteStream)
{
    using ContainerBlock = std::pair<Container*, int32_t>;
    std::list<ContainerBlock> queue;
    Database& db = Database::getInstance();
    DBResult_ptr result = db.storeQuery(fmt::format("SELECT MAX(pid) as max_pid FROM `player_rewarditems` WHERE `player_id` = {:d}", playerId));
    int32_t runningId = 1;
    int32_t pidCounter = 1;
    if (result) {
        int32_t maxPid = result->getNumber<int32_t>("max_pid");
        if (maxPid > 0) {
            pidCounter = maxPid + 1;
        }
    }
    int32_t parentPid = pidCounter;
    for (const auto& it : itemList) {
        Item* item = it.second;
        propWriteStream.clear();
        item->serializeAttr(propWriteStream);

        size_t streamSize;
        if (!query_insert.addRow(fmt::format("{:d}, {:d}, {:d}, {:d}, {:d}, {:s}",
            playerId, parentPid, runningId, item->getID(), item->getSubType(), db.escapeString(propWriteStream.getStream(streamSize))))) {
            return false;
        }

        if (Container* container = item->getContainer()) {
            queue.emplace_back(container, runningId);
        }
        ++runningId; // Always increment SID upwards
    }
    while (!queue.empty()) {
        const ContainerBlock& cb = queue.front();
        Container* container = cb.first;
        int32_t parentId = cb.second;
        queue.pop_front();
        for (Item* item : container->getItemList()) {
            propWriteStream.clear();
            item->serializeAttr(propWriteStream);

            size_t streamSize;
            if (!query_insert.addRow(fmt::format("{:d}, {:d}, {:d}, {:d}, {:d}, {:s}",
                playerId, parentId, runningId, item->getID(), item->getSubType(), db.escapeString(propWriteStream.getStream(streamSize))))) {
                return false;
            }
            Container* subContainer = item->getContainer();
            if (subContainer) {
                queue.emplace_back(subContainer, runningId);
            }
            ++runningId; // Always increment SID upwards
        }
    }
    return query_insert.execute();
}

Recompile and test — be happy.

yeah and what arguments exactly RewardChest::RewardChest(uint16_t type, bool paginated /= true/) : for 8.6 conatiner?

TFS 1.X+ Reward Chest TFS 1.5

Extrodus

|| Blazera.net ||

Reward System [remake of #1628] by cezarguimaraes · Pull Request #1641 · otland/forgottenserver

Tfs 1.2 Reward Chest

Extrodus

|| Blazera.net ||

Sarah Wesker

ƐƖєgαηт Sуηтαx ❤

Azerty

Active Member

Reward System [remake of #1628] by cezarguimaraes · Pull Request #1641 · otland/forgottenserver

Tfs 1.2 Reward Chest

Extrodus

|| Blazera.net ||

Azerty

Active Member

Marco Oliveira

Well-Known Member

Forkz

Intermediate OT User

Mateus Robeerto

Legendary OT User

Added Reward Container & Boss System (#14) · Black-Tek/BlackTek-Server@0da6263

3alola1

I don't have time

Added Reward Container & Boss System (#14) · Black-Tek/BlackTek-Server@0da6263

Mateus Robeerto

Legendary OT User

3alola1

I don't have time

Similar threads