• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

C++ send item to offline player depot

mattch

mattch

New Member
Joined
Jun 15, 2013
Messages
13
Solutions
1
Reaction score
3
Hello.
I'm trying to make a function that send the item to the player depot, even if he are not online.

Thats the function that i created. Its only working if the player is online.
C++: 
int LuaScriptInterface::luaSendPlayerDepotItem(lua_State* L)
{
    //sendPlayerDepotItem(guid, item[, depotId = 0])
    uint32_t guid = getNumber<uint32_t>(L, 1);
    Item* item = getScriptEnv()->getItemByUID(getNumber<uint32_t>(L, 2));
    if (!item) {
        lua_pushnil(L);
        return 1;
    }

    uint32_t depotId = getNumber<uint32_t>(L, 3, 0);
    Player* player = g_game.getPlayerByGUID(guid);
    if (!player) {
        Player tmpPlayer(nullptr);
        if(!IOLoginData::loadPlayerById(&tmpPlayer, guid)) {
            lua_pushnil(L);
            return 1;
        }
        DepotChest* depotChest = (&tmpPlayer)->getDepotChest(depotId, true);
        pushBoolean(L, g_game.internalAddItem(depotChest, item) == RETURNVALUE_NOERROR);
        IOLoginData::savePlayer(&tmpPlayer);
    } else {
        DepotChest* depotChest = player->getDepotChest(depotId, true);
        pushBoolean(L, g_game.internalAddItem(depotChest, item) == RETURNVALUE_NOERROR);
    }

    return 1;
}

I want to know whats wrong and what i have to do to make it work.
 
Solution
mattch
Tested both functions internalMoveItem and internalAddItem, but did not work.

Anyway i just solved my problem doing this:
C++: 
bool IOLoginData::sendPlayerDepotItem(Player* player, uint32_t depotId, Item* sendItem) {
    if (depotId >= 100) {
        return false;
    }

    ItemBlockList itemList;
    PropWriteStream propWriteStream;

    Database* db = Database::getInstance();
    std::ostringstream query;

    query << "DELETE FROM `player_depotitems` WHERE `player_id` = " << player->getGUID();
    db->executeQuery(query.str());

    DBInsert depotQuery("INSERT INTO `player_depotitems` (`player_id`, `pid`, `sid`, `itemtype`, `count`, `attributes`) VALUES ");

    bool added = false;
    for (const auto& it ...
Sort by date Sort by votes
mattch said:
Hello.
I'm trying to make a function that send the item to the player depot, even if he are not online.

Thats the function that i created. Its only working if the player is online.
C++: 
int LuaScriptInterface::luaSendPlayerDepotItem(lua_State* L)
{
    //sendPlayerDepotItem(guid, item[, depotId = 0])
    uint32_t guid = getNumber<uint32_t>(L, 1);
    Item* item = getScriptEnv()->getItemByUID(getNumber<uint32_t>(L, 2));
    if (!item) {
        lua_pushnil(L);
        return 1;
    }

    uint32_t depotId = getNumber<uint32_t>(L, 3, 0);
    Player* player = g_game.getPlayerByGUID(guid);
    if (!player) {
        Player tmpPlayer(nullptr);
        if(!IOLoginData::loadPlayerById(&tmpPlayer, guid)) {
            lua_pushnil(L);
            return 1;
        }
        DepotChest* depotChest = (&tmpPlayer)->getDepotChest(depotId, true);
        pushBoolean(L, g_game.internalAddItem(depotChest, item) == RETURNVALUE_NOERROR);
        IOLoginData::savePlayer(&tmpPlayer);
    } else {
        DepotChest* depotChest = player->getDepotChest(depotId, true);
        pushBoolean(L, g_game.internalAddItem(depotChest, item) == RETURNVALUE_NOERROR);
    }

    return 1;
}

I want to know whats wrong and what i have to do to make it work.
Click to expand...

Hello,

If the player is offline you need to temporary load him from database, add item to depot and save back to database. Look to Mailbox code, it looks similiar with receiving parcels.
 
Upvote 0 Downvote
gunz said:
Hello,

If the player is offline you need to temporary load him from database, add item to depot and save back to database. Look to Mailbox code, it looks similiar with receiving parcels.
Click to expand...

i have tried it, but yet no success
 
Upvote 0 Downvote
This is the mailbox code, just change tmpPlayer.getInbox() to whatever you want.
C++: 
bool Mailbox::sendItem(Item* item) const
{
    std::string receiver;
    if (!getReceiver(item, receiver)) {
        return false;
    }

    /**No need to continue if its still empty**/
    if (receiver.empty()) {
        return false;
    }

    Player* player = g_game.getPlayerByName(receiver);
    if (player) {
        if (g_game.internalMoveItem(item->getParent(), player->getInbox(), INDEX_WHEREEVER,
                                    item, item->getItemCount(), nullptr, FLAG_NOLIMIT) == RET_NOERROR) {
            g_game.transformItem(item, item->getID() + 1);
            player->onReceiveMail();
            return true;
        }
    } else {
        Player tmpPlayer(nullptr);
        if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
            return false;
        }

        if (g_game.internalMoveItem(item->getParent(), tmpPlayer.getInbox(), INDEX_WHEREEVER,
                                    item, item->getItemCount(), nullptr, FLAG_NOLIMIT) == RET_NOERROR) {
            g_game.transformItem(item, item->getID() + 1);
            IOLoginData::savePlayer(&tmpPlayer);
            return true;
        }
    }
    return false;
}
 
Upvote 0 Downvote
Tested both functions internalMoveItem and internalAddItem, but did not work.

Anyway i just solved my problem doing this:
C++: 
bool IOLoginData::sendPlayerDepotItem(Player* player, uint32_t depotId, Item* sendItem) {
    if (depotId >= 100) {
        return false;
    }

    ItemBlockList itemList;
    PropWriteStream propWriteStream;

    Database* db = Database::getInstance();
    std::ostringstream query;

    query << "DELETE FROM `player_depotitems` WHERE `player_id` = " << player->getGUID();
    db->executeQuery(query.str());

    DBInsert depotQuery("INSERT INTO `player_depotitems` (`player_id`, `pid`, `sid`, `itemtype`, `count`, `attributes`) VALUES ");

    bool added = false;
    for (const auto& it : player->depotChests) {
        if (it.first == depotId) {
            itemList.emplace_back(it.first, sendItem);
            added = true;
        }
        DepotChest* depotChest = it.second;
        for (Item* item : depotChest->getItemList()) {
            itemList.emplace_back(it.first, item);
        }
    }

    if (!added) {
        itemList.emplace_back(depotId, sendItem);
    }

    if (!saveItems(player, itemList, depotQuery, propWriteStream)) {
        return false;
    }

    return true;
}
I don't know if its the best way, but at least its working.

Thanks for you help.
 
Upvote 0 Downvote
Solution
mattch said:
Tested both functions internalMoveItem and internalAddItem, but did not work.

Anyway i just solved my problem doing this:
C++: 
bool IOLoginData::sendPlayerDepotItem(Player* player, uint32_t depotId, Item* sendItem) {
    if (depotId >= 100) {
        return false;
    }

    ItemBlockList itemList;
    PropWriteStream propWriteStream;

    Database* db = Database::getInstance();
    std::ostringstream query;

    query << "DELETE FROM `player_depotitems` WHERE `player_id` = " << player->getGUID();
    db->executeQuery(query.str());

    DBInsert depotQuery("INSERT INTO `player_depotitems` (`player_id`, `pid`, `sid`, `itemtype`, `count`, `attributes`) VALUES ");

    bool added = false;
    for (const auto& it : player->depotChests) {
        if (it.first == depotId) {
            itemList.emplace_back(it.first, sendItem);
            added = true;
        }
        DepotChest* depotChest = it.second;
        for (Item* item : depotChest->getItemList()) {
            itemList.emplace_back(it.first, item);
        }
    }

    if (!added) {
        itemList.emplace_back(depotId, sendItem);
    }

    if (!saveItems(player, itemList, depotQuery, propWriteStream)) {
        return false;
    }

    return true;
}
I don't know if its the best way, but at least its working.

Thanks for you help.
Click to expand...



have example for use? i like your function. what version tfs is?
 
Upvote 0 Downvote
beenii said:
have example for use? i like your function. what version tfs is?
Click to expand...
This?
C++: 
int LuaScriptInterface::luaSendPlayerDepotItem(lua_State* L)
{
    //sendPlayerDepotItem(guid, item[, depotId = 0])
    uint32_t guid = getNumber<uint32_t>(L, 1);
    Item* item = getUserdata<Item>(L, 2);
    if (!item) {
        reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND));
        pushBoolean(L, false);
        return 1;
    }

    if (item->getParent() != VirtualCylinder::virtualCylinder) {
        reportErrorFunc("Item already has a parent");
        pushBoolean(L, false);
        return 1;
    }

    Player* player = g_game.getPlayerByGUID(guid);
    uint32_t depotId = getNumber<uint32_t>(L, 3, 0);
    if (!player) {
        Player tmpPlayer(nullptr);
        if(!IOLoginData::loadPlayerById(&tmpPlayer, guid)) {
            reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND));
            pushBoolean(L, false);
            return 1;
        }

        if (IOLoginData::sendPlayerDepotItem(&tmpPlayer, depotId, item)) {
            ScriptEnvironment::removeTempItem(item);
            pushBoolean(L, true);
        } else {
            pushBoolean(L, false);
        }
    } else {
        DepotChest* depotChest = player->getDepotChest(depotId, true);
        ReturnValue ret = g_game.internalAddItem(depotChest, item, INDEX_WHEREEVER, FLAG_NOLIMIT);
        if (ret == RETURNVALUE_NOERROR) {
            ScriptEnvironment::removeTempItem(item);
        }
        pushBoolean(L, ret == RETURNVALUE_NOERROR);
    }

    return 1;
}

TFS 1.2
 
Upvote 0 Downvote
Could anyone explain how to make it work with mailbox.cpp? I managed to remove inbox and make parcels/letters/house items reach depot, but only if player is online, otherwise they are gone (table player_inboxitems remains empty).
 
Upvote 0 Downvote

Similar threads

donabimbo
  • Question
When opening a container I don't have the option to go back. (inbox)
Replies
11
Views
870
Fjorda
F
xixigisi
  • Question
Market item duplicated
Replies
7
Views
792
johnsamir
johnsamir
johnsamir
  • Question
C++ Help adapt code to make market system works
Replies
0
Views
161
johnsamir
johnsamir
Engradiel
  • Solved
C++ SetCapacity directly in source tfs 1.3
Replies
4
Views
336
Engradiel
Engradiel
Back
Top