Solved [TFS 1.1] onTargetCombat(target) crashes the server

[zbizu]

I'm working on slot system features and I want to add extra damage to weapons. However, function is executed twice and when I try to add any combat, the server crashes.

test function:

function Creature:onTargetCombat(target)
	print(true)
	doTargetCombatHealth(self:getId(), target:getId(), COMBAT_PHYSICALDAMAGE, 1, 10)
	return true
end

 

[Evan]

Wouldn't it be better off using the onUseWeapon() event in the Weapons interface for added damage and more?
Furthermore, if I'm correct, onTargetCombat() is really only for targeting creatures. It is called at the moment you target a creature.
So, using this, I could repeatedly target/untarget really fast to spam damage. It is intended to be called twice, can't remember the reason though.

 

[zbizu]

how do I register "onUseWeapon" for all ids in game?
I could use my items parser to get all ids, but I believe there is more efficient way to do it.

 

[Colors]

I was working on something similar yesterday but the best way that I could find was using the onHealthChange function... At least your server won't crash lol.

 

[zbizu]

I could register onHealthChange on monster through onTargetCombat, great.