TFS 1.X+ [TFS 1.3/4] Wrong SQM's/Tiles blocking?

[Lording]

I'm currently using TFS 1.3/4 Downgrade from Nekiro. Stock code from github and stock OTClient 1.0 from Mehah. This error happens with or without GM account.
I have no idea how to explain this, but I can leave some images. Hope someone can figure it out or has experience with something like this:





The same goes to all area spells or magic walls.

I tried to play with canUseFar function in actions.cpp and looks like checkLineOfSight it's the right one(because it ignore all "blocking tiles"), but I wasn't able to fix it:

ReturnValue Actions::canUseFar(const Creature* creature, const Position& toPos, bool checkLineOfSight, bool checkFloor)
{
if (toPos.x == 0xFFFF) {
return RETURNVALUE_NOERROR;
}

const Position& creaturePos = creature->getPosition();
if (checkFloor && creaturePos.z != toPos.z) {
    return creaturePos.z > toPos.z ? RETURNVALUE_FIRSTGOUPSTAIRS : RETURNVALUE_FIRSTGODOWNSTAIRS;
}

if (!Position::areInRange<7, 5>(toPos, creaturePos)) {
    return RETURNVALUE_TOOFARAWAY;
}

if (checkLineOfSight && !g_game.canThrowObjectTo(creaturePos, toPos, checkLineOfSight, checkFloor)) {
    return RETURNVALUE_CANNOTTHROW;
}

return RETURNVALUE_NOERROR;
}

Thanks for reading

 

[drakylucas]

Maybe related to this?

👁 Fix sight line algorithm 👁 by MillhioreBT · Pull Request #3390 · otland/forgottenserver

Pull Request Prelude I have followed [proper The Forgotten Server code styling][code]. I have read and understood the [contribution guidelines][cont] before making this PR. I am aware that this...

github.com

I don't know if Nekiro downgrade cherry-picked these commits

 

[Lording]

Thank you , ill check these commits in some minutes, way to home.

So this is the problem. There is also a problem in this code I posted now that I have run some more tests..

The gold coins represent here you can throw
The platinum represent where you cannot (but should be able to)

This is the outcome of Zbizu's code

I compared Nekiro's files with TFS main branch (the ones with these commits) and they are 1:1 but looking in threads found this quote.. Is the actual tibia's behaviour? I can't believe.. is the image correct?
Didn't knew tibia changed their SQM throwable spots this way.. Im so confused you ain't supposed to be doing that in 7.x or 8.x+
So you can throw items like on my first image but not magic walls? I really doubt this. Hope someone can take me to the right way.

 

[Lording]

bump

 

[zbizu]

apply this patch for spells:

Fix getDirectionTo method by nekiro · Pull Request #3645 · otland/forgottenserver

This pull request fixes getDirectionTo helper method, which returns some weird direction instead of none if from == to. By the way it also fixes #3643

github.com

 

[Lording]

I throw all these MWALLS in the same spot
This is the result: It changed, it's the same for X(right) or Y(south). before that commit I was able to put 7 mwalls in the X-RIGHT position but only 1 in the Y-SOUTH one(Or viseversa). so Now it doesn't matter I can throw in both lines. I think it's getting to the right way, do you know any other commit I might be missing?. I'm currently looking for them myself too


I've tested more and these are the results for spells:




Spells are working as they should with this commit from nekiro that shared Zbizu in thread. This is the only thing left(Magic walls):

Watch 2021-09-24 19-25-31 | Streamable

Watch "2021-09-24 19-25-31" on Streamable.

streamable.com

This is how It should works:

Is there a way to set a limit in walls ? like in the last video?