C++ [TFS 1.4] onLook: attempt to index local 'thing' (a nil value)

[Ramon Bernardo]

I dont understand why returning null.
Ive made a lot of changes to src and its been hard to track what i changed to give it this.

Lua Script Error: [Event Interface]
data/events/scripts/player.lua: Player@onLook
...data\scripts\eventcallbacks\player\default_onLook.lua:4: attempt to index local 'thing' (a nil value)
stack traceback:
[C]: in function '__index'
...data\scripts\eventcallbacks\player\default_onLook.lua:4: in function <...data\scripts\eventcallbacks\player\default_onLook.lua:3>
...data\scripts\lib\event_callbacks.lua:121: in function 'EventCallback'
data/events/scripts/player.lua:4: in function <data/events/scripts/player.lua:1>

Any suggestions where I should start? Im in this for a few hours...

 

[Ramon Bernardo]

For some reason, this error come from: luascript.cpp/luaTablePack
I added brackets in for loop and receiv error. Reason? I do not know.

old code

for (i = n; i >= 1; i--) /* assign elements */
        lua_rawseti(L, 1, i);
        if (luaL_callmeta(L, -1, "__index") != 0) {
            lua_replace(L, -2);
        }

new code, with error (only brackets added)

for (i = n; i >= 1; i--) { /* assign elements */
        lua_rawseti(L, 1, i);
        if (luaL_callmeta(L, -1, "__index") != 0) {
            lua_replace(L, -2);
        }
}

 

[Ramon Bernardo]

Fixed with Fix misleading indentation and add brackets by ranisalt · Pull Request #3992 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/3992)