TFS A* Algorithm :D

ralke · Jul 29, 2023

Itutorial said:
3) My pathfinding algorithm is so much faster than the original one that you could have it run thousands more times.
You can mess with this value for different results in the path updating speed.

C++:

static constexpr int32_t EVENT_CREATURE_PATH_INTERVAL = 20;

Gave a second read to this, does changing

C++:

static constexpr int32_t EVENT_CREATURE_PATH_INTERVAL = 20;

Will affect RAM performance? If so, raising the value to 30 will make the pathfinding consume less RAM, and decreasing it to 10 for example will make it increase RAM?, and also which values are good choises to place on EVENT_CREATURE_PATH_INTERVAL.

Thanks in advance!

Itutorial · Jul 31, 2023

ralke said:
Gave a second read to this, does changing

C++:

static constexpr int32_t EVENT_CREATURE_PATH_INTERVAL = 20;

Will affect RAM performance? If so, raising the value to 30 will make the pathfinding consume less RAM, and decreasing it to 10 for example will make it increase RAM?, and also which values are good choises to place on EVENT_CREATURE_PATH_INTERVAL.

Thanks in advance!

Yes, it would effect ram usage. However, making it 10 would still be more efficient than using TFS pathfinding especially if you added marks "fix" so the monsters wouldn't lag for a full second before updating their path.

To state why in an easy explanation. These are the fixes that were critical to performance.

1) The old system would check 100 nodes every second as long as the creature was within range (about 12sqm from the target) and there was no path to the target OR it was too far away but is still in range of awareness.

2) The old system used over 10x as many nodes to draw each path.

3) In my system I was able to get even more speed by making paths that aren't blocked (something in between the start and end) ignore nodes it doesn't need to check with some conditional logic.

4) Instead of ALL creatures checking their paths, that EVENT_CREATURE_PATH_INTERVAL will only execute on creatures that NEED to check their path again.

Itutorial · Mar 24, 2024

I have some time so I am working on this system again. I believe I was able to fix all the problems with summons, fleeing creatures, and creatures that keep distance from their targets. You can follow the progress here: Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/4637)

Aeronx · Mar 24, 2024

@Itutorial I've been implementing those changes, but something is wrong with this:

C++:

void Game::checkCreaturesPath(size_t index)
{
    g_scheduler.addEvent(createSchedulerTask(EVENT_CREATURE_PATH_INTERVAL,
                                             [=, this]() { checkCreatures((index + 1) % EVENT_CREATURECOUNT); }));

    auto& checkCreatureList = checkCreatureLists[index];
    auto it = checkCreatureList.begin(), end = checkCreatureList.end();
    while (it != end) {
        Creature* creature = *it;
        if (creature->getHealth() > 0) {
            creature->checkPath();
        }
        ++it;
    }

    cleanup();
}

Code:

Error    C3791    'this' cannot be explicitly captured when the default capture mode is by copy (=)

Mateus Robeerto · Mar 24, 2024

Itutorial said:
I have some time so I am working on this system again. I believe I was able to fix all the problems with summons, fleeing creatures, and creatures that keep distance from their targets. You can follow the progress here: Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/4637)

Is that TFS 1.5 12.87, or Nekiro 1.5? I tried to find it but couldn't, and some are different from my source. Lol.

johnsamir · Mar 24, 2024

Itutorial said:
I have some time so I am working on this system again. I believe I was able to fix all the problems with summons, fleeing creatures, and creatures that keep distance from their targets. You can follow the progress here: Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/4637)

Cool thanks btw off topic you don't have cast system commits I have yours system to your server bug I have an error that won't make me log in I debug it but don't know how to fix it would you lend me a hand? I use TFS 1.4 or 1.5 not sure

omaraboud · Mar 24, 2024

Guys sorry for digging up the topic but I have this huge problem with summons, but my summons are lagged for about 3 seconds after I lock the target. They attack reaction is very slow. The problem is on tfs 1.5 nekiro. @Itutorial

johnsamir · Mar 24, 2024

omaraboud said:
Guys sorry for digging up the topic but I have this huge problem with summons, I'm using Gesior Algo 3 Solved - Weird monster behaviour in TFS 1.1? (https://otland.net/threads/weird-monster-behaviour-in-tfs-1-1.228021/page-2#posts) but my summons are lagged for about 3 seconds after I lock the target. Sometimes they don't even react to player attacking at all and just stay in one place, zero movement. The problem is on tfs 1.5 nekiro. @Itutorial

Are you sure that you added all the commits property and in the right order nottignheters posted it in the thread 2

Post automatically merged: Mar 24, 2024

Nottinghster said:
In that order:

Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793

https://otland.net/threads/tfs-a-algorithm-d.282100/#post-2703975

github.com

Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf

https: //github.com/otland/forgottenserver/pull/4205/files Co-Authored-By: gigastar <[email protected]>

github.com

Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f

https: //otland.net/threads/tfs-a-algorithm-d.282100/#post-2704580 Co-Authored-By: gigastar <[email protected]>

github.com

Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d

Summons followed kind of slow. Adding this allows them to update at the same rate monsters do. Cleaned code in checkPath() Co-Authored-By: gigastar <[email protected]>

github.com

Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b

https: //otland.net/threads/tfs-a-algorithm-d.282100/page-2#post-2704933 Co-Authored-By: gigastar <[email protected]>

github.com

Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0

Co-Authored-By: gigastar <[email protected]>

github.com

.

gabrielks1996 · Mar 24, 2024

I made the changes, but the behavior of the monsters was strange, instead of the monster sticking to the person, he runs and attacks from afar

omaraboud · Mar 24, 2024

Made all changes and there is definite improvement in summon and monster behavior.

Itutorial · Mar 25, 2024

Aeronx said:

@Itutorial I've been implementing those changes, but something is wrong with this:

C++:

void Game::checkCreaturesPath(size_t index)
{
    g_scheduler.addEvent(createSchedulerTask(EVENT_CREATURE_PATH_INTERVAL,
                                             [=, this]() { checkCreatures((index + 1) % EVENT_CREATURECOUNT); }));

    auto& checkCreatureList = checkCreatureLists[index];
    auto it = checkCreatureList.begin(), end = checkCreatureList.end();
    while (it != end) {
        Creature* creature = *it;
        if (creature->getHealth() > 0) {
            creature->checkPath();
        }
        ++it;
    }

    cleanup();
}

Code:

Error    C3791    'this' cannot be explicitly captured when the default capture mode is by copy (=)

Try changing this

C++:

g_scheduler.addEvent(createSchedulerTask(EVENT_CREATURE_PATH_INTERVAL,
                                             [=, this]() { checkCreatures((index + 1) % EVENT_CREATURECOUNT); }));

for one of these

C++:

g_scheduler.addEvent(createSchedulerTask(EVENT_CREATURE_PATH_INTERVAL,
                                             [=, this]() { checkCreaturesPath((index + 1) % EVENT_CREATURECOUNT); }));

g_scheduler.addEvent(createSchedulerTask(EVENT_CREATURE_PATH_INTERVAL,
                                             [=]() { checkCreaturesPath((index + 1) % EVENT_CREATURECOUNT); }));

gabrielks1996 said:
I made the changes, but the behavior of the monsters was strange, instead of the monster sticking to the person, he runs and attacks from afar

Same fix

Extrodus · Mar 25, 2024

Itutorial said:
I have some time so I am working on this system again. I believe I was able to fix all the problems with summons, fleeing creatures, and creatures that keep distance from their targets. You can follow the progress here: Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/4637)

Going to give this a try today and report back on how it's working, this is something that's been needed for awhile - glad to see the efforts still there! Thanks for your contributions

johnsamir · Mar 25, 2024

Mateus Robeerto said:
Is that TFS 1.5 12.87, or Nekiro 1.5? I tried to find it but couldn't, and some are different from my source. Lol.

same thing here reviewved everything and just changed this

Lua:

/*if (followCreature) {
        goToFollowCreature();
    }*/

Fresh · Mar 25, 2024

Anyone have chronologically order of changes that should be applied straight from zero (if I've never messed with it before)?
Thanks

Extrodus · Mar 25, 2024

Fresh said:
Anyone have chronologically order of changes that should be applied straight from zero (if I've never messed with it before)?
Thanks

I wish there was a better way to say it other than, "Look up.." (literally two posts above yours and would have been the second to last before commenting)

johnsamir · Mar 25, 2024

it's posted above here thread 5...

Extrodus · Mar 26, 2024

After some testing it seems like things are working pretty good, much better than before. However one issue seems to be showing, when the player stops moving the monsters return to delayed behavior. Almost feels like it should wait until there is no players on screen to begin that behavior; I've included a video to show you what I mean.
View attachment blazera_Y90Z8mukQZ.mp4

johnsamir · Mar 26, 2024

Nottinghster said:
In that order:

Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793

https://otland.net/threads/tfs-a-algorithm-d.282100/#post-2703975

github.com

Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf

https: //github.com/otland/forgottenserver/pull/4205/files Co-Authored-By: gigastar <[email protected]>

github.com

Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f

https: //otland.net/threads/tfs-a-algorithm-d.282100/#post-2704580 Co-Authored-By: gigastar <[email protected]>

github.com

Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d

Summons followed kind of slow. Adding this allows them to update at the same rate monsters do. Cleaned code in checkPath() Co-Authored-By: gigastar <[email protected]>

github.com

Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b

https: //otland.net/threads/tfs-a-algorithm-d.282100/page-2#post-2704933 Co-Authored-By: gigastar <[email protected]>

github.com

Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0

Co-Authored-By: gigastar <[email protected]>

github.com

did you added all these?

Itutorial · Mar 26, 2024

Extrodus said:
After some testing it seems like things are working pretty good, much better than before. However one issue seems to be showing, when the player stops moving the monsters return to delayed behavior. Almost feels like it should wait until there is no players on screen to begin that behavior; I've included a video to show you what I mean.
View attachment 83231

I am on it. Thanks for testing

Post automatically merged: Mar 26, 2024

johnsamir said:
did you added all these?

No it only includes the two repos by gigastar (me). Those are also old and I didn't have to do everything I did in those repos. You should be able to add any of those other changes by other authors after you install my system

Extrodus · Mar 26, 2024

Itutorial said:
I am on it

Post automatically merged: Mar 26, 2024

No it only includes the two repos by gigastar (me). Those are also old and I didn't have to do everything I did in those repos. You should be able to add any of those other changes by other authors after you install my system

Wonderful, Ill give it a test when its updated and report back <3

TFS A* Algorithm :D

(҂ ͠❛ ෴ ͡❛)ᕤ

Legendary OT User

Legendary OT User

Intermediate OT User

Excellent OT User

Advanced OT User

Member

Advanced OT User

New Member

Member

Legendary OT User

|| Blazera.net ||

Advanced OT User

Quack!

|| Blazera.net ||

Advanced OT User

|| Blazera.net ||

Advanced OT User

Legendary OT User

|| Blazera.net ||

Similar threads

(҂ ͠❛ ෴ ͡❛)ᕤ