TFS A* Algorithm :D

[ralke]

@Itutorial applied two last commits. Man need to say it, the outcome is fucking amazing.
Here goes the video testing. So much better than before!

Optimize pathfinding by NRH-AA · ralke23/Greed-TFS-1.5-Downgrades@efdd636

Added new pathfinding checks, at 14/04/2024. https://youtu.be/ws-oo1hkM2Q Co-Authored-By: Nathan Heinz <[email protected]>

github.com

Pointed a little thing on Orcs, and tagged some stuff.
I'll keep testing but now it's running live so more feedback will come.

Regards!

 

[johnsamir]

@Itutorial applied two last commits. Man need to say it, the outcome is fucking amazing.
Here goes the video testing. So much better than before!

Optimize pathfinding by NRH-AA · ralke23/Greed-TFS-1.5-Downgrades@efdd636

Added new pathfinding checks, at 14/04/2024. https://youtu.be/ws-oo1hkM2Q Co-Authored-By: Nathan Heinz <[email protected]>

github.com

Pointed a little thing on Orcs, and tagged some stuff.
I'll keep testing but now it's running live so more feedback will come.

Regards!

can you share the order of the commits pls?
should i start from here?

• Fir3lement 0.4 goToFollowCreature​

  
  ralke23
  committed8 months ago
  
  
  
  404c478

Commits on Aug 5, 2023​

• Change to EVENT_CREATURE_PATH_INTERVAL​

  
  ralke23
  committed8 months ago

 

[ralke]

can you share the order of the commits pls?
should i start from here?

• Fir3lement 0.4 goToFollowCreature​

  
  ralke23
  committed8 months ago
  
  
  
  404c478

Commits on Aug 5, 2023​

• Change to EVENT_CREATURE_PATH_INTERVAL​

  
  ralke23
  committed8 months ago

Ok untill this post TFS A* Algorithm :D (https://otland.net/threads/tfs-a-algorithm-d.282100/page-7#post-2749869) it's everything fine.
According to what @Itutorial said, this are the only changes you should have:

These are the only changes you should have.

Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver

Pull Request Prelude I have followed proper The Forgotten Server code styling. I have read and understood the contribution guidelines before making this PR. I am aware that this PR may be clo...

github.com

And you will also need this:

That looks good to me but at the same time I don't play RL tibia which I know is what we aim for. I would still make the the two changes I made today on the official PR. They are kind of critical and shouldn't change the behavior you just showed it will however fix a couple lags in pathfinding updates.

Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver

Pull Request Prelude I have followed proper The Forgotten Server code styling. I have read and understood the contribution guidelines before making this PR. I am aware that this PR may be clo...

github.com

Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver

Pull Request Prelude I have followed proper The Forgotten Server code styling. I have read and understood the contribution guidelines before making this PR. I am aware that this PR may be clo...

github.com

To this point, everything works just fine.

@onTopic

At discord we discussed with @Itutorial about blocked sight paths that comes from "far distance" or "inside walls". Not sure how to explain it, but if a monster look to you from the inside of walls and have clear path route it should be able to actually get you. For this Itutorial did some updates:



I don't recommend to merge this yet. We're in the process of testing this, is definitely a good implementation but it has a serious memory leak issue. I will shutdown my own server for a little bit till' we get this solved. I commited this if someone wishes to look at the code, but again, DONT MERGE THIS YET.

Path viewport check, fix to blocked sight of monsters (needs review, … · ralke23/Greed-TFS-1.5-Downgrades@d001657

…it causes lag and memory increase) Co-Authored-By: Nathan Heinz <[email protected]>

github.com

Evidence:


Regards!

 

[Itutorial]

Memory leak fixed on newest commit.

 

[Mateus Robeerto]

Ok untill this post TFS A* Algorithm :D (https://otland.net/threads/tfs-a-algorithm-d.282100/page-7#post-2749869) it's everything fine.
According to what @Itutorial said, this are the only changes you should have:

And you will also need this:

To this point, everything works just fine.

@onTopic

At discord we discussed with @Itutorial about blocked sight paths that comes from "far distance" or "inside walls". Not sure how to explain it, but if a monster look to you from the inside of walls and have clear path route it should be able to actually get you. For this Itutorial did some updates:

View attachment 83777

I don't recommend to merge this yet. We're in the process of testing this, is definitely a good implementation but it has a serious memory leak issue. I will shutdown my own server for a little bit till' we get this solved. I commited this if someone wishes to look at the code, but again, DONT MERGE THIS YET.

Path viewport check, fix to blocked sight of monsters (needs review, … · ralke23/Greed-TFS-1.5-Downgrades@d001657

…it causes lag and memory increase) Co-Authored-By: Nathan Heinz <[email protected]>

github.com

Evidence:
View attachment 83778

Regards!

I compared it for testing with TFS 1.4.3 and 1.5 Nekiro, but I noticed a significant difference.

Tfs 1.5 nekiro 8.6
The last time I made changes was in the source code here.

Solved - Weird monster behaviour in TFS 1.1?

The monster AI in tfs 1.1 (idk about 1.0) is EXTREMELY dumb. This has discouraged me from using TFS 1.1 even though i've spent so much time with it. A couple of examples: If you chase any ranged mob, let's take lizard legionaire, they will turn around every time they make an attack and this...

otland.net

TFS 1.X+ - Bad reaction/dodge from monsters

Monsters in TFS 1.5 have a very different reaction(dodge, in TFS 0.4 the monster could dodge the players, which is quite necessary, in TFS 1.5 (it may happen the same in some other TFS) this doesn't happen... Besides other bugs which were seen by @Levi999x Well, I have added the changes of...

otland.net

Look at the screenshot to see how the memory usage turned out. Just opening the executable already showed nearly 700MB, with nothing else running. Imagine what it'll be like once start playing the game...



Now on my TFS 1.4.3, which I've already modified quite a bit... and see how it's consuming memory.



Everything's fine when I enter the game and summon many random monsters; it's not consuming too quickly. It always stays at 0%, slowly increasing memory usage.

Thank goodness I abandoned TFS 1.5 Nekiro and migrated to TFS 1.4 10.98, which I really liked. I modified it to be identical to the old Evoutions 7.92 made by Xiaodzu, with exhaust, push delay, and everything else, very similar to Evoutions 7.92. I'm already satisfied with the base I chose

 

[Itutorial]

I compared it for testing with TFS 1.4.3 and 1.5 Nekiro, but I noticed a significant difference.

Tfs 1.5 nekiro 8.6
The last time I made changes was in the source code here.

Solved - Weird monster behaviour in TFS 1.1?

The monster AI in tfs 1.1 (idk about 1.0) is EXTREMELY dumb. This has discouraged me from using TFS 1.1 even though i've spent so much time with it. A couple of examples: If you chase any ranged mob, let's take lizard legionaire, they will turn around every time they make an attack and this...

otland.net

TFS 1.X+ - Bad reaction/dodge from monsters

Monsters in TFS 1.5 have a very different reaction(dodge, in TFS 0.4 the monster could dodge the players, which is quite necessary, in TFS 1.5 (it may happen the same in some other TFS) this doesn't happen... Besides other bugs which were seen by @Levi999x Well, I have added the changes of...

otland.net

Look at the screenshot to see how the memory usage turned out. Just opening the executable already showed nearly 700MB, with nothing else running. Imagine what it'll be like once start playing the game...
View attachment 83787


Now on my TFS 1.4.3, which I've already modified quite a bit... and see how it's consuming memory.

View attachment 83788

Everything's fine when I enter the game and summon many random monsters; it's not consuming too quickly. It always stays at 0%, slowly increasing memory usage.

Thank goodness I abandoned TFS 1.5 Nekiro and migrated to TFS 1.4 10.98, which I really liked. I modified it to be identical to the old Evoutions 7.92 made by Xiaodzu, with exhaust, push delay, and everything else, very similar to Evoutions 7.92. I'm already satisfied with the base I chose

Yeah it seems nekiros downgrade has something in it that is causing high memory usage. Ralke is having the same problem. His server opens at like 1Gig and climbs from there. I saw it at a high of 1.9gigs. I am surprised he was even able to see the memory leak from my pathfinding. I would suggest not using nekiros downgrade until it is addressed.

As a rule of thumb I am using 1.4.3 upgraded to 1.5 sources current and my server opens at 45mb and climbs very slowly due to the memory leaks that are inherit in the sources atm.

 

[Marko999x]

Nekiro's TFS 1.5 is not bad it just need few fixes



Anyway how do you get those high ram on nekiros tfs?
Mine has on same map less

First picture is 1.4.2
Second picture is 1.5 from Nekiro

 

[Nokturno]

Memory leak fixed on newest commit.

sup mate, can you link that commit?

 

[Marko999x]

@Itutorial @ralke

Idk if its because of the path finding but I have the problem if I follow a creature or a player then right click someone on the map he goes there and move's always up/down instead of going back to the creature
Overall the follow attack thing is weird acting

 

[Itutorial]

Nekiro's TFS 1.5 is not bad it just need few fixes

View attachment 83797View attachment 83798

Anyway how do you get those high ram on nekiros tfs?
Mine has on same map less

First picture is 1.4.2
Second picture is 1.5 from Nekiro

Im glad someone else using it was able to message about this. Very strange. I don't get what could possible cause their servers to start at over a gig.

sup mate, can you link that commit?

Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver

Pull Request Prelude I have followed proper The Forgotten Server code styling. I have read and understood the contribution guidelines before making this PR. I am aware that this PR may be clo...

github.com

Post automatically merged: Apr 15, 2024

@Itutorial @ralke

Idk if its because of the path finding but I have the problem if I follow a creature or a player then right click someone on the map he goes there and move's always up/down instead of going back to the creature
Overall the follow attack thing is weird acting

Not sure I understand this. Right click someone on the map? Does your client not stop the player from following when they click on map?

 

[Marko999x]

Im glad someone else using it was able to message about this. Very strange. I don't get what could possible cause their servers to start at over a gig.

Optimize pathfinding by NRH-AA · Pull Request #4637 · otland/forgottenserver

Pull Request Prelude I have followed proper The Forgotten Server code styling. I have read and understood the contribution guidelines before making this PR. I am aware that this PR may be clo...

github.com

Post automatically merged: Apr 15, 2024

Not sure I understand this. Right click someone on the map? Does your client not stop the player from following when they click on map?

It stops when you click with left click (mouse left click) but not with right click (mouse right click)
Edit: that's how its supposed to be.. Left click should stop and right click should player move to the position where u right clicked and go back to the monster

 

[ralke]

Not sure I understand this. Right click someone on the map? Does your client not stop the player from following when they click on map?

Can't confirm on server side because I don't have a working enviroment yet, but I can confirm that it is real tibia behaviour. When you follow a player, and you right click on other tile (sqm, item, whatever), it goes to the target (the tile you clicked with right click) and after finishing that action, it start following the player (followed target) again. Hope I explained it well, anyways you can ask me for this on discord.

In resume. Does your client not stop the player from following when they click on map? The answer is yes, client doesn't stop player from following.
But. If i'm not wrong, this doesn't apply to attacking with chase option.

@onTopic

I opened the following thread so we can handle nekiro's memory leak separately.

TFS 1.X+ - Help with recent memory commit logs

Hi there! I'm seeking with @Itutorial if someone can provide logs of recent fixes for memory leaks on theforgottenserver. I forked my own server from nekiro's achieved repository (TFS 1.5 downgrades) and started from that point. So I missed the most of recent TFS optimizations. We have noticed...

otland.net

• I can say in resume that 1.4.2 works good with this algorythm (based on the recent feedback you guys posted).
• Reviewing this thread was really good because leads us to take a depth review on nekiro downgrades.
• There's huge differences in sources between achieved nekiro downgrade repository and current tfs, we're reviewing them.

I feel kinda stressed yesterday about all this, but I guess that patience and hard work is the key here (even if i'm not directly coding, the merging and testing process is also exhaustive). So please don't get hasty conclusions in a work that is currently in process. Everyone here is wanting to enhance server performance, and it will take some time. An special thank for everyone who's getting involved in the thread.

Regards!

 

[iNux]

I want to try to implement it into TFS 1.2, would you guys mind sharing the commits, and the changes that have been added? I cannot see a commit history that I can follow and check. If there is, kindly post it

 

[ralke]

Updated Greed repository, added latest changes:

NRH-AA latest changes · ralke23/Greed-TFS-1.5-Downgrades@81f7784

- Revert int declarations in pathmatching - Add memory management to follow list and pathmatching Co-Authored-By: Nathan Heinz <[email protected]>

github.com

Also did some optimizations to use less memory (debugging scripts to check their ms and decreasing map size). I will be monitoring memory today to see if the changes work. Also, if someone wishes to compile Greed-TFS-1.5-Downgrades it uses an old version of vcpkg that I uploaded to google drive. I'm not sure if I can upload the link directly here, but send me a PM if someone needs the vcpkg to compile and test it.

I want to try to implement it into TFS 1.2, would you guys mind sharing the commits, and the changes that have been added? I cannot see a commit history that I can follow and check. If there is, kindly post it

Here ^^

Commits · NRH-AA/forgottenserver

A free and open-source MMORPG server emulator written in C++ - Commits · NRH-AA/forgottenserver

github.com

It stops when you click with left click (mouse left click) but not with right click (mouse right click)
Edit: that's how its supposed to be.. Left click should stop and right click should player move to the position where u right clicked and go back to the monster

Just tested, follow creature works like it should now! ^^

 

[ralke]

Test with memory at side. Will see how it goes with more people. Thanks again @Itutorial

 

[johnsamir]

Test with memory at side. Will see how it goes with more people. Thanks again @Itutorial

the cpu usage is still high you changed something?
edit reverted the commits and the cpu usage is still high lol 2,542 mb

Post automatically merged: Apr 22, 2024

Nekiro's TFS 1.5 is not bad it just need few fixes

View attachment 83797View attachment 83798

Anyway how do you get those high ram on nekiros tfs?
Mine has on same map less

First picture is 1.4.2
Second picture is 1.5 from Nekiro

can you share what did u change?

 

[Marko999x]

the cpu usage is still high you changed something?
edit reverted the commits and the cpu usage is still high lol 2,542 mb

Post automatically merged: Apr 22, 2024

can you share what did u change?

I didn't change anything
Im using default

 

[ralke]

Just did this post, im going to copy paste that here. Guys can't be more clean than this.

TFS 1.X+ - Help with recent memory commit logs

Hi there! I'm seeking with @Itutorial if someone can provide logs of recent fixes for memory leaks on theforgottenserver. I forked my own server from nekiro's achieved repository (TFS 1.5 downgrades) and started from that point. So I missed the most of recent TFS optimizations. We have noticed...

otland.net

I'll try to do it the easier as possible. Do the following to merge (some commits will tell you to do this... and then revert that... just don't delete & go, sometimes use // to comment code in case you probably have to add it later):

The following commit logs must be applied from achieved nekiro downgrade repository (8.6, 8.0, whatever).

1. Gigastar A* pathfinding Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/45f9793faa63201db903bc79d724bae80c9b6f46)
2. Gigastar pathfinding call Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/eb642bf87f76c600479abdc16201af816183dead)
3. Method set master position Method setMasterPosition · ralke23/Greed-TFS-1.5-Downgrades@8f2d82a (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/8f2d82ad839cde1612cc8ac6dc9c8f0ecbc855d6)
4. Update follow path Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/3077e8f539a216cbbbaa2d056c35427057aea482)
5. PLAYER_SEARCHDIST PLAYER_SEARCHDIST · ralke23/Greed-TFS-1.5-Downgrades@b73d122 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/b73d122ab47035e0cc7e6c126a6db463f42c7555)
6. getPathTo (position to pos) getPathTo (position to pos) · ralke23/Greed-TFS-1.5-Downgrades@9a440f3 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/9a440f39610b684fefc1ca8c1b1f16ab410093e1)
7. Add follow position to follow creature Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/044299d305d2e744d294c8799c2a86630903b24d)
8. Summon keepDistance, isInRange, distance check Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/50d9f7bc8c311c487cf840123808e7f7dc7aaeaa)
9. Corrections Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d105eb0d917f2814ec9408f3c8bbe2710d7b9eba)
10. 9 players stackpos bug 9 players stackpos bug · ralke23/Greed-TFS-1.5-Downgrades@4473d68 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4473d6806ea7420bc78cf58b1fea28e991acf67d)
11. Fir3lement 0.4 goToFollowCreature Fir3lement 0.4 goToFollowCreature · ralke23/Greed-TFS-1.5-Downgrades@404c478 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/404c478dd10811a9a2275bce9e0b94c18df0923c)
12. NRH-AA Pathfinding NRH-AA Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@570c4d7 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/570c4d7b3aef10166ae8ab52f87ffa167ab70415)
13. First adjustments on NRH-A Pathfinding First adjustments on NRH-A Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@d5670ec (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d5670ec78becd3ec9fa6eb60b4304628381ad78c)
14. Optimize pathfinding by NRH-AA Optimize pathfinding by NRH-AA · ralke23/Greed-TFS-1.5-Downgrades@efdd636 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/efdd636193d4a50df88733811631cf0afa161c92)
15. Path viewport check, fix to blocked sight of monsters (needs review, it causes lag and memory increase) https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d0016579d68c06570487444e62e29137bf3c5eed
16. NRA-AA fixing memory leaks https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4fc0dfa394249ca212690d0e62d456fa6433adb6
17. NRH-AA latest changes https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/81f7784fccd6ebd074e4b22b6f72488c5eda6123

Can't be more easy to follow than this. Remember. You need to use achieved Nekiro distribution.
Regards!

 

[iNux]

Just did this post, im going to copy paste that here. Guys can't be more clean than this.

TFS 1.X+ - Help with recent memory commit logs

Hi there! I'm seeking with @Itutorial if someone can provide logs of recent fixes for memory leaks on theforgottenserver. I forked my own server from nekiro's achieved repository (TFS 1.5 downgrades) and started from that point. So I missed the most of recent TFS optimizations. We have noticed...

otland.net

I'll try to do it the easier as possible. Do the following to merge (some commits will tell you to do this... and then revert that... just don't delete & go, sometimes use // to comment code in case you probably have to add it later):

The following commit logs must be applied from achieved nekiro downgrade repository (8.6, 8.0, whatever).

1. Gigastar A* pathfinding Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/45f9793faa63201db903bc79d724bae80c9b6f46)
2. Gigastar pathfinding call Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/eb642bf87f76c600479abdc16201af816183dead)
3. Method set master position Method setMasterPosition · ralke23/Greed-TFS-1.5-Downgrades@8f2d82a (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/8f2d82ad839cde1612cc8ac6dc9c8f0ecbc855d6)
4. Update follow path Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/3077e8f539a216cbbbaa2d056c35427057aea482)
5. PLAYER_SEARCHDIST PLAYER_SEARCHDIST · ralke23/Greed-TFS-1.5-Downgrades@b73d122 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/b73d122ab47035e0cc7e6c126a6db463f42c7555)
6. getPathTo (position to pos) getPathTo (position to pos) · ralke23/Greed-TFS-1.5-Downgrades@9a440f3 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/9a440f39610b684fefc1ca8c1b1f16ab410093e1)
7. Add follow position to follow creature Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/044299d305d2e744d294c8799c2a86630903b24d)
8. Summon keepDistance, isInRange, distance check Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/50d9f7bc8c311c487cf840123808e7f7dc7aaeaa)
9. Corrections Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d105eb0d917f2814ec9408f3c8bbe2710d7b9eba)
10. 9 players stackpos bug 9 players stackpos bug · ralke23/Greed-TFS-1.5-Downgrades@4473d68 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4473d6806ea7420bc78cf58b1fea28e991acf67d)
11. Fir3lement 0.4 goToFollowCreature Fir3lement 0.4 goToFollowCreature · ralke23/Greed-TFS-1.5-Downgrades@404c478 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/404c478dd10811a9a2275bce9e0b94c18df0923c)
12. NRH-AA Pathfinding NRH-AA Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@570c4d7 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/570c4d7b3aef10166ae8ab52f87ffa167ab70415)
13. First adjustments on NRH-A Pathfinding First adjustments on NRH-A Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@d5670ec (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d5670ec78becd3ec9fa6eb60b4304628381ad78c)
14. Optimize pathfinding by NRH-AA Optimize pathfinding by NRH-AA · ralke23/Greed-TFS-1.5-Downgrades@efdd636 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/efdd636193d4a50df88733811631cf0afa161c92)
15. Path viewport check, fix to blocked sight of monsters (needs review, it causes lag and memory increase) Path viewport check, fix to blocked sight of monsters (needs review, … · ralke23/Greed-TFS-1.5-Downgrades@d001657 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d0016579d68c06570487444e62e29137bf3c5eed)
16. NRA-AA fixing memory leaks NRA-AA fixing memory leaks · ralke23/Greed-TFS-1.5-Downgrades@4fc0dfa (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4fc0dfa394249ca212690d0e62d456fa6433adb6)
17. NRH-AA latest changes NRH-AA latest changes · ralke23/Greed-TFS-1.5-Downgrades@81f7784 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/81f7784fccd6ebd074e4b22b6f72488c5eda6123)

Can't be more easy to follow than this. Remember. You need to use achieved Nekiro distribution.
Regards!

Thank you very much! I appreciate it, I would like to ask you what you mean by, you need to use achieved Nekiro distribution. I would like to implement this into TFS 1.2

 

[Me again]

Just did this post, im going to copy paste that here. Guys can't be more clean than this.

TFS 1.X+ - Help with recent memory commit logs

Hi there! I'm seeking with @Itutorial if someone can provide logs of recent fixes for memory leaks on theforgottenserver. I forked my own server from nekiro's achieved repository (TFS 1.5 downgrades) and started from that point. So I missed the most of recent TFS optimizations. We have noticed...

otland.net

I'll try to do it the easier as possible. Do the following to merge (some commits will tell you to do this... and then revert that... just don't delete & go, sometimes use // to comment code in case you probably have to add it later):

The following commit logs must be applied from achieved nekiro downgrade repository (8.6, 8.0, whatever).

1. Gigastar A* pathfinding Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/45f9793faa63201db903bc79d724bae80c9b6f46)
2. Gigastar pathfinding call Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/eb642bf87f76c600479abdc16201af816183dead)
3. Method set master position Method setMasterPosition · ralke23/Greed-TFS-1.5-Downgrades@8f2d82a (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/8f2d82ad839cde1612cc8ac6dc9c8f0ecbc855d6)
4. Update follow path Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/3077e8f539a216cbbbaa2d056c35427057aea482)
5. PLAYER_SEARCHDIST PLAYER_SEARCHDIST · ralke23/Greed-TFS-1.5-Downgrades@b73d122 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/b73d122ab47035e0cc7e6c126a6db463f42c7555)
6. getPathTo (position to pos) getPathTo (position to pos) · ralke23/Greed-TFS-1.5-Downgrades@9a440f3 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/9a440f39610b684fefc1ca8c1b1f16ab410093e1)
7. Add follow position to follow creature Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/044299d305d2e744d294c8799c2a86630903b24d)
8. Summon keepDistance, isInRange, distance check Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/50d9f7bc8c311c487cf840123808e7f7dc7aaeaa)
9. Corrections Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d105eb0d917f2814ec9408f3c8bbe2710d7b9eba)
10. 9 players stackpos bug 9 players stackpos bug · ralke23/Greed-TFS-1.5-Downgrades@4473d68 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4473d6806ea7420bc78cf58b1fea28e991acf67d)
11. Fir3lement 0.4 goToFollowCreature Fir3lement 0.4 goToFollowCreature · ralke23/Greed-TFS-1.5-Downgrades@404c478 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/404c478dd10811a9a2275bce9e0b94c18df0923c)
12. NRH-AA Pathfinding NRH-AA Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@570c4d7 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/570c4d7b3aef10166ae8ab52f87ffa167ab70415)
13. First adjustments on NRH-A Pathfinding First adjustments on NRH-A Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@d5670ec (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d5670ec78becd3ec9fa6eb60b4304628381ad78c)
14. Optimize pathfinding by NRH-AA Optimize pathfinding by NRH-AA · ralke23/Greed-TFS-1.5-Downgrades@efdd636 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/efdd636193d4a50df88733811631cf0afa161c92)
15. Path viewport check, fix to blocked sight of monsters (needs review, it causes lag and memory increase) Path viewport check, fix to blocked sight of monsters (needs review, … · ralke23/Greed-TFS-1.5-Downgrades@d001657 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/d0016579d68c06570487444e62e29137bf3c5eed)
16. NRA-AA fixing memory leaks NRA-AA fixing memory leaks · ralke23/Greed-TFS-1.5-Downgrades@4fc0dfa (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/4fc0dfa394249ca212690d0e62d456fa6433adb6)
17. NRH-AA latest changes NRH-AA latest changes · ralke23/Greed-TFS-1.5-Downgrades@81f7784 (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/commit/81f7784fccd6ebd074e4b22b6f72488c5eda6123)

Can't be more easy to follow than this. Remember. You need to use achieved Nekiro distribution.
Regards!

Thanks a lot! I am using 8.6 nekiro 1.5 downgrade so it should be ok right? Then i will implement this tonight and test