TFS A* Algorithm :D

[ralke]

Creature:nThink() @ralke

replace

forceUpdateFollowPath = true

with

if (followCreature) {
        goToFollowCreature();
    }

    forceUpdateFollowPath = true;

Fixes are pushed to github (only need the path call one ralke)

Done ^^

Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f

https: //otland.net/threads/tfs-a-algorithm-d.282100/#post-2704580 Co-Authored-By: gigastar <[email protected]>

github.com

But still says that There is no way.


Tried clicking sewers and thoose stuff too
What is wrong? Thanks in advance!!

Post automatically merged: Sep 11, 2022

Edit: I saw some other commits, going to apply and see how it goes

Add searchDist to player getPathTo · NRH-AA/forgottenserver@69b74af

We use max search dist in getPathMatching in the A* fixes. This will be required for that to work correctly. The code will not run if the maxSearchDist is too low compared to targetPos distance. S...

github.com

PLAYER_SEARCHDIST · NRH-AA/forgottenserver@30c5722

Easy access to change how far a players view range is to: moveitems, move players, move mosnters. Ect.

github.com

forceUpdateFollowPath · NRH-AA/forgottenserver@34e7072

A free and open-source MMORPG server emulator written in C++ - forceUpdateFollowPath · NRH-AA/forgottenserver@34e7072

github.com

What else must be added?? If you could link me to it i'll apreciate it !!

Here's my change history

Commits · ralke23/Greed-TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - Commits · ralke23/Greed-TFS-1.5-Downgrades

github.com

 

[Itutorial]

Done ^^

Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f

https: //otland.net/threads/tfs-a-algorithm-d.282100/#post-2704580 Co-Authored-By: gigastar <[email protected]>

github.com

But still says that There is no way.
View attachment 70479

Tried clicking sewers and thoose stuff too
What is wrong? Thanks in advance!!

Post automatically merged: Sep 11, 2022

Edit: I saw some other commits, going to apply and see how it goes

Add searchDist to player getPathTo · NRH-AA/forgottenserver@69b74af

We use max search dist in getPathMatching in the A* fixes. This will be required for that to work correctly. The code will not run if the maxSearchDist is too low compared to targetPos distance. S...

github.com

PLAYER_SEARCHDIST · NRH-AA/forgottenserver@30c5722

Easy access to change how far a players view range is to: moveitems, move players, move mosnters. Ect.

github.com

forceUpdateFollowPath · NRH-AA/forgottenserver@34e7072

A free and open-source MMORPG server emulator written in C++ - forceUpdateFollowPath · NRH-AA/forgottenserver@34e7072

github.com

What else must be added?? If you could link me to it i'll apreciate it !!

Here's my change history

Commits · ralke23/Greed-TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - Commits · ralke23/Greed-TFS-1.5-Downgrades

github.com

Check the github changes. You need to change in game.cpp

Change all

player->getPathTo

it will look something like this

if (player->getPathTo(movingCreatureOrigPos, listDir, 0, 1, true, true)) {

add , PLAYER_SEARCHDIST to end of all to look like this

if (player->getPathTo(movingCreatureOrigPos, listDir, 0, 1, true, true, PLAYER_SEARCHDIST)) {

Make sure to only add to end. Don't change any values in it other than that.

Then in player.h
under

static constexpr int32_t PLAYER_MIN_SPEED = 10;

add

static constexpr int32_t PLAYER_SEARCHDIST = 9;

 

[ralke]

Check the github changes. You need to change in game.cpp

Change all

player->getPathTo

it will look something like this

if (player->getPathTo(movingCreatureOrigPos, listDir, 0, 1, true, true)) {

add , PLAYER_SEARCHDIST to end of all to look like this

if (player->getPathTo(movingCreatureOrigPos, listDir, 0, 1, true, true, PLAYER_SEARCHDIST)) {

Make sure to only add to end. Don't change any values in it other than that.

Then in player.h
under

static constexpr int32_t PLAYER_MIN_SPEED = 10;

add

static constexpr int32_t PLAYER_SEARCHDIST = 9;

Think I missed something, I got this error log


It shows me this potential fix

 

[ralke]

Fixed! Now it works perfectly thanks to @Itutorial

getPathTo (position to pos) · ralke23/Greed-TFS-1.5-Downgrades@9a440f3

Parameter position is not defined, pos is defined instead. Co-Authored-By: gigastar <[email protected]>

github.com

Forward modifications can be tracked here too

Commits · ralke23/Greed-TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - Commits · ralke23/Greed-TFS-1.5-Downgrades

github.com

Regards!!!

 

[Itutorial]

Be sure to implement the newest commits from this morning. Fixed summons keepDistance. They will walk away if you are too close now. Also fixed an issue which made them stop following after x distance because of the keepDistance fix and lastly fixed the path updating for following. It was constantly updating very fast. Now it will only update if it needs to.

@ralke

 

[Extrodus]

Be sure to implement the newest commits from this morning. Fixed summons keepDistance. They will walk away if you are too close now. Also fixed an issue which made them stop following after x distance because of the keepDistance fix and lastly fixed the path updating for following. It was constantly updating very fast. Now it will only update if it needs to.

@ralke

Could you create a new github with one specific commit that addresses the changes for the system?

 

[Itutorial]

Could you create a new github with one specific commit that addresses the changes for the system?

Once it is ready to merge I will. There isn't much too it really. Both the pull requests do one thing each.

1) Call path update whenever it is needed (so we don't get walking delays)
2) Make the pathfinding faster so it takes less performance to use.

All other changes have just been things that broke because of the difference in the pathfinding system.

If summons didn't walk away in default TFS then one of the commits made it so they do. It was kind of related so I added it in.

 

[ralke]

Be sure to implement the newest commits from this morning. Fixed summons keepDistance. They will walk away if you are too close now. Also fixed an issue which made them stop following after x distance because of the keepDistance fix and lastly fixed the path updating for following. It was constantly updating very fast. Now it will only update if it needs to.

@ralke

Perfect! Worked! In case someone else looks at this, be sure to merge "Add min distance check" this way distX and distY won't show as undefined.

Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b

https: //otland.net/threads/tfs-a-algorithm-d.282100/page-2#post-2704933 Co-Authored-By: gigastar <[email protected]>

github.com

 

[Pox]

Not sure if its only me?
The commits are abit messy to follow, some overwrites others etc... but I should have gotten them all

 

[Itutorial]

Not sure if its only me?
The commits are abit messy to follow, some overwrites others etc... but I should have gotten them all

View attachment 70847

Yeah, I found this same problem while doing some testing. I haven't posted the fix for it yet because I am still testing. You should be able to change this to fix it:

map.cpp

// We are at the target and don't need to walk away. No need to update path.
    if (!fpp.keepDistance && fpp.minTargetDist <= 1 && distX < 2 && distY < 2) {
        return false;
    }

to

// We are at the target and don't need to walk away. No need to update path.
    if (!fpp.keepDistance && fpp.minTargetDist <= 1 && distX < 2 && distY < 2) {
        return true;
    }

 

[Diarreamental]

Cool

up sorry for double post, could somebody point me out which are the requeried changes in order to apply the "new monster behavior" please? i can see many references from differentes autoerhs i must apply all ? which one to choose?

thanks

 

[mameca123]

Cool

up sorry for double post, could somebody point me out which are the requeried changes in order to apply the "new monster behavior" please? i can see many references from differentes autoerhs i must apply all ? which one to choose?

thanks

I have the same question. Is it possible for someone to summarize what is needed? Because some of the git commits overlap others.

 

[Nottinghster]

In that order:

Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793

https://otland.net/threads/tfs-a-algorithm-d.282100/#post-2703975

github.com

Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf

https: //github.com/otland/forgottenserver/pull/4205/files Co-Authored-By: gigastar <[email protected]>

github.com

Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f

https: //otland.net/threads/tfs-a-algorithm-d.282100/#post-2704580 Co-Authored-By: gigastar <[email protected]>

github.com

Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d

Summons followed kind of slow. Adding this allows them to update at the same rate monsters do. Cleaned code in checkPath() Co-Authored-By: gigastar <[email protected]>

github.com

Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b

https: //otland.net/threads/tfs-a-algorithm-d.282100/page-2#post-2704933 Co-Authored-By: gigastar <[email protected]>

github.com

Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0

Co-Authored-By: gigastar <[email protected]>

github.com

 

[Diarreamental]

is there a way to add or replace all this commits without doing it manually code by code 1 by one? pleas enlighten me
if im using tfs 1.4?

 

[ralke]

is there a way to add or replace all this commits without doing it manually code by code 1 by one? pleas enlighten me
if im using tfs 1.4?

I don't know exactly how but I think that you can compare the Greed repository with a clean TFS-1.5 Nekiro downgrade and just start importing the changes from compare. Otherwise, if you don't have source changes that you must keep, just use that sources are clean TFS-downgrades with some little addings (see logs).

 

[Diarreamental]

i added all the commits menthiones by @Nottinghster and i having the same compiling errors as in the clean repository

1>database.cpp
1>C:\Users\diap\Documents\GitHub\Greed-TFS-1.5-Downgrades\src\creature.cpp(225,2): error C2065: 'isUpdatingPath': undeclared identifier
1>C:\Users\diap\Documents\GitHub\Greed-TFS-1.5-Downgrades\src\creature.cpp(245,21): warning C4390: ';': empty controlled statement found; is this the intent?
1>databasemanager.cpp

How to solve this? To fix the second error, I just deleted the semicolon, but don't know how to declare isupdating path

edited: there was an error with cherry-picking, I just changed the whole code and now have compiled it

Post automatically merged: Oct 28, 2022

This is incredible work, very smooth in comparison with tfs normal behavior thanks

and i think there are many more commits involved, at least I have used the ones displayed in GitHub desktop

In that order:

Gigastar A* Pathfinding · ralke23/Greed-TFS-1.5-Downgrades@45f9793

https://otland.net/threads/tfs-a-algorithm-d.282100/#post-2703975

github.com

Gigastar Pathfinding Call · ralke23/Greed-TFS-1.5-Downgrades@eb642bf

https: //github.com/otland/forgottenserver/pull/4205/files Co-Authored-By: gigastar <[email protected]>

github.com

Update Follow Path · ralke23/Greed-TFS-1.5-Downgrades@3077e8f

https: //otland.net/threads/tfs-a-algorithm-d.282100/#post-2704580 Co-Authored-By: gigastar <[email protected]>

github.com

Add followPosition to followCreature · ralke23/Greed-TFS-1.5-Downgrades@044299d

Summons followed kind of slow. Adding this allows them to update at the same rate monsters do. Cleaned code in checkPath() Co-Authored-By: gigastar <[email protected]>

github.com

Summon keepDistance, isInRange, distance check. · ralke23/Greed-TFS-1.5-Downgrades@50d9f7b

https: //otland.net/threads/tfs-a-algorithm-d.282100/page-2#post-2704933 Co-Authored-By: gigastar <[email protected]>

github.com

Corrections · ralke23/Greed-TFS-1.5-Downgrades@d105eb0

Co-Authored-By: gigastar <[email protected]>

github.com

 

[Diarreamental]

since you are trying to fix monster behavior can you guys point me out how to fix this pls ? C++ - mosnter ranged attack tfs 1.5 are very off is there a way to fix this? (https://otland.net/threads/mosnter-ranged-attack-tfs-1-5-are-very-off-is-there-a-way-to-fix-this.282764/#post-2708191) @ralke @Itutorial

also when monster are being chased ( monster that run away like hunter, amazon, orc spearman ) when they get reached by a player they stand still and start attacking but they dont run away could be this fixable?
edit:: monster can be easily cornered too

 

[Diarreamental]

Up

 

[Imperator Tibia]

Up

gz

 

[Diarreamental]

gz

?