Tradeoff 2.0 TFS 1.3+

[nanduzenho]

Good afternoon, I have this revscript "auction system" for TFS 1.3, however this error is occurring in the console when I run the command !tradeoff add, 500000. Could anyone help me to solve this problem?



In case someone converts it to normal script, without being revscript so I can do a test. As per my test this script worked perfectly on TFS 1.5 but mine is TFS 1.3

 

[nanduzenho]

up

 

[nanduzenho]

up

 

[Dip Set]

Check your sources for getDuration

forgottenserver/src/item.h at 2f8a2afb3b24a420fe373ad49852f6827c1f5b0d · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[nanduzenho]

Check your sources for getDuration

forgottenserver/src/item.h at 2f8a2afb3b24a420fe373ad49852f6827c1f5b0d · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Yes, apparently it has this function

 

[nanduzenho]

up

 

[Gesior.pl]

Yes, apparently it has this function

No. It does not.

https://github.com/otland/forgottenserver/blob/2f8a2afb3b24a420fe373ad49852f6827c1f5b0d/src/luascript.cpp#L2910

There is only getDuration for ItemType (like item with ID 2400 - from items.xml), not for Item.

You must replace (line 408):

local duration = itemOfertado:getDuration()

with:

local duration = itemOfertado:getAttribute(ITEM_ATTRIBUTE_DURATION)

Replace (line 813):

local duration = itemDoSlot:getDuration()

with:

local duration = itemDoSlot:getAttribute(ITEM_ATTRIBUTE_DURATION)

Replace (line 101):

local duration = itemDentroDoContainer:getDuration()

with:

local duration = itemDentroDoContainer:getAttribute(ITEM_ATTRIBUTE_DURATION)

 

[nanduzenho]

Post automatically merged: Mar 2, 2022

No. It does not.

https://github.com/otland/forgottenserver/blob/2f8a2afb3b24a420fe373ad49852f6827c1f5b0d/src/luascript.cpp#L2910

There is only getDuration for ItemType (like item with ID 2400 - from items.xml), not for Item.

You must replace (line 408):

local duration = itemOfertado:getDuration()

with:

local duration = itemOfertado:getAttribute(ITEM_ATTRIBUTE_DURATION)

Replace (line 813):

local duration = itemDoSlot:getDuration()

with:

local duration = itemDoSlot:getAttribute(ITEM_ATTRIBUTE_DURATION)

Replace (line 101):

local duration = itemDentroDoContainer:getDuration()

with:

local duration = itemDentroDoContainer:getAttribute(ITEM_ATTRIBUTE_DURATION)

Thx bro! Now this error happens

Post automatically merged: Mar 2, 2022

well, I put "removeMoney" and apparently it's working =D

 

[Nottinghster]

Paste this inside lib\core\player.lua

function Player.removeTotalMoney(self, amount)
    local moneyCount = self:getMoney()
    local bankCount = self:getBankBalance()

    if amount <= moneyCount then
        self:removeMoney(amount)
        return true

    elseif amount <= (moneyCount + bankCount) then
        if moneyCount ~= 0 then
            self:removeMoney(moneyCount)
            local remains = amount - moneyCount
            self:setBankBalance(bankCount - remains)
            self:sendTextMessage(MESSAGE_INFO_DESCR, ("Paid %d from inventory and %d gold from bank account. Your account balance is now %d gold."):format(moneyCount, amount - moneyCount, self:getBankBalance()))
            return true
        else
            self:setBankBalance(bankCount - amount)
            self:sendTextMessage(MESSAGE_INFO_DESCR, ("Paid %d gold from bank account. Your account balance is now %d gold."):format(amount, self:getBankBalance()))
            return true
        end
    end
    return false
end

 

[nanduzenho]

Paste this inside lib\core\player.lua

function Player.removeTotalMoney(self, amount)
    local moneyCount = self:getMoney()
    local bankCount = self:getBankBalance()

    if amount <= moneyCount then
        self:removeMoney(amount)
        return true

    elseif amount <= (moneyCount + bankCount) then
        if moneyCount ~= 0 then
            self:removeMoney(moneyCount)
            local remains = amount - moneyCount
            self:setBankBalance(bankCount - remains)
            self:sendTextMessage(MESSAGE_INFO_DESCR, ("Paid %d from inventory and %d gold from bank account. Your account balance is now %d gold."):format(moneyCount, amount - moneyCount, self:getBankBalance()))
            return true
        else
            self:setBankBalance(bankCount - amount)
            self:sendTextMessage(MESSAGE_INFO_DESCR, ("Paid %d gold from bank account. Your account balance is now %d gold."):format(amount, self:getBankBalance()))
            return true
        end
    end
    return false
end

It worked!! Thank u!!!!!!!!

Post automatically merged: Mar 2, 2022

Paste this inside lib\core\player.lua

function Player.removeTotalMoney(self, amount)
    local moneyCount = self:getMoney()
    local bankCount = self:getBankBalance()

    if amount <= moneyCount then
        self:removeMoney(amount)
        return true

    elseif amount <= (moneyCount + bankCount) then
        if moneyCount ~= 0 then
            self:removeMoney(moneyCount)
            local remains = amount - moneyCount
            self:setBankBalance(bankCount - remains)
            self:sendTextMessage(MESSAGE_INFO_DESCR, ("Paid %d from inventory and %d gold from bank account. Your account balance is now %d gold."):format(moneyCount, amount - moneyCount, self:getBankBalance()))
            return true
        else
            self:setBankBalance(bankCount - amount)
            self:sendTextMessage(MESSAGE_INFO_DESCR, ("Paid %d gold from bank account. Your account balance is now %d gold."):format(amount, self:getBankBalance()))
            return true
        end
    end
    return false
end

Now this error occurs when I try to buy

 

[Nottinghster]

It worked!! Thank u!!!!!!!!

Post automatically merged: Mar 2, 2022

Now this error occurs when I try to buy

View attachment 65950

Paste this inside lib\core\player.lua too

function Player.getTotalMoney(self)
    return self:getMoney() + self:getBankBalance()
end

 

[nanduzenho]

Paste this inside lib\core\player.lua too

function Player.getTotalMoney(self)
    return self:getMoney() + self:getBankBalance()
end

Do I need to add something in the source? Because I put this in but I'm not getting paid at the bank

 

[Nottinghster]

Don't forget to use the command /reload all or just restart your server

 

[nanduzenho]

Don't forget to use the command /reload all or just restart your server

no error appears in console, but I do not receive the money...
OH, sorry the payment is with the onLogin function =D

 

[poncex]

does anyone have that php for znote?