Solved tfs 1.0 setAttribute ITEM_ATTRIBUTE_ATK not working

miens · Feb 4, 2017

Hey
I had a spell modifying item attribute in tfs 1.2 and everything worked fine. I had to switch to older version and now when I call the same method (setAttribute) its not changing anything and even returns null. I tried debugging it for hours with no effect. Any ideas what might be wrong here?

Code:

function onCastSpell(creature, variant)
    local player = Player(creature)
    local wpn = player:getSlotItem(CONST_SLOT_LEFT)
    local atk = getAttackValue(wpn)
    if atk >0 then
        local parameters = {weapon = wpn, attack = atk, pl = player}
        --addEvent(UndoStatMod,15000,parameters)
       
        player:setStorageValue(1690, wpn:getUniqueId()+1)
        --print(wpn.uid)
        player:setStorageValue(1691, atk)
        print(wpn:setAttribute(ITEM_ATTRIBUTE_ATTACK, atk+50))
        --print(wpn.uid)
        player:getPosition():sendMagicEffect(CONST_ME_HOLYDAMAGE)
        return true;
    else
        player:sendCancelMessage('You must be holding a weapon.')
        return false
    end
end

Mkalo · Feb 4, 2017

miens said:
Hey
I had a spell modifying item attribute in tfs 1.2 and everything worked fine. I had to switch to older version and now when I call the same method (setAttribute) its not changing anything and even returns null. I tried debugging it for hours with no effect. Any ideas what might be wrong here?

Code:

function onCastSpell(creature, variant) local player = Player(creature) local wpn = player:getSlotItem(CONST_SLOT_LEFT) local atk = getAttackValue(wpn) if atk >0 then local parameters = {weapon = wpn, attack = atk, pl = player} --addEvent(UndoStatMod,15000,parameters) player:setStorageValue(1690, wpn:getUniqueId()+1) --print(wpn.uid) player:setStorageValue(1691, atk) print(wpn:setAttribute(ITEM_ATTRIBUTE_ATTACK, atk+50)) --print(wpn.uid) player:getPosition():sendMagicEffect(CONST_ME_HOLYDAMAGE) return true; else player:sendCancelMessage('You must be holding a weapon.') return false end end

Post getAttackValue function and which "old version" did you switch for?

miens · Feb 4, 2017

ah yes forgot to mention it in post but it is in topic. Im currently using 1.0.

Code:

local function getAttackValue(item)
    if item ~= nil then
        return ItemType(item:getId()):getAttack()
    else
        return 0
    end
end

but I think the error is not in here. i even tried a line like:

Code:

print(Item(player:getSlotItem(CONST_SLOT_LEFT):getUniqueId()):setAttribute(ITEM_ATTRIBUTE_ATK, 50))

and it still returned null and nothing changed.

Mkalo · Feb 4, 2017

miens said:
ah yes forgot to mention it in post but it is in topic. Im currently using 1.0.

Code:

local function getAttackValue(item) if item ~= nil then return ItemType(item:getId()):getAttack() else return 0 end end

but I think the error is not in here. i even tried a line like:

Code:

print(Item(player:getSlotItem(CONST_SLOT_LEFT):getUniqueId()):setAttribute(ITEM_ATTRIBUTE_ATK, atk+50))

and it still returned null and nothing changed.

The reason is there is no ITEM_ATTRIBUTE_ATTACK or ATK in tfs 1.0, your only choice is to use something newer or change the source to add this attribute.

https://github.com/otland/forgottenserver/blob/1.0/src/luascript.cpp#L1500-L1513

miens · Feb 4, 2017

Mkalo said:
The reason is there is no ITEM_ATTRIBUTE_ATTACK or ATK in tfs 1.0, your only choice is to use something newer or change the source to add this attribute.

https://github.com/otland/forgottenserver/blob/1.0/src/luascript.cpp#L1500-L1513

thanks for help case closed

Solved tfs 1.0 setAttribute ITEM_ATTRIBUTE_ATK not working

miens

Combos and Freedom

Mkalo

Mkalo

ボーカロイド

miens

Combos and Freedom

Mkalo

ボーカロイド

miens

Combos and Freedom

Similar threads