• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

C++ TFS 1.0 - v8.6 Taming / Mount System

Murilo35

Murilo35

New Member
Joined
Jun 13, 2012
Messages
17
Reaction score
3
Server 8.6 with TFS 1.0

When I try to tame a creature on my server, this error happens:
Lua Script Error: [Action Interface]
data/actions/scripts/others/mounts/mounts.lua:eek:nUse
data/actions/scripts/others/mounts/mounts.lua:85: attempt to call a nil value (method 'addMount')
stack traceback:
[C]: in method 'addMount'
data/actions/scripts/others/mounts/mounts.lua:85: in function <data/actions/scripts/others/mounts/mounts.lua:62>
Click to expand...
When the creature runs away or when the item breaks and the creature is not tamed there is no error, only when the creature should be tamed.

I've already tried to make some changes into scripts and I've tried to recompile sources, but so far I haven't been able to resolve this error.
I would be very happy if someone could help with this.

data\actions\scripts\others\mounts\mounts.lua
Lua: 
local ACTION_RUN, ACTION_BREAK, ACTION_NONE, ACTION_ALL = 1, 2, 3, 4
local TYPE_MONSTER, TYPE_NPC, TYPE_ITEM, TYPE_ACTION, TYPE_UNIQUE = 1, 2, 3, 4, 5

local config = {
    [5907] = {NAME = 'Bear', ID = 3, TYPE = TYPE_MONSTER, CHANCE = 20, FAIL_MSG = { {1, 'The bear ran away.'}, {2, 'Oh no! The slingshot broke.'}, {3, 'The bear is trying to hit you with its claws.'} }, SUCCESS_MSG = 'You have tamed the war bear.'},
    [13295] = {NAME = 'Black Sheep', ID = 4, TYPE = TYPE_MONSTER, CHANCE = 25, FAIL_MSG = { {1, 'The black sheep ran away.'}, {2, 'Oh no! The reins were torn.'}, {3, 'The black sheep is trying to run away.'} }, SUCCESS_MSG = 'You have tamed the sheep.'},
    [13247]    = {NAME = 'Boar', ID = 10, TYPE = TYPE_MONSTER,    CHANCE = 40, FAIL_MSG = { {1, 'The boar has run away'}, {3, 'The boar attacks you.'} }, SUCCESS_MSG = 'You have tamed the boar.'},
    [13305]    = {NAME = 'Crustacea Gigantica', ID = 7, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, 'The crustacea has run away.'}, {2, 'The crustacea ate the shrimp.'} }, SUCCESS_MSG = 'You have tamed the crustacea.'},
    [13536] = {NAME = 'Crystal Wolf', ID = 16, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, 'The wolf has run away.'} }, SUCCESS_MSG = 'You have tamed the wolf.'},
    [13537]    = {NAME = 'Donkey', ID = 13, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = {    {1, 'The donkey transformation suddenly wears off.'}, {2,  'Heeee-haaa-haaa-haaw!'}, {3, 'You did not manage to feed the donkey enough apple slices.'} }, SUCCESS_MSG = 'Heeee-haaaaw!', 'Munching a large pile of apple slices tamed the donkey.'},
    [18449] = {NAME = 'Dragonling', ID = 31, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, "The dragonling got scared and ran away."}, {2, "The dragonling is trying to nibble."} }, SUCCESS_MSG = "You tamed a dragonling."},
    [13294]    = {NAME = 'Draptor', ID = 6, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, 'The draptor has run away.'}, {3, 'The draptor has fled.'} }, SUCCESS_MSG = 'You have tamed the draptor.'},
    [13535]    = {NAME = 'Dromedary',  ID = 20, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, 'Dromedary has run away.'} }, SUCCESS_MSG = 'You have tamed the dromedary.'},
    [13539]    = {NAME = 'Enraged White Deer', ID = 18, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {2, 'The cone broke.'}, {3, 'The deer has fled in fear.'} }, SUCCESS_MSG = 'You have tamed the white deer.'},
    [32491]    = {NAME = 'Flying Book',  ID = 126, TYPE = TYPE_MONSTER, CHANCE = 20, FAIL_MSG = { {1, 'Flying Book has run away.'} }, SUCCESS_MSG = 'You have tamed the flying book.'},
    [21452] = {NAME = 'Gravedigger', ID = 39, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, "The gravedigger got scared and ran away."}, {3, "The gravedigger is trying to nibble."} }, SUCCESS_MSG = "You tamed the hellgrip."},
    [36411]    = {NAME = 'Gryphon',  ID = 144, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, 'Gryphon has run away.'} }, SUCCESS_MSG = 'You have tamed the gryphon.'},
    [34809]    = {NAME = 'Hibernal Moth', ID = 131,    TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {2, 'The hibernal moth is not interested in your lantern and flies away.'}, {4, 'The hibernal moth is not interested in your lantern and flies away.'} }, SUCCESS_MSG = 'You have tamed a hibernal moth.'},
    [13292]    = {NAME = 'inoperative tin lizzard', ID = 8, TYPE = TYPE_ITEM, CHANCE = 40, FAIL_MSG = { {2, 'The key broke inside.'} }, SUCCESS_MSG = 'You wind up the tin lizzard.'},
    [13938]    = {NAME = 'inoperative uniwheel', ID = 15, TYPE = TYPE_ITEM, CHANCE = 40, FAIL_MSG = { {3, 'The oil have no effect.'}, {2, 'Splosh!'} }, SUCCESS_MSG = 'The strange wheel seems to vibrate and slowly starts turning continuously.'},
    [18447]    = {NAME = 'Ironblight', ID = 29, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, 'The ironblight managed to run away.'}, {2, 'Oh no! The magnet lost its power!'}, {3, 'The ironblight is fighting against the magnetic force.'} }, SUCCESS_MSG = 'You tamed the ironblight.'},
    [34808]    = {NAME = 'Lacewing Moth', ID = 130, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {2, 'The lacewing moth is not interested in your lantern and flies away.'}, {4, 'The lacewing moth is not interested in your lantern and flies away.'} }, SUCCESS_MSG = 'You have tamed a lancewing moth.'},
    [15546]    = {NAME = 'Ladybug', ID = 27, TYPE = TYPE_MONSTER, CHANCE = 30,    FAIL_MSG = { {1, 'The ladybug got scared and ran away.'}, {3, 'The ladybug is trying to nibble.'} }, SUCCESS_MSG = 'You tame a lady bug.'},
    [18448]    = {NAME = 'Magma Crawler', ID = 30,    TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, 'The magma crawler refused to drink wine and vanishes into thin air.'}, {2, 'Argh! The magma crawler pushed you and you spilled the glow wine!'}, {3, 'The magma crawler is smelling the glow wine suspiciously.'} }, SUCCESS_MSG = 'The magma crawler will accompany you as a friend from now on.'},
    [15545]    = {NAME = 'Manta Ray', ID = 28,    TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, 'The manta ray fled.'}, {3, 'The manta ray is trying to escape.'} }, SUCCESS_MSG = 'You have tamed the manta ray.'},
    [13293]    = {NAME = 'Midnight Panther', ID = 5, TYPE = TYPE_MONSTER, CHANCE = 20, FAIL_MSG = { {1, 'The panther has escaped.'}, {2, 'The whip broke.'} },SUCCESS_MSG = 'You have tamed the panther.'},
    [18516]    = {NAME = 'Modified Gnarlhound', ID = 32, TYPE = TYPE_MONSTER, CHANCE = 100, FAIL_MSG = { }, SUCCESS_MSG = 'You now own a modified gnarlhound.'},
    [30840]    = {NAME = 'Mole', ID = 119,    TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {2, 'The Mole is a bit capricious. Maybe I should leave it alone.'}, {4, 'The Mole is a bit capricious. Maybe I should leave it alone.'} }, SUCCESS_MSG = 'You tamed the mole.'},
    [23810]    = {NAME = 'Noble Lion', ID = 40, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {2, 'The lion got scared and ran away.'}, {4, 'The lion is trying to nibble.'} }, SUCCESS_MSG = 'You tamed the lion.'},  
    [13538]    = {NAME = 'Panda', ID = 19,    TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {4, 'Panda the leaves and ran away.'} }, SUCCESS_MSG = 'You have tamed the panda.'},
    [13498]    = {NAME = 'Sandstone Scorpion', ID = 21, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, 'The scorpion has vanished.'}, {2, 'Scorpion broken the sceptre.'} }, SUCCESS_MSG = 'You have tamed the scorpion.'},
    [22608]    = {NAME = 'Shock Head', ID = 42, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, 'The shock head ran away.'}, {3, 'The shock head is growling at you.'} }, SUCCESS_MSG = 'You tamed the shock head.'},
    [27628]    = {NAME = 'Stone Rhino', ID = 106, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, 'The stone rhino ran away.'}, {3, 'The stone rhino is growling at you.'} }, SUCCESS_MSG = 'You tamed the stone rhino.'},
    [13508]    = {NAME = 'Slug', ID = 14,    TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, 'The slug has run away.'}, {3, 'The drug had no effect.'} }, SUCCESS_MSG = 'You have tamed the slug.'},
    [13298]    = {NAME = 'Terror Bird', ID = 2, TYPE = TYPE_MONSTER, CHANCE = 15, FAIL_MSG = { {1, 'The bird ran away.'}, {3, 'The terror bird is pecking you.'} }, SUCCESS_MSG = 'You have tamed the bird.'},
    [13291]    = {NAME = 'Undead Cavebear', ID = 12, TYPE = TYPE_MONSTER, CHANCE = 40, FAIL_MSG = { {1, 'The undead bear has run away.'} }, SUCCESS_MSG = 'You have tamed the skeleton.'},
    [13307]    = {NAME = 'Wailing Widow', ID = 1, TYPE = TYPE_MONSTER,    CHANCE = 40, FAIL_MSG = { {1, 'The widow has run away.'}, {2, 'The widow has eaten the sweet bait.'} }, SUCCESS_MSG = 'You have tamed the widow.'},
    [23557]    = {NAME = 'Walker', ID = 43, TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {2, 'This walker is incompatible with your control unit.'}, {4, 'This walker is incompatible with your control unit.'} }, SUCCESS_MSG = 'You tamed the walker.'},
    [20138]    = {NAME = 'Water Buffalo', ID = 35,    TYPE = TYPE_MONSTER, CHANCE = 30, FAIL_MSG = { {1, 'The water buffalo got scared and ran away.'}, {3, 'The water buffalo is trying to nibble.'} }, SUCCESS_MSG = 'You tamed a water buffalo.'},
    [13939]    = {NAME = 'Wild Horse', ID = 17, TYPE = TYPE_MONSTER, CHANCE = 15, FAIL_MSG = { {1, 'The horse runs away.'}, {2, 'The horse ate the oats.'} }, SUCCESS_MSG = 'You have tamed the horse.'}
   
   
}

local function doFailAction(cid, mount, pos, item, itemEx)
    local action, effect = mount.FAIL_MSG[math.random(#mount.FAIL_MSG)], CONST_ME_POFF
    if(action[1] == ACTION_RUN) then
        Creature(itemEx.uid):remove()
    elseif(action[1] == ACTION_BREAK) then
        effect = CONST_ME_BLOCKHIT
        Item(item.uid):remove(1)
    elseif(action[1] == ACTION_ALL) then
        Creature(itemEx.uid):remove()
        Item(item.uid):remove(1)
    end

    pos:sendMagicEffect(effect)
    Player(cid):say(action[2], TALKTYPE_MONSTER_SAY)
    return action
end

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local player = Player(cid)
    local targetMonster = Monster(itemEx.uid)
    local targetNpc = Npc(itemEx.uid)
    local targetItem = Item(itemEx.uid)
    local mount = config[item.itemid]
    if mount == nil and player:hasMount(mount.ID) then
        return false
    end

    local rand = math.random(100)
    --Monster Mount
    if targetMonster ~= nil and mount.TYPE == TYPE_MONSTER then
        if Creature(itemEx.uid):getMaster() then
            player:say('You can\'t tame a summon!', TALKTYPE_MONSTER_SAY)
            return true
        end

        if mount.NAME == targetMonster:getName() then
            if rand > mount.CHANCE then
                doFailAction(cid, mount, toPosition, item, itemEx)
                return true
            end
            player:addMount(mount.ID)
            player:say(mount.SUCCESS_MSG, TALKTYPE_MONSTER_SAY)
            targetMonster:remove()
            toPosition:sendMagicEffect(CONST_ME_MAGIC_GREEN)
            Item(item.uid):remove(1)
            return true
        end
    --NPC Mount
    elseif targetNpc ~= nil and mount.TYPE == TYPE_NPC then
        if mount.NAME == targetNpc:getName() then
            if rand > mount.CHANCE then
                doFailAction(cid, mount, toPosition, item, itemEx)
                return true
            end
            player:addMount(mount.ID)
            player:say(mount.SUCCESS_MSG, TALKTYPE_MONSTER_SAY)
            toPosition:sendMagicEffect(CONST_ME_MAGIC_GREEN)
            Item(item.uid):remove(1)
            return true
        end
    --Item Mount
    elseif targetItem ~= nil and mount.TYPE == TYPE_ITEM then
        if mount.NAME == targetItem:getName() then
            if rand > mount.CHANCE then
                doFailAction(cid, mount, toPosition, item, itemEx)
                return true
            end
            player:addMount(mount.ID)
            player:say(mount.SUCCESS_MSG, TALKTYPE_MONSTER_SAY)
            toPosition:sendMagicEffect(CONST_ME_MAGIC_GREEN)
            Item(item.uid):remove(1)
            return true
        end
    --Action Mount
    elseif itemEx.actionid > 0 and mount.TYPE == TYPE_ACTION then
        if(mount.NAME == itemEx.actionid) then
            if rand > mount.CHANCE then
                doFailAction(cid, mount, toPosition, item, itemEx)
                return true
            end
            player:addMount(mount.ID)
            player:say(mount.SUCCESS_MSG, TALKTYPE_MONSTER_SAY)
            toPosition:sendMagicEffect(CONST_ME_MAGIC_GREEN)
            Item(item.uid):remove(1)
            return true
        end
    --Unique Mount
    elseif itemEx.uid <= 65535 and mount.TYPE == TYPE_UNIQUE then
        if mount.NAME == itemEx.uid then
            if rand > mount.CHANCE then
                doFailAction(cid, mount, toPosition, item, itemEx)
                return true
            end
            player:addMount(mount.ID)
            player:say(mount.SUCCESS_MSG, TALKTYPE_MONSTER_SAY)
            toPosition:sendMagicEffect(CONST_ME_MAGIC_GREEN)
            Item(item.uid):remove(1)
            return true
        end
    end
    return false
end

Sources

src\mounts.cpp
C++: 
/**
 * The Forgotten Server - a free and open-source MMORPG server emulator
 * Copyright (C) 2014  Mark Samman <[email protected]>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

#include "otpch.h"

#include "mounts.h"

#include "pugicast.h"

bool Mounts::reload()
{
    mounts.clear();
    return loadFromXml();
}

bool Mounts::loadFromXml()
{
    pugi::xml_document doc;
    pugi::xml_parse_result result = doc.load_file("data/XML/mounts.xml");
    if (!result) {
        std::cout << "[Error - Mounts::loadFromXml] Failed to load data/XML/mounts.xml: " << result.description() << std::endl;
        return false;
    }

    for (pugi::xml_node mountNode = doc.child("mounts").first_child(); mountNode; mountNode = mountNode.next_sibling()) {
        mounts.emplace_back(
            static_cast<uint8_t>(pugi::cast<uint16_t>(mountNode.attribute("id").value())),
            pugi::cast<uint16_t>(mountNode.attribute("clientid").value()),
            mountNode.attribute("name").as_string(),
            pugi::cast<int32_t>(mountNode.attribute("speed").value()),
            mountNode.attribute("premium").as_bool()
        );
    }
    return true;
}

Mount* Mounts::getMountByID(uint8_t id)
{
    for (Mount& mount : mounts) {
        if (mount.id == id) {
            return &mount;
        }
    }
    return nullptr;
}

Mount* Mounts::getMountByClientID(uint16_t clientId)
{
    for (Mount& mount : mounts) {
        if (mount.clientId == clientId) {
            return &mount;
        }
    }
    return nullptr;
}

src\mounts.h
C++: 
/**
 * The Forgotten Server - a free and open-source MMORPG server emulator
 * Copyright (C) 2014  Mark Samman <[email protected]>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

#ifndef FS_MOUNTS_H_73716D11906A4C5C9F4A7B68D34C9BA6
#define FS_MOUNTS_H_73716D11906A4C5C9F4A7B68D34C9BA6

struct Mount
{
    Mount(uint8_t id, uint16_t clientId, const std::string& name, int32_t speed, bool premium)
        : name(name), speed(speed), clientId(clientId), id(id), premium(premium) {}

    std::string name;
    int32_t speed;
    uint16_t clientId;
    uint8_t id;
    bool premium;
};

class Mounts
{
    public:
        static Mounts* getInstance() {
            static Mounts instance;
            return &instance;
        }

        bool reload();
        bool loadFromXml();
        Mount* getMountByID(uint8_t id);
        Mount* getMountByClientID(uint16_t clientId);

        const std::list<Mount>& getMounts() const {
            return mounts;
        }

    private:
        std::list<Mount> mounts;
};

#endif
 
Last edited:
Sort by date Sort by votes
Murilo35 said:
SORRY, it was already like this. I left it with (id) because I was doing some tests and forgot to type control + z.
The error continues even with line 85: player:addMount(mount.ID)
Click to expand...
An error appeared in the console on this line, indicating that it either does not exist in your source code or is commented out. You'll need to uncomment certain lines within your source code and integrate additional code to ensure its functionality. I obtained a TFS 1.5 Nekiro 8.6, as requested by a colleague whom I advised to opt for TFS 1.x instead of TFS 0.4. After agreeing, he inquired about the feasibility of implementing a mounting system. I confirmed its possibility and decided to acquire the TFS 1.5 8.6 Nekiro, only to realize it was deficient in almost all aspects. Consequently, I had to procure TFS 1.5 7.7 and extract specific correct code snippets, which were then incorporated into the TFS 1.5 8.6 version. Following compilation, it performed flawlessly.
 
Upvote 0 Downvote
Mateus Robeerto said:
An error appeared in the console on this line, indicating that it either does not exist in your source code or is commented out. You'll need to uncomment certain lines within your source code and integrate additional code to ensure its functionality. I obtained a TFS 1.5 Nekiro 8.6, as requested by a colleague whom I advised to opt for TFS 1.x instead of TFS 0.4. After agreeing, he inquired about the feasibility of implementing a mounting system. I confirmed its possibility and decided to acquire the TFS 1.5 8.6 Nekiro, only to realize it was deficient in almost all aspects. Consequently, I had to procure TFS 1.5 7.7 and extract specific correct code snippets, which were then incorporated into the TFS 1.5 8.6 version. Following compilation, it performed flawlessly.
Click to expand...
Nekiro 1.5 sounds nice, I will try it. Thank you.
 
Upvote 0 Downvote
Lua: 
if mount == nil and player:hasMount(mount.ID) then
    return false
end
^ This part is incorrect, you want to be checking for EITHER using OR, not AND.

This is correct:
Lua: 
if not mount or player:hasMount(mount.ID) then
    return false
end
 
Upvote 0 Downvote

Similar threads

tibera
  • Question
Mounts not working in Sabrehaven Base
Replies
2
Views
419
tibera
tibera
ralke
  • Solved
TFS 1.X+ Attempt to call field 'find'
Replies
3
Views
187
Marko999x
Marko999x
OTcreator
  • Question
Lua [1.4.2] Talkaction with 2 parms and config.
Replies
12
Views
409
OTcreator
OTcreator
Madusa
  • Solved
TFS 1.X+ Converting monsters from xml to tfs 1.2
Replies
2
Views
317
Madusa
Madusa
N
  • Solved
RewardChest delivering items unique="1" to all players
Replies
6
Views
263
nanduzenho
N
J
  • Question
Solved monster not sending blue shimmer effect when they becoes invisible or meanwhike they are invisible
Replies
2
Views
143
johnsamir
J
J
  • Solved
TFS 1.X+ shoot sd/hmm on invisible creature + invisible creatures not sending const_me_magicblue effect
Replies
6
Views
146
johnsamir
J
M
  • Solved
Add outfit on Kill Boss
Replies
2
Views
439
Maarkiin
M
A
  • Question
Item chance unique="1" drop double Reward Chest
Replies
1
Views
331
Azerty
A
OTcreator
  • Question
Lua Auto Raids on [TFS 1.4.2] - Nekiro system.
Replies
8
Views
382
OTcreator
OTcreator
Back
Top