• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Call to community at TFS GitHub

E

Evil Puncker

Guest
Lately we have had quite a lot of Pull Requests in our main github repository, but we lack people to test and review them... So I'm here to ask the community help (those who are whiling to, ofc) to actually TEST the code and provide feedback, and my call for developers is for them to update their branch conflicts, that's all.

lets make TFS even better, together!
 
Good call.

Hopefully we will be able to say TFS is 100% 10.98 compatible soon and MAYBE we can start moving forward.

It's about time already.
 
Have you been chatting to someone about this recently? or is this your own idea?
Might be a coincidence, but I started a discussion with the admins about this recently too.
 
Last edited:
Reminds me of this 😂
432adb47-739c-42e8-a1d1-962ebfffb876.gif
 

Attachments

Last edited:
Lately we have had quite a lot of Pull Requests in our main github repository, but we lack people to test and review them... So I'm here to ask the community help (those who are whiling to, ofc) to actually TEST the code and provide feedback, and my call for developers is for them to update their branch conflicts, that's all.

lets make TFS even better, together!
I have an even better idea – what about actually testing your own revisions instead of making bugged pull requests and hoping someone else will correct your mistakes?

If you see something that needs to be changed, but don't know how to do it properly, it's better to open an issue ticket.
 
I have an even better idea – what about actually testing your own revisions instead of making bugged pull requests and hoping someone else will correct your mistakes?

If you see something that needs to be changed, but don't know how to do it properly, it's better to open an issue ticket.

I'm pretty sure he tests his code, but if you only rely on your own testing something is going to fail sooner or later.

It's best practice to have your code tested by someone else (of course after testing it yourself)
 
I'm pretty sure he tests his code, but if you only rely on your own testing something is going to fail sooner or later.

It's best practice to have your code tested by someone else (of course after testing it yourself)
I agree that not only one person should test code, but I've seen a few of his PRs and I highly doubt that he had tested them at all. Some of the errors were so obvious it was enough to just quickly read through the changes to spot them.
 
I agree that not only one person should test code, but I've seen a few of his PRs and I highly doubt that he had tested them at all. Some of the errors were so obvious it was enough to just quickly read through the changes to spot them.
Someone is trying to contribute and you mad because of some typo errors.

4
 
I know what you talking about, evil pucker is someone who some months ago didn't even know how to correctly setup envs and now he is doing PR's by himself just because he wants to help everyone (even ppl like you) so feel free to give any feedback to his PRs, but this kind of stuff its not needed.
I have an even better idea – what about actually testing your own revisions instead of making bugged pull requests and hoping someone else will correct your mistakes?
 
Have you been chatting to someone about this recently? or is this your own idea?
Might be a coincidence, but I started a discussion with the admins about this recently too.
own idea, but i'm glad you are on it as well

@Wirox
I see that you are still mad at monster defense values 😁 😁 don't take it to the heart bro, if you don't like something, just suggest a better approach

my goal with my PRs is to make TFS default items/monsters/whatever working as smooth as possible, without the need to only relay on others datapacks content, people will be able to download TFS and start working on their custom server content without the need to worry if basic stuff is working or not, I don't know why so much hate from some people... but it wont stop me 😘
 
I think a test branch would be a really good step towards getting actual testing done on PR's in an easy way.
A branch with:
  • An account with all vocations
  • House owner
  • House full of organised containers / corpses
  • Containers of each moveable item (eventually, start amall with just equipment or something)
  • Structure intuitively - like all decaying items in the one container etc.
Something I was planning to do for my own project.
Could just be a simple custom .sql and .otbm


@👇
my goal with my PRs is to make TFS default items/monsters/whatever working as smooth as possible, without the need to only relay on others datapacks content, people will be able to download TFS and start working on their custom server content without the need to worry if basic stuff is working or not
Yet some of your PRs actually break basic stuff.

Can you quit it with the toxicity.
Discouraging others from contributing is small brain shit.
 
Last edited:
my goal with my PRs is to make TFS default items/monsters/whatever working as smooth as possible, without the need to only relay on others datapacks content, people will be able to download TFS and start working on their custom server content without the need to worry if basic stuff is working or not
Yet some of your PRs actually break basic stuff.
 
If the people that mattered were concerned about the quality of his code or the usefulness of his contributions they'd say so in a respectful way.
Instead after a very quick review myself, I found this:
1583930813029.png

EPuncker: 4 merges, 5 reviews
Wirox: 1 merge, 1 opinion that changes are pointless unless they are perfect in every way


(I don't know or care what else you may or may not have done or how skilled you are - your behaviour in this thread is clearly unwelcome)
 
Can you quit it with the toxicity.
Discouraging others from contributing is small brain shit.
I only want to discourage others from "contributing" in a way that's more harmful than useful. There's a reason why TFS has so many bugs and encouraging people to make low quality, untested PRs will only make the matter worse.
 
There's a reason why TFS has so many bugs

TFS is the most stable and bug free repo that exists publicly.

It's actually stuck at 10.98 and being overtaken by the otservbr fork (the one with actual lax standards) on features - because of how strict standards on PRs actually are (and because the current dev team is inactive or awol).

So you're dead wrong mate.
Go straight to jail, do not pass go, do not collect $200.
 
I have an even better idea – what about actually testing your own revisions instead of making bugged pull requests and hoping someone else will correct your mistakes?

If you see something that needs to be changed, but don't know how to do it properly, it's better to open an issue ticket.

A bugged pull request is a pull request that will not be merged. This is after all why pull requests exist, to prevent any problematic code from being merged.

In response to the part I've bolded on the quote:
Why do you think there are people responsible for reviewing pull requests and merging them only if they pass certain criteria? Why don't YOU review code and help with the entire process if you care so much?
 
A bugged pull request is a pull request that will not be merged.
That's unfortunately very far from truth. There have been lots of bugged PRs that were getting merged.

Why do you think there are people responsible for reviewing pull requests and merging them only if they pass certain criteria? Why don't YOU review code and help with the entire process if you care so much?
Even if we assume that people who test and review code always spot any errors (but I hope you understand it definitely isn't realistic, especially in case of TFS which doesn't have a professional team), it all costs them time. If there are many low quality, untested PRs, lots of time will be spent on analyzing and rejecting them. There must be certain standards of proposing a pull request. It should be the contributor's responsibility to make sure they know what they are doing, explain why they are doing the exact changes, and thoroughly test everything. Sadly there are many contributors who don't follow these standards.
 
That's unfortunately very far from truth. There have been lots of bugged PRs that were getting merged.


Even if we assume that people who test and review code always spot any errors (but I hope you understand it definitely isn't realistic, especially in case of TFS which doesn't have a professional team), it all costs them time. If there are many low quality, untested PRs, lots of time will be spent on analyzing and rejecting them. There must be certain standards of proposing a pull request. It should be the contributor's responsibility to make sure they know what they are doing, explain why they are doing the exact changes, and thoroughly test everything. Sadly there are many contributors who don't follow these standards.

Total file changes this past month:

You're sour at this? or you're sour at this?
Attacking someone for contributing, especially monsters (a big one that's been out of date for years)?

dude? chill.
 
Last edited:
Back
Top