Call to community at TFS GitHub

[Wirox]

Attacking someone for contributing, especially monsters (a big one that's been out of date for years)?

Who said I'm only referring to specifically these two PRs? Who said I'm only referring to PRs made this month?
But yeah, the monster changes you've linked are a good example of the issue. Puncker decided to change the poison values, for God knows what reason, to way lower values, without any explanation to this decision whatsoever, and clearly without testing it either. They were only corrected back because I reported them. Defense values were and still are incorrect. Who knows what other mistakes might be there?

Anyway, if you don't see anything wrong with such untested PRs, then fine, I don't think I'll change your mind. I just find it funny that Puncker is the one who made a call to the community to test things, considering he's the one who doesn't test his PRs and doesn't know what he's doing for the most part.

 

[Wirox]

A bugged pull request is a pull request that will not be merged.

Updated 7.x monsters [part 2] by EPuncker · Pull Request #2782 · otland/forgottenserver

Updated a few missed monsters that the implementation date was unknown Created two new classes: bats and vampires and moved the files accordingly

github.com

Yeah, sure.

 

[Delirium]

Updated 7.x monsters [part 2] by EPuncker · Pull Request #2782 · otland/forgottenserver

Updated a few missed monsters that the implementation date was unknown Created two new classes: bats and vampires and moved the files accordingly

github.com

Yeah, sure.

Oh okay. The standard of the open source community is the TFS repository then?

I have nothing against the TFS repository and it's common to make such mistakes in a comparatively small project like TFS. Show me one pull request that contains bad code but has been merged and made its way to the master branch in, let's say, the .NET runtime source code?

 

[Evil Puncker]

Oh okay. The standard of the open source community is the TFS repository then?

I have nothing against the TFS repository and it's common to make such mistakes in a comparatively small project like TFS. Show me one pull request that contains bad code but has been merged and made its way to the master branch in, let's say, the .NET runtime source code?

dude the PR was open for review for a month and he just waited for it to get merged only to flame instead of pointing it to get fixed

btw: Monster loot fixes by EPuncker · Pull Request #2860 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/2860)

 

[Wirox]

Oh okay. The standard of the open source community is the TFS repository then?

I have nothing against the TFS repository and it's common to make such mistakes in a comparatively small project like TFS. Show me one pull request that contains bad code but has been merged and made its way to the master branch in, let's say, the .NET runtime source code?

I was talking about the low standards of accepting PRs in the TFS repository and how it results in bugged code. How do other repositories, like .NET runtime, have anything to do with it?

I am all for open source projects. But everyone being able to contribute poses some risks which have to be minimized for it to make any sense. If someone submits a pull request, it should be their duty to prove they know what they are doing, to explain all of their changes, and to test everything. If a pull request gets merged simply because it has been up for a month, and not because someone actually thoroughly checked and tested it, it'll certainly lead to bugged code.

You are probably unaware of how bugged TFS is, simply because no one has reported it yet. Just like you'd be unaware of the bugs in Puncker's PR if I didn't point them out. Some of them he fixed, some of them he didn't. And I am sure there are more bugs in his PR – a quick glance over the changes definitely didn't spot all of them. This way of accepting PRs must stop or else TFS will forever be unstable.

 

[Mr. Greyshade]

The TFS github is just a general mess now after all decent developers have left. Remove spaces and unified (- _) in monster file names by WibbenZ · Pull Request #2858 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/2858/files) - every folder has always been made with _ why are we suddenly changing it to use -? Having it use _ as the files makes much more sense.
Things are getting merged without any real tests or quality control, just looking at recent changes tons of monsters contain over 100 countmax in their loot now, which doesn't even work, and just looking at the recent merges majority of them are small things trying to mimic real tibia - and some of the things aren't even done properly.

Not to mention most of these changes aren't important at all (like trying to mimic real tibia monsters) and just take time away from testing some of the more important stuff, and fills up the git with garbage.

 

[Leo32]

I was talking about the low standards of accepting PRs in the TFS repository and how it results in bugged code. How do other repositories, like .NET runtime, have anything to do with it?

I am all for open source projects. But everyone being able to contribute poses some risks which have to be minimized for it to make any sense. If someone submits a pull request, it should be their duty to prove they know what they are doing, to explain all of their changes, and to test everything. If a pull request gets merged simply because it has been up for a month, and not because someone actually thoroughly checked and tested it, it'll certainly lead to bugged code.

You are probably unaware of how bugged TFS is, simply because no one has reported it yet. Just like you'd be unaware of the bugs in Puncker's PR if I didn't point them out. Some of them he fixed, some of them he didn't. And I am sure there are more bugs in his PR – a quick glance over the changes definitely didn't spot all of them. This way of accepting PRs must stop or else TFS will forever be unstable.

You're talking to one of the last active people willing to go through old data like that and try and clean it up.
Are you doing anything? or is negging people all you do?

The TFS devs of old have moved on, this is what happens - people need to pick up the pieces.
If you're unhappy with those trying to pick up those pieces, do something about it, contribute on git as per the point of this thread.

If you're hosting a server and bugs are breaking things for your users - then why are running bleeding edge commits in production???

You are probably unaware of how bugged TFS is, simply because no one has reported it yet.

There is a massive list of issue reports on the repo, the issue is the lack of people looking through them, confirming them and fixing them.
We need more people not tighter restrictions, you have this whole issue backwards dude

Not to mention most of these changes aren't important at all (like trying to mimic real tibia monsters) and just take time away from testing some of the more important stuff

There is no collective more important stuff.
Don, Wibben, Nekiro, EPhucker, EvilHero and Znote are the last few people left actively contributing stuff at the moment.

People work on whatever they want and whatever is up-to their ability.

over 100 countmax in their loot now, which doesn't even work

EPhucker is the one brave enough to go through and fix up monsters, there's hundreds of them and they've been stale for ages.
But he's doing it, no one else is which is the point of this thread - if there's issues it gets fixed, that's what progress is.

If you want the code-base to be perfect, then download 1.2 the latest release like you would with any other software.
Bleeding edge commits are not going to be perfectly bug free, you're crazy if you think that.

 

[Beo]

The TFS github is just a general mess now after all decent developers have left. Remove spaces and unified (- _) in monster file names by WibbenZ · Pull Request #2858 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/2858/files) - every folder has always been made with _ why are we suddenly changing it to use -? Having it use _ as the files makes much more sense.
Things are getting merged without any real tests or quality control, just looking at recent changes tons of monsters contain over 100 countmax in their loot now, which doesn't even work, and just looking at the recent merges majority of them are small things trying to mimic real tibia - and some of the things aren't even done properly.

Not to mention most of these changes aren't important at all (like trying to mimic real tibia monsters) and just take time away from testing some of the more important stuff, and fills up the git with garbage.

Although I agree with some of this, only a small amount of people are actively contributing "stuff" at all to TFS, let alone "important stuff". If that is all they can contribute, why should you be mad about it? What was the last thing you contributed?

I mean, this is just my outside opinion, I don't contribute AT ALL, so why would I complain about what is being contributed? If I wanted to make it better, I'd find the time to contribute myself to help the community, rather than pissing on people who are contributing, no matter how small.

 

[WibbenZ]

The TFS github is just a general mess now after all decent developers have left. Remove spaces and unified (- _) in monster file names by WibbenZ · Pull Request #2858 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/2858/files) - every folder has always been made with _ why are we suddenly changing it to use -? Having it use _ as the files makes much more sense.
Things are getting merged without any real tests or quality control, just looking at recent changes tons of monsters contain over 100 countmax in their loot now, which doesn't even work, and just looking at the recent merges majority of them are small things trying to mimic real tibia - and some of the things aren't even done properly.

Not to mention most of these changes aren't important at all (like trying to mimic real tibia monsters) and just take time away from testing some of the more important stuff, and fills up the git with garbage.

Feel free to create a PR if you think something is wrong or you think it can be done better.
And no it has always been a mix, but mainly -
1.0: otland/forgottenserver (https://github.com/otland/forgottenserver/tree/2dbaa28581af5c68f25a9277a07bf21e184c0fbc/data/monster)
0.4: otland/tfs-old-svn (https://github.com/otland/tfs-old-svn/tree/fef65e1f7d8e330065749a31a298678ac6e61a87/data/monster)
0.3: otland/tfs-old-svn (https://github.com/otland/tfs-old-svn/tree/0945f3f867982bbd72c30343e8131d7529d37163/data/monster)
0.2(didn't use any folders): otland/tfs-old-svn (https://github.com/otland/tfs-old-svn/tree/ebbfe06d9ac9dce38f5caac5d3950f530d614b61/data/monster)

Once again if you think something can be done better you can help review PRs or create your own PR with a better code, thats the great thing about using github.

You are probably unaware of how bugged TFS is, simply because no one has reported it yet.

Since you have the insight to that maybe you should report them?
Or is there a better distro out there that is open source?

 

[TheRatazana]

Just read Wirox posts without thinking he's a hater. I don't agree with how this started but I surely agree with what he says about the quality. Consistency is very important, you cannot change just because you want, without a good reason and without explaining what motivates those changes you made.

Someone is trying to contribute and this is very good, but lets not be naive and just accept anything without a good review and tests. Even the best code written by the best coders that haved passed in the TFS history doesn't have a test case which already puts us in a very bad situation.

This "You don't help, so who're you to say anything?" is just very boring and not a smart thing. I'm sure Wirox is a skilled guy who probably works with TFS on a daily basis as many other very talented guys here and that know a lot of it, and if he points out he's worries about how things are being managed why this is treated like a bad thing? You keep doing what is not good just because someone pointed it out but don't wanna to contribute actively in the repository? How about feedback and advises?

So for me, Evil Puncker is doing well when putting effort and time in adding and updating things on TFS repository and for calling for testers. But Wirox is also very right about concerns with quality and how someone that creates a PR should be the one doing its best to justify his changes and why they should be merged, while ensuring the best test of code in its capacity.

Just one last thing: I don't think TFS needs more people, but reasonable restrictions. Not only that, it needs a leadership capable of applying those restrictions while helping people to grow in knowledge. As I stated before this community has very talented people who work in things they cannot just throw at the repository due to how they diverge from Tibia. But those guys are learning every day and certainly knows one or two things that could help, and under a good plan and with a good Project Leader those talents can be put together to advance so much TFS.

But this is a history for another day. I feel would be cool for the community to involve more in discussions about TFS and its future, with good arguments and without provocations if possible(not sure if it's possible).

 

[Wirox]

I agree that my posts have probably been too harsh and that I could've said it differently. But contrary to what some people here think, my goal isn't to harass any specific user. My only goal is to address a problem with how the TFS community operates, and hopefully change it for the better. Even if there isn't any better open-source distro it definitely doesn't mean that TFS's situation is good. If anything, it shows a bad state of Open Tibia in general.

 

[Ahilphino]

to filter out all these useless things that have been added last months u can add
"-author:EPuncker" to the filter of tickets, then u dont see all these changes that is trying to mimic real tibia. and instead u see the more important things that devs care about. maybe these tickets also should have some label to them to make it easier to filter.
right now i think this github looks like otservbr github, maybe even worse lol

 

[Evil Puncker]

to filter out all these useless things that have been added last months u can add
"-author:EPuncker" to the filter of tickets, then u dont see all these changes that is trying to mimic real tibia. and instead u see the more important things that devs care about. maybe these tickets also should have some label to them to make it easier to filter.
right now i think this github looks like otservbr github, maybe even worse lol

nice bump and thanks for teaching people how to use github as if they didn't knew how to do so

(and again: I'm not trying to mimic real tibia, but rather giving functionality to items, if you don't like don't use, bye. I won't stop)

 

[Morrison]

Dont stop @Evil Puncker, thanks for yours improvements. you are one of the top commiters! thanks!

 

[Sarah Wesker]

I believe that everything happens in due course

 

[Ahilphino]

View attachment 44724
nice bump and thanks for teaching people how to use github as if they didn't knew how to do so

(and again: I'm not trying to mimic real tibia, but rather giving functionality to items, if you don't like don't use, bye. I won't stop)

no need to get angry man. its just sad seeing how much shit there is there now, i was just browsing it some secs ago for some other things and saw really funny thing

Removed Purse item by EPuncker · Pull Request #2956 · otland/forgottenserver

It was removed on 10.8 update and it's now a blank item https://tibia.fandom.com/wiki/Purse

github.com

nice new functionality, thanks for your amazing contributions

 

[zxmatzx]

to filter out all these useless things that have been added last months u can add
"-author:EPuncker" to the filter of tickets, then u dont see all these changes that is trying to mimic real tibia. and instead u see the more important things that devs care about. maybe these tickets also should have some label to them to make it easier to filter.
right now i think this github looks like otservbr github, maybe even worse lol

I blame the fucking digital inclusion for read this shit, you also know a command to we don't see your posts here in otland?

@Evil Puncker really thanks for your contribution, what you are doing is harder than improvements in any code! Keep going!!

 

[Ahilphino]

I blame the fucking digital inclusion for read this shit, you also know a command to we don't see your posts here in otland?

yes there is a ignore function in forum

 

[Evil Puncker]

nice new functionality, thanks for your amazing contributions

what is wrong with removing an item that was deleted from client? lmao

 

[Lessaire]

nice new functionality, thanks for your amazing contributions

Maybe you've never been on the inside looking out so let me reveal a little secret:


For the ones who can actually do the hard code, every commit like this they do not have to do leaves more time for the shit that matters. And that concept is one of the reasons large projects can use coders of all skill levels. Even incredibly important projects like The Kernel. You'll find that most engineers do not appreciate their helpers being mocked. Put up or shut up.