Fix/Patch Distance Attack/Potion Use - Fix for TFS 1.x

[Ascuas Funkeln]

Hello, this is my fix of this problem, its not super pro, but should be fine for use.
When i test this problem i noticed that in TFS "ranged weapons" when attack are used like an "action".

Before source edit, check if config.lua edit is enough (by Lessaire)

Change this:

Spoiler: configmanager.cpp

    integer[ACTIONS_DELAY_INTERVAL] = getGlobalNumber(L, "timeBetweenActions", 200);
    integer[EX_ACTIONS_DELAY_INTERVAL] = getGlobalNumber(L, "timeBetweenExActions", 1000);

To this:
Change this:

Spoiler: configmanager.cpp

    integer[ACTIONS_DELAY_INTERVAL] = getGlobalNumber(L, "timeBetweenActions", 0);
    integer[EX_ACTIONS_DELAY_INTERVAL] = getGlobalNumber(L, "timeBetweenExActions", 0);

And compile

Then in config.lua set this values

-- Item Usage
timeBetweenActions = 0
timeBetweenExActions = 0

Then setup potions and all items thats you wanna to have cooldown like this example

In "player:setStorageValue(55555, os.time() + 3)", number "+ 3" define cooldown in seconds.

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if player:getStorageValue(55555) >= os.time() then
    player:sendTextMessage(MESSAGE_STATUS_SMALL, "You are exhausted")
        return true
    end
local PotionValue = 500
    if target:isPlayer() then
    player:setStorageValue(55555, os.time() + 3)
        item:remove(1)
target:addHealth(PotionValue)
  target:getPosition():sendMagicEffect(CONST_ME_MAGIC_RED)
            return false
        end
end

Now distance attack and using potions or items should work fine.

OFC, make different storages for each item!

 

[Lessaire]

There is probably no reason to make this CPP source change, the parameter provided to function is the defaultor. It's only used if the config.lua entry in question does not exist. So just the config.lua change should do what you want.

int32_t getGlobalNumber(lua_State* L, const char* identifier, const int32_t defaultValue = 0)
{
    lua_getglobal(L, identifier);
    if (!lua_isnumber(L, -1)) {
        lua_pop(L, 1);
        return defaultValue;
    }

    int32_t val = lua_tonumber(L, -1);
    lua_pop(L, 1);
    return val;
}

 

[Ascuas Funkeln]

There is probably no reason to make this CPP source change, the parameter provided to function is the defaultor. It's only used if the config.lua entry in question does not exist. So just the config.lua change should do what you want.

int32_t getGlobalNumber(lua_State* L, const char* identifier, const int32_t defaultValue = 0)
{
    lua_getglobal(L, identifier);
    if (!lua_isnumber(L, -1)) {
        lua_pop(L, 1);
        return defaultValue;
    }

    int32_t val = lua_tonumber(L, -1);
    lua_pop(L, 1);
    return val;
}

Maybe i have something messy, but if i dont do that in cpp, then in config.lua "0" will return in game something like "100"
Anyway ofc good point, first check in config.lua edits is enough.

 

[Lessaire]

Friend, just comment out the line! Or set to nil.

Zero and nil are not equal. And they are not treated the same.

-- Item Usage
--timeBetweenActions = 0
--timeBetweenExActions = 0

-- Item Usage
timeBetweenActions = nil
timeBetweenExActions = nil

 

[Ascuas Funkeln]

Friend, just comment out the line! Or set to nil.

Zero and nil are not equal. And they are not treated the same.

-- Item Usage
--timeBetweenActions = 0
--timeBetweenExActions = 0

-- Item Usage
timeBetweenActions = nil
timeBetweenExActions = nil

I dont have it like comment xD
Anyway nil work fine, thanks.

 

[nugo]

what about this? This is a fix for the same issue it appears.

[TFS 1.2] Paladins with attack delay when use potions

Hi my friends, I'm facing a problem weird on TFS 1.2, paladins can't attack when they are using potions, but with spells it works. Someone have any ideia to how fix this problem? Also, I already tryed add swing on weapons.xml but I don't think TFS 1.2 supports swing, weapons.cpp. Thanks.

otland.net

forgottenserver/src/actions.cpp at 4fa8f3a225d70304991555d560c56f8bd246e209 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[Lessaire]

Sure, I can look into that, but it would be back in your support thread where I can get my virtual clout points.