Dual wield?

[Thylonn]

Im trying to set up a Dual wield vocation, being able to hold 2 axes or 2 swords without a shield.
If i do that will the character get damage for both the weapons? or will it just take 1 of the 2 items atk damage?

I am not very familiar with this, so please don't judge me

 

[AnarchGov]

I'm judging you.

No jk, i honestly can't help you. But i was looking to do something similar some time ago so i figured i would bump the post

 

[Programmer]

Would require source edits.. tons.. along with interfering with combat and attack speed/attack, if it was a wand or a rod it might mess up.. Just tons of things wrong with that.

 

[Thylonn]

Would require source edits.. tons.. along with interfering with combat and attack speed/attack, if it was a wand or a rod it might mess up.. Just tons of things wrong with that.

Oh, i see. Well thank you and ill work my way arround it

 

[Dantarrix]

Not need of source edit... There is an items.xml attribute called "dualwield"... If you give that attribute to a weapon, ALL players can wear it in both hand at the same time and it attacks at x2 speed....

But you should do script to prevent all players and let some vocations...

 

[JuggaloUser]

dualwield attribute available in what versions?

 

[Dantarrix]

Mmm...

In OTX in all versions...
In TFS I can see it on trunk.r3777 in advance, dont know if its on older versions, but in 0.3.6 it isnt compiled...
In other distributions I dont know...

 

[mujica]

If i were you i would choose a bunch of weapons that you want as "off-hand" weapons and have it look like a weapon but its acutally a shield and make it add skills to its skill tree like a Sword and the off hand weap a dagger but the dagger adds 15+swording. Or something along those lines.

 

[DemShion]

bump, is it posible tomcompile the function into 0.3.6? it would be awsome to actually make it dual weild weps and not only wear a shield whit a diefrent sprite , altho is rlly good temporary solution n.n gj

 

[margoh]

I think you should use normal dual wield, there is some tutorial how to do on tfs 0.3.6pl1, and then add atributes to weapon for x vocation.

 

[DemShion]

can't get my hand on that tutorial, would be awsome if someone could post a link or something u.u (i am useless).

 

[margoh]

Items.cpp​

Under:

armor = 0;

Add:

dual = 0;

Under:

else if(tmpStrValue == "attack")
{
	if(readXMLInteger(itemAttributesNode, "value", intValue))
		it.attack = intValue;
}

Add:

else if(tmpStrValue == "dual")
{
	if(readXMLInteger(itemAttributesNode, "value", intValue))
		it.dual = intValue;
}

Items.h​

Change this:

int32_t attack, extraAttack, defense, extraDefense, armor, breakChance, hitChance, maxHitChance,
runeLevel, runeMagLevel, lightLevel, lightColor, decayTo, rotateTo, alwaysOnTopOrder;

Whith this:

int32_t attack, extraAttack, defense, extraDefense, armor, breakChance, hitChance, maxHitChance,
runeLevel, runeMagLevel, lightLevel, lightColor, decayTo, rotateTo, alwaysOnTopOrder, dual;

Item.cpp​

Under:

if(it.defense || it.extraDefense || (item && (item->getDefense() || item->getExtraDefense())))
{
	if(begin)
	{
		begin = false;
		s << " (";
	}
	else
		s << ", ";

	s << "Def:" << int32_t(item ? item->getDefense() : it.defense);
	if(it.extraDefense || (item && item->getExtraDefense()))
		s << " " << std::showpos << int32_t(item ? item->getExtraDefense() : it.extraDefense) << std::noshowpos;
}

Add:

if(it.dual || (item && item->isDual()))
{
	if(begin)
	{
		begin = false;
		s << " (";
	}
	else
		s << ", ";

	s << "dual-wield";
}

Under:

case ATTR_ATTACK:
{
	int32_t attack;
	if(!propStream.GET_ULONG((uint32_t&)attack))
		return ATTR_READ_ERROR;

	setAttribute("attack", attack);
	break;
}

Add:

case ATTR_DUAL:
{
	int32_t dual;
	if(!propStream.GET_ULONG((uint32_t&)dual))
		return ATTR_READ_ERROR;

	setAttribute("dual", dual);
	break;
}

Item.h​

Under:

ATTR_SCRIPTPROTECTED = 42,

Add:

ATTR_DUAL = 43,

Under:

int32_t getAttack() const;

Add:

int32_t isDual() const;

Under:

inline int32_t Item::getAttack() const
{
	const int32_t* v = getIntegerAttribute("attack");
	if(v)
		return *v;

	return items[id].attack;
}

Add:

inline int32_t Item::isDual() const
{
	const int32_t* v = getIntegerAttribute("dual");
	if(v)
		return *v;

	return items[id].dual;
}

Player.cpp​

Under:

WeaponType_t Player::getWeaponType()
{
	if(Item* item = getWeapon())
		return item->getWeaponType();

	return WEAPON_NONE;
}

Add:

Item* Player::getLeftWeapon()
{
      Item* item = getEquippedItem(SLOT_LEFT);

      if(const Weapon* weapon = g_weapons->getWeapon(item))
		   return item;
}

Item* Player::getRightWeapon()
{
      Item* item = getEquippedItem(SLOT_RIGHT);

      if(const Weapon* weapon = g_weapons->getWeapon(item))
           return item;
}

bool Player::isUsingDual()
{
     Item* right = getRightWeapon();
     Item* left = getLeftWeapon();

     if(left && right && left->isDual() && right->isDual())
         return true;

     return false;
}

In function __queryAdd find:

else if(leftType == WEAPON_SHIELD && type == WEAPON_SHIELD)
ret = RET_CANONLYUSEONESHIELD;

And add:

else if(leftType < WEAPON_SHIELD && type < WEAPON_SHIELD && item->isDual() && leftItem->isDual())
ret = RET_NOERROR;

Then find:

else if(rightType == WEAPON_SHIELD && type == WEAPON_SHIELD)
ret = RET_CANONLYUSEONESHIELD;

And add:

else if(rightType < WEAPON_SHIELD && type < WEAPON_SHIELD && item->isDual() && rightItem->isDual())
ret = RET_NOERROR;

In function doAttacking find:

if(hasCondition(CONDITION_PACIFIED) && !hasCustomFlag(PlayerCustomFlag_IgnorePacification))
{
lastAttack = OTSYS_TIME();
return;
}

And add below:

    if(isUsingDual())
	{
        const Weapon* rweapon = g_weapons->getWeapon(getRightWeapon());
        const Weapon* lweapon = g_weapons->getWeapon(getLeftWeapon());

        if(rweapon->interruptSwing() && lweapon->interruptSwing() && !canDoAction())
		{
			SchedulerTask* task = createSchedulerTask(getNextActionTime(), boost::bind(&Game::checkCreatureAttack, &g_game, getID()));
			setNextActionTask(task);
		}
		else if(((!rweapon->hasExhaustion() && !lweapon->hasExhaustion()) || !hasCondition(CONDITION_EXHAUST, EXHAUST_COMBAT)) && (rweapon->useWeapon(this, getRightWeapon(), attackedCreature) && lweapon->useWeapon(this, getLeftWeapon(), attackedCreature)))
			lastAttack = OTSYS_TIME();
    }

And change this:

Item* tool = getWeapon();
if(const Weapon* weapon = g_weapons->getWeapon(tool))

With this:

else if(const Weapon* weapon = g_weapons->getWeapon(getWeapon()))

And change this:

else if((!weapon->hasExhaustion() || !hasCondition(CONDITION_EXHAUST, EXHAUST_COMBAT)) && weapon->useWeapon(this, tool, attackedCreature))

With this:

else if((!weapon->hasExhaustion() || !hasCondition(CONDITION_EXHAUST, EXHAUST_COMBAT)) && weapon->useWeapon(this, getWeapon(), attackedCreature))

Player.h​

Under:

virtual WeaponType_t getWeaponType();

Add:

Item* getLeftWeapon();
Item* getRightWeapon();
bool isUsingDual();

It's all. Tutorial isn't mine, so all reps and thanks to Dantez (TNP).​

 

[DemShion]

WOOOOOOOOOW HUGE!!!! tyvm man! roxx

 

[WiLDTuRTLE]

so what line do i add to the swords in item,xml? i dont want every wep to be used like that?

 

[margoh]

Oh i forget about that xD
You have to add:

		<attribute key="dual" value="1" />

And that is all

 

[leonmagmo]

I can't find theses code(the others i found) i'm using 0.3.6pl1.r101

armor = 0;

else if(tmpStrValue == "attack")
{
	if(readXMLInteger(itemAttributesNode, "value", intValue))
		it.attack = intValue;
}

What i can do?

 

[Codinablack]

try not searching for the whole thing, try the start or just try searching for =="attack" and see if what you find, then put it in the right place...