TFS 1.X+ Issue on latest OTClient (mehah)

[ralke]

Hi there! I've been away for quite long time. Recently compiled the current otclient mehah but it doesn't seem to work with my server anymore. So I troubleshoot it to the latest working version, by downloading the avaible releases and noticed that the 4.0 + hotfix(1) doesn't work and 4.0 Beta 4 (UI Improve) does work, meaning it must be a recent commit that made it stop working.

The error logs when using the 4.0 hotfix(1) are:

Spoiler: Logs here

ProtocolGame parse message exception (642 bytes, 423 unread, last opcode is 0xAA (170), prev opcode is 0xA0 (160), proto: 860): InputMessage eof reached
ProtocolGame parse message exception (751 bytes, 559 unread, last opcode is 0xAA (170), prev opcode is 0x8C (140), proto: 860): InputMessage eof reached
ProtocolGame parse message exception (2341 bytes, 2229 unread, last opcode is 0x64 (100), prev opcode is 0x0A (10), proto: 860): ProtocolGame::getItem: unable to create item with invalid id 55039
ProtocolGame parse message exception (1917 bytes, 1725 unread, last opcode is 0x64 (100), prev opcode is 0x0A (10), proto: 860): ProtocolGame::getItem: unable to create item with invalid id 55039
[EXCEPTION] 23 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 25089
Bytes: 00 AE 2C 00 40 64 01 5E 01 00 00 00 00 00 00 00 00 00 AB 00 02 00 01
[EXCEPTION] 23 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 25091
Bytes: 00 47 33 00 40 64 01 4A 00 00 00 00 00 00 00 00 00 00 B4 00 02 00 01
[EXCEPTION] 23 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 25091
Bytes: 00 FD 2C 00 40 64 01 5E 01 00 00 00 00 00 00 00 00 00 AB 00 02 00 01
[EXCEPTION] 155 unread bytes at pos: 86, protocol: 860, current: 0x6A (106), prev: 0xAA (170), error: ProtocolGame::getItem: unable to create item with invalid id 18691
Bytes: 0B 05 83 31 04 9C 03 07 01 84 31 04 9C 03 07 B4 02 00 32 30 B4 18 2F 00 55 6E 20 70 65 72 72 6F 20 6C 6F 73 65 73 20 32 30 20 68 69 74 70 6F 69 6E 74 73 20 64 75 65 20 74 6F 20 79 6F 75 72 20 61 74 74 61 63 6B 2E 8C F0 2C 00 40 00 6C 31 04 9C 03 07 03 6A 31 04 9C 03 07 03 46 0B 05 6A 31 04 9C 03 07 05 53 17 AA 00 00 00 00 00 00 00 00 0F 06 00 1A 00 4C 6F 6F 74 20 6F 66 20 75 6E 20 70 65 72 72 6F 3A 20 6E 6F 74 68 69 6E 67 2E 6C 31 04 9C 03 07 04 A3 00 00 00 00
[EXCEPTION] 763 unread bytes at pos: 157, protocol: 860, current: 0x6A (106), prev: 0xAA (170), error: ProtocolGame::getItem: unable to create item with invalid id 18691
Bytes: 0B 06 83 2F 04 9B 03 07 11 84 2F 04 9B 03 07 42 02 00 33 30 B4 18 32 00 55 6E 20 61 72 65 6E 69 73 74 61 20 6C 6F 73 65 73 20 33 30 20 68 69 74 70 6F 69 6E 74 73 20 64 75 65 20 74 6F 20 79 6F 75 72 20 61 74 74 61 63 6B 2E 8C FD 2C 00 40 00 AA 00 00 00 00 00 00 00 00 0F 09 00 38 00 41 20 44 6F 67 20 6C 6F 73 65 73 20 7C 63 46 46 34 44 34 44 7C 34 36 33 7C 72 20 68 69 74 70 6F 69 6E 74 73 20 64 75 65 20 74 6F 20 79 6F 75 72 20 61 74 74 61 63 6B 2E 6A 2F 04 9D 03 07 03 49 0B 05 83 2F 04 9D 03 07 01 84 2F 04 9D 03 07 B4 02 00 32 30 B4 18 2F 00 55 6E 20 70 65 72 72 6F 20 6C 6F 73 65 73 20 32 30 20 68 69 74 70 6F 69 6E 74 73 20 64 75 65 20 74 6F 20 79 6F 75 72 20 61 74 74 61 63 6B 2E 8C D5 2C 00 40 00 A2 C0 10 A0 91 0B 91 0B 0E C2 02 00 29 BC C0 05
[EXCEPTION] 23 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 25091
Bytes: 00 79 2C 00 40 64 00 20 00 00 00 00 00 00 00 00 00 00 7C 00 02 00 01
[EXCEPTION] 23 unread bytes at pos: 28, protocol: 860, current: 0x6A (106), prev: 0x6D (109), error: ProtocolGame::getItem: unable to create item with invalid id 25089
Bytes: 00 4A 00 00 80 64 03 80 00 3B 6A 4E 5E 01 00 00 00 00 64 00 00 00 01
[EXCEPTION] 23 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 25089
Bytes: 00 53 00 00 80 64 03 8F 00 4F 4C 2F 5F 01 00 00 00 00 64 00 00 00 01
[EXCEPTION] 23 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 25091
Bytes: 00 AE 2C 00 40 64 01 5E 01 00 00 00 00 00 00 00 00 00 AB 00 02 00 01
[EXCEPTION] 23 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 25091
Bytes: 00 BB 2C 00 40 64 01 20 00 00 00 00 00 00 00 00 00 00 7C 00 02 00 01
[EXCEPTION] 98 unread bytes at pos: 102, protocol: 860, current: 0x6A (106), prev: 0xAA (170), error: ProtocolGame::getItem: unable to create item with invalid id 18689
Bytes: 0B 05 83 29 04 8D 03 07 01 84 29 04 8D 03 07 B4 02 00 37 35 83 29 04 8D 03 07 10 84 29 04 8D 03 07 C0 02 00 39 33 B4 18 32 00 55 6E 20 62 61 6E 64 69 64 6F 20 6C 6F 73 65 73 20 31 36 38 20 68 69 74 70 6F 69 6E 74 73 20 64 75 65 20 74 6F 20 79 6F 75 72 20 61 74 74 61 63 6B 2E 8C 46 2D 00 40 21
[EXCEPTION] 551 unread bytes at pos: 341, protocol: 860, current: 0x6A (106), prev: 0x6C (108), error: ProtocolGame::getItem: unable to create item with invalid id 18689
Bytes: 0B 05 83 29 04 8D 03 07 01 84 29 04 8D 03 07 B4 02 00 38 32 B4 18 31 00 55 6E 20 62 61 6E 64 69 64 6F 20 6C 6F 73 65
[EXCEPTION] 510 unread bytes at pos: 87, protocol: 860, current: 0x6A (106), prev: 0xAA (170), error: ProtocolGame::getItem: unable to create item with invalid id 18689
Bytes: 0B 05 83 2A 04 8C 03 07 01 84 2A 04 8C 03 07 B4 02 00 35 35 B4 18 2D 00 41 20 63 72 61 62 20 6C 6F 73 65 73 20 35 35 20 68 69 74 70 6F 69 6E 74 73 20 64 75 65 20 74 6F 20 79 6F 75 72 20 61 74 74 61 63 6B 2E 8C 52 2D 00 40 00 AA 00 00 00 00 00 00 00 00 0F 0B 00 C4 00 59 6F 75 20 67 61 69 6E 65 64 20 7C 63 46 46 46 46 30 30 7C 37 32 7C 72 20 65 78 70 65 72 69 65 6E 63 65 20 66 72 6F 6D 20 7C 63 46 46 46 46 46 46 7C 61 20 63 72 61 62 7C 72 20 28 62 61 73 65 20 7C 63 46 46 46 46 30 30 7C 33 32 7C 72 2C 20 7C 63 46 46 46 46 30 30 7C 2B 32 7C 72 20 66 72 6F 6D 20 7C 63 30 30 42 46 46 46 7C 72 69 6E 67 7C 72 2C 20 7C 63 46 46 46 46 30 30 7C 2B 31 36 7C 72 20 66 72 6F 6D 20 7C 63 30 30 42 46 46 46 7C 70 72 65 6D 69 75 6D 7C 72 2C 20 7C 63 46 46 46 46 30 30 7C
[EXCEPTION] 48 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 24833
Bytes: 00 00 00 00 00 53 33 00 40 0B 00 53 65 61 67 75 6C 6C 20 5B 31 5D 64 02 DF 00 00 00 00 00 00 00 00 00 00 04 01 02 00 00 01 83 2A 04 8B 03 07 0B
[EXCEPTION] 48 unread bytes at pos: 16, protocol: 860, current: 0x6A (106), prev: 0x-1 (-1), error: ProtocolGame::getItem: unable to create item with invalid id 24833
Bytes: 00 00 00 00 00 54 33 00 40 0B 00 42 61 6E 64 69 74 20 5B 32 33 5D 64 02 81 00 3A 28 18 5F 00 00 00 00 00 B8 00 01 00 00 01 83 2C 04 8D 03 07 0B
[EXCEPTION] 131 unread bytes at pos: 94, protocol: 860, current: 0x6A (106), prev: 0xAA (170), error: ProtocolGame::getItem: unable to create item with invalid id 18689
Bytes: 0B 05 83 2E 04 8F 03 07 01 84 2E 04 8F 03 07 B4 01 00 33 B4 18 34 00 59 6F 75 20 6C 6F 73 65 20 33 20 68 69 74 70 6F 69 6E 74 73 20 64 75 65 20 74 6F 20 61 6E 20 61 74 74 61 63 6B 20 62 79 20 75 6E 20 62 61 6E 64 69 64 6F 2E A0 88 0B 91 0B 94 C3 02 00 39 BD C0 05 B5 00 38 B8 00 EA 03 09 1A C8 D4 09 A0 88 0B 91 0B 94 C3 02 00 39 BD C0 05 B5 00 38 B8 00 EA 03 09 1A C8 D4 09 8C 02 00 00 10 64

Which clarifies that is nothing realted to a compiling issue. There's something on that "hotfix" that isn't working at all. So I call you guys, can you help me deciding how to proceed, should I revert commits till' I hit the earlier version or there's something we can do about it? I use TFS 1.6 downgrades 8.6 with custom sprites and transparency.

Regards, thanks in advance!

 

[ralke]

ok solved, compiled 4.0b4 succesfullly using Developer Command Prompt (VS 2022)

cd /d C:\otclient-4.0b4
msbuild vc17\otclient.sln /t:Clean /p:Configuration=Release /p:Platform=x64
msbuild vc17\otclient.sln /p:Configuration=Release /p:Platform=x64

and lots of troublshooting. Regards!