C++ Lua in quest description by gesior

[GhostWD]

Hello again ;p
i wanted to use this feature in my tfs 0.4
Feature - LUA code in descriptions of quests in quests.xml

but when compiling is almost done this happens

  CXX      vocation.o
  CXXLD    theforgottenserver
quests.o: In function `Quests::parseQuestNode(_xmlNode*, bool)':
quests.cpp:(.text+0x8ac): undefined reference to `vtable for Quest'
collect2: error: ld returned 1 exit status
Makefile:466: recipe for target 'theforgottenserver' failed

and i don't know what is going on i read that it's something about ?virtual method? could someone help me with that?
With Regards
Ghost

Bump

 

[ScorpionOT]

Maybe you modified something by mistake? Have you tried doing it again from scratch?

Please post your quests.cpp so we may examine it -- as it makes a reference to a function which is not even mentioned in your referenced tutorial.

P.S.: Also, I love your signature. I was a huge WoDBO fan.

 

[GhostWD]

Here You are!

////////////////////////////////////////////////////////////////////////
// OpenTibia - an opensource roleplaying game
////////////////////////////////////////////////////////////////////////
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program.  If not, see <http://www.gnu.org/licenses/>.
////////////////////////////////////////////////////////////////////////
#include "otpch.h"

#include "quests.h"
#include "tools.h"
#include "creatureevent.h"

bool Mission::isStarted(Player* player)
{
    if(!player)
        return false;

    std::string value;
    player->getStorage(storageId, value);
    return atoi(value.c_str()) >= startValue;
}

bool Mission::isCompleted(Player* player)
{
    if(!player)
        return false;

    std::string value;
    player->getStorage(storageId, value);
    return atoi(value.c_str()) >= endValue;
}

std::string Mission::parseStorages(std::string state, std::string value)
{
    /*std::string::size_type start, end;
    while((start = state.find("|STORAGE:")) != std::string::npos)
    {
        if((end = state.find("|", start)) = std::string::npos)
            continue;

        std::string value, storage = state.substr(start, end - start)
        player->getStorage(storage, value);
        state.replace(start, end, value);
    } requires testing and probably fixing, inspired by QuaS code*/

    replaceString(state, "|STATE|", value);
    return state;
}

std::string Mission::getDescription(Player* player)
{
    std::string value;
    if(!player->getStorage(storageId, value))
        return "Couldn't retrieve a valid player storage, please report to a gamemaster.";

    if(state.size())
    {
        std::string ret = state;
        replaceString(ret, "|STATE|", value);
        CreatureEventList questDescriptionEvents = player->getCreatureEvents(CREATURE_EVENT_QUEST_DESCRIPTION);
        for(CreatureEventList::iterator it = questDescriptionEvents.begin(); it != questDescriptionEvents.end(); ++it)
        {
            if(player)
                {
                     (*it)->executeGetQuestDescription(player, ret);
                }
        }
        return ret;
    }

    if(atoi(value.c_str()) >= endValue)
    {
        std::string ret = states.rbegin()->second;
        CreatureEventList questDescriptionEvents = player->getCreatureEvents(CREATURE_EVENT_QUEST_DESCRIPTION);
        for(CreatureEventList::iterator it = questDescriptionEvents.begin(); it != questDescriptionEvents.end(); ++it)
        {
            if(player)
                {
                     (*it)->executeGetQuestDescription(player, ret);
                }
        }
        return ret;
    }

    for(int32_t i = endValue; i >= startValue; --i)
    {
        if(!player->getStorage(storageId, value) || atoi(value.c_str()) != i)
            continue;

        std::string ret = states[i - startValue];
        replaceString(ret, "|STATE|", value);
        CreatureEventList questDescriptionEvents = player->getCreatureEvents(CREATURE_EVENT_QUEST_DESCRIPTION);
        for(CreatureEventList::iterator it = questDescriptionEvents.begin(); it != questDescriptionEvents.end(); ++it)
        {
            if(player)
            {
                (*it)->executeGetQuestDescription(player, ret);
            }
        }
        return ret;
    }

    return "Couldn't retrieve any mission description, please report to a gamemaster.";
}


bool Quest::isStarted(Player* player)
{
    if(!player)
        return false;

    std::string value;
    player->getStorage(storageId, value);
    return atoi(value.c_str()) >= storageValue;
}

bool Quest::isCompleted(Player* player) const
{
    for(MissionList::const_iterator it = missions.begin(); it != missions.end(); it++)
    {
        if(!(*it)->isCompleted(player))
            return false;
    }

    return true;
}

uint16_t Quest::getMissionCount(Player* player)
{
    uint16_t count = 0;
    for(MissionList::iterator it = missions.begin(); it != missions.end(); it++)
    {
        if((*it)->isStarted(player))
            count++;
    }

    return count;
}

void Quests::clear()
{
    for(QuestList::iterator it = quests.begin(); it != quests.end(); it++)
        delete (*it);

    quests.clear();
}

bool Quests::reload()
{
    clear();
    return loadFromXml();
}

bool Quests::loadFromXml()
{
    xmlDocPtr doc = xmlParseFile(getFilePath(FILE_TYPE_XML, "quests.xml").c_str());
    if(!doc)
    {
        std::clog << "[Warning - Quests::loadFromXml] Cannot load quests file." << std::endl;
        std::clog << getLastXMLError() << std::endl;
        return false;
    }

    xmlNodePtr p, root = xmlDocGetRootElement(doc);
    if(xmlStrcmp(root->name,(const xmlChar*)"quests"))
    {
        std::clog << "[Error - Quests::loadFromXml] Malformed quests file." << std::endl;
        xmlFreeDoc(doc);
        return false;
    }

    p = root->children;
    while(p)
    {
        parseQuestNode(p, false);
        p = p->next;
    }

    xmlFreeDoc(doc);
    return true;
}

bool Quests::parseQuestNode(xmlNodePtr p, bool checkDuplicate)
{
    if(xmlStrcmp(p->name, (const xmlChar*)"quest"))
        return false;

    int32_t intValue;
    std::string strValue;

    uint32_t id = m_lastId;
    if(readXMLInteger(p, "id", intValue) && id > 0)
    {
        id = intValue;
        if(id > m_lastId)
            m_lastId = id;
    }

    std::string name;
    if(readXMLString(p, "name", strValue))
        name = strValue;

    std::string startStorageId;
    if(readXMLString(p, "startstorageid", strValue) || readXMLString(p, "storageId", strValue))
        startStorageId = strValue;

    int32_t startStorageValue = 0;
    if(readXMLInteger(p, "startstoragevalue", intValue) || readXMLInteger(p, "storageValue", intValue))
        startStorageValue = intValue;

    Quest* quest = new Quest(name, id, startStorageId, startStorageValue);
    if(!quest)
        return false;

    for(xmlNodePtr missionNode = p->children; missionNode; missionNode = missionNode->next)
    {
        if(xmlStrcmp(missionNode->name, (const xmlChar*)"mission"))
            continue;

        std::string missionName, missionState, storageId;
        if(readXMLString(missionNode, "name", strValue))
            missionName = strValue;

        if(readXMLString(missionNode, "state", strValue) || readXMLString(missionNode, "description", strValue))
            missionState = strValue;

        if(readXMLString(missionNode, "storageid", strValue) || readXMLString(missionNode, "storageId", strValue))
            storageId = strValue;

        int32_t startValue = 0, endValue = 0;
        if(readXMLInteger(missionNode, "startvalue", intValue) || readXMLInteger(missionNode, "startValue", intValue))
            startValue = intValue;

        if(readXMLInteger(missionNode, "endvalue", intValue) || readXMLInteger(missionNode, "endValue", intValue))
            endValue = intValue;

        if(Mission* mission = new Mission(missionName, missionState, storageId, startValue, endValue))
        {
            if(missionState.empty())
            {
                // parse sub-states only if main is not set
                for(xmlNodePtr stateNode = missionNode->children; stateNode; stateNode = stateNode->next)
                {
                    if(xmlStrcmp(stateNode->name, (const xmlChar*)"missionstate"))
                        continue;

                    uint32_t missionId;
                    if(!readXMLInteger(stateNode, "id", intValue))
                    {
                        std::clog << "[Warning - Quests::parseQuestNode] Missing missionId for mission state" << std::endl;
                        continue;
                    }

                    missionId = intValue;
                    std::string description;
                    if(readXMLString(stateNode, "description", strValue))
                        description = strValue;

                    mission->newState(missionId, description);
                }
            }

            quest->newMission(mission);
        }
    }

    if(checkDuplicate)
    {
        for(QuestList::iterator it = quests.begin(); it != quests.end(); ++it)
        {
            if((*it)->getName() == name)
                delete *it;
        }
    }

    m_lastId++;
    quests.push_back(quest);
    return true;
}

uint16_t Quests::getQuestCount(Player* player)
{
    uint16_t count = 0;
    for(QuestList::iterator it = quests.begin(); it != quests.end(); it++)
    {
        if((*it)->isStarted(player))
            count++;
    }

    return count;
}

Quest* Quests::getQuestById(uint16_t id) const
{
    for(QuestList::const_iterator it = quests.begin(); it != quests.end(); it++)
    {
        if((*it)->getId() == id)
            return (*it);
    }

    return NULL;
}

and Thank You Scorpio ;D i love WoDBO too that was my first and successful OTserv only domain left :C

 

[ScorpionOT]

Word of advice: are you using linux or windows? If you are using either, you might need to recompile all project files. In windows this is simple to do by pressing "Rebuild All". In linux, you'd have to run "make distclean" or "make clean" and then "make" with your parameters again.

Also, it may be worth to look at this thread:
Undefined reference to vtable

Specifically "Srinivasa Lakkaraju" answer.

 

[GhostWD]

linux ofc ;p I have recompiled it but error keeps showing idk why... I haven't put any virtual into source even in gesior script virtal are not present

 

[ScorpionOT]

Have you tried running 'make distclean' before 'make -j X'? Also, maybe try to revert to your previous version of sources, then re-applying the changes. Maybe you changed something wrong somewhere. Your CPP appears to be fine, can you also post the .H after you do all the things I've suggested (given that it still doesn't work)?

 

[GhostWD]

not working too with cleaning ;/