• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

New currency

D

Dorianek

Member
Joined
Nov 29, 2018
Messages
247
Reaction score
10
Location
Poland
Hello, how to add in (TFS1,3) a new currency? because I was looking for game cpp but I do not see anything

I would like to add two currencies
Scrabcoins
nuggets

and how could someone explain to me how to add it

I mean only the script that adds currency to the game

because I already wrote scripts for other currencies
 
Last edited:
Sort by date Sort by votes
Dorianek said:
Hello, how to add in (TFS1,3) a new currency? because I was looking for game cpp but I do not see anything

I would like to add two currencies
Scrabcoins
nuggets

and how could someone explain to me how to add it

I mean only the script that adds currency to the game

because I already wrote scripts for other currencies
Click to expand...
open chomikuj.pl look for mazurski ots and check the old yurots source there is plenty of code there to take idea from :)
 
Upvote 0 Downvote
find in your game.cpp void::addMoney and exchange the whole function with this one
C++: 
void Game::addMoney(Cylinder* cylinder, uint64_t money, uint32_t flags /*= 0*/)
{
    if (money == 0) {
        return;
    }
    uint32_t goldNuggets = money / 100000000;
    money -= goldNuggets * 100000000;
    while (goldNuggets > 0) {
        const uint16_t count = std::min<uint32_t>(100, goldNuggets);
        Item* remaindItem = Item::CreateItem(ITEM_GOLD_NUGGET, count);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        goldNuggets -= count;
    }
    uint32_t scarabCoins = money / 1000000;
    if (scarabCoins != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_SCARAB_COIN, scarabCoins);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        money -= scarabCoins * 1000000;
    }
    uint32_t crystalCoins = money / 10000;
    if (crystalCoins != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_CRYSTAL_COIN, crystalCoins);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        money -= crystalCoins * 10000;
    }
    uint16_t platinumCoins = money / 100;
    if (platinumCoins != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_PLATINUM_COIN, platinumCoins);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        money -= platinumCoins * 100;
    }
    if (money != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_GOLD_COIN, money);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
    }
}
and find game::removeMoney and change it with this ( whole function )
C++: 
bool Game::removeMoney(Cylinder* cylinder, uint64_t money, uint32_t flags /*= 0*/)
{
    if (cylinder == nullptr) {
        return false;
    }
    if (money == 0) {
        return true;
    }
    std::vector<Container*> containers;
    std::multimap<uint64_t, Item*> moneyMap;
    uint64_t moneyCount = 0;
    for (size_t i = cylinder->getFirstIndex(), j = cylinder->getLastIndex(); i < j; ++i) {
        Thing* thing = cylinder->getThing(i);
        if (!thing) {
            continue;
        }
        Item* item = thing->getItem();
        if (!item) {
            continue;
        }
        Container* container = item->getContainer();
        if (container) {
            containers.push_back(container);
        } else {
            const uint64_t worth = item->getWorth();
            if (worth != 0) {
                moneyCount += worth;
                moneyMap.emplace(worth, item);
            }
        }
    }
    size_t i = 0;
    while (i < containers.size()) {
        Container* container = containers[i++];
        for (Item* item : container->getItemList()) {
            Container* tmpContainer = item->getContainer();
            if (tmpContainer) {
                containers.push_back(tmpContainer);
            } else {
                const uint64_t worth = item->getWorth();
                if (worth != 0) {
                    moneyCount += worth;
                    moneyMap.emplace(worth, item);
                }
            }
        }
    }
    if (moneyCount < money) {
        return false;
    }
    for (const auto& moneyEntry : moneyMap) {
        Item* item = moneyEntry.second;
        if (moneyEntry.first < money) {
            internalRemoveItem(item);
            money -= moneyEntry.first;
        } else if (moneyEntry.first > money) {
            const uint64_t worth = moneyEntry.first / item->getItemCount();
            const uint32_t removeCount = std::ceil(money / static_cast<double>(worth));
            addMoney(cylinder, (worth * removeCount) - money, flags);
            internalRemoveItem(item, removeCount);
            break;
        } else {
            internalRemoveItem(item);
            break;
        }
    }
    return true;
}
then go to player.cpp and find line looks like this and add this instead
C++: 
if (itemId != ITEM_GOLD_COIN && itemId != ITEM_PLATINUM_COIN && itemId != ITEM_CRYSTAL_COIN && itemId != ITEM_SCARAB_COIN && itemId != ITEM_GOLD_NUGGET) {

in item.cpp change item:getWorth function with this one
C++: 
uint64_t Item::getWorth() const
{
    switch (id) {
    case ITEM_GOLD_COIN:
        return count;
    case ITEM_PLATINUM_COIN:
        return count * 100;
    case ITEM_CRYSTAL_COIN:
        return count * 10000;
    case ITEM_SCARAB_COIN:
        return count * 1000000ULL;
    case ITEM_GOLD_NUGGET:
        return count * 100000000ULL;
    default:
        return 0;
    }
}

since uint_32 maximum value is lower than 100 gold nugget,
open item.h
change this line
C++: 
uint32_t getWorth() const;
with this one
C++: 
uint64_t getWorth() const;

add those in const.h
C++: 
    ITEM_SCARAB_COIN = 2159,
    ITEM_GOLD_NUGGET = 2157,

and those in luascript.cpp
C++: 
    registerEnum(ITEM_SCARAB_COIN)
    registerEnum(ITEM_GOLD_NUGGET)

all credits goes to @Sarah Wesker and @Stigma , just simplified thier 2 posts in 1
 
Upvote 0 Downvote
Shadow_ said:
find in your game.cpp void::addMoney and exchange the whole function with this one
C++: 
void Game::addMoney(Cylinder* cylinder, uint64_t money, uint32_t flags /*= 0*/)
{
    if (money == 0) {
        return;
    }
    uint32_t goldNuggets = money / 100000000;
    money -= goldNuggets * 100000000;
    while (goldNuggets > 0) {
        const uint16_t count = std::min<uint32_t>(100, goldNuggets);
        Item* remaindItem = Item::CreateItem(ITEM_GOLD_NUGGET, count);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        goldNuggets -= count;
    }
    uint32_t scarabCoins = money / 1000000;
    if (scarabCoins != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_SCARAB_COIN, scarabCoins);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        money -= scarabCoins * 1000000;
    }
    uint32_t crystalCoins = money / 10000;
    if (crystalCoins != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_CRYSTAL_COIN, crystalCoins);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        money -= crystalCoins * 10000;
    }
    uint16_t platinumCoins = money / 100;
    if (platinumCoins != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_PLATINUM_COIN, platinumCoins);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
        money -= platinumCoins * 100;
    }
    if (money != 0) {
        Item* remaindItem = Item::CreateItem(ITEM_GOLD_COIN, money);
        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }
    }
}
and find game::removeMoney and change it with this ( whole function )
C++: 
bool Game::removeMoney(Cylinder* cylinder, uint64_t money, uint32_t flags /*= 0*/)
{
    if (cylinder == nullptr) {
        return false;
    }
    if (money == 0) {
        return true;
    }
    std::vector<Container*> containers;
    std::multimap<uint64_t, Item*> moneyMap;
    uint64_t moneyCount = 0;
    for (size_t i = cylinder->getFirstIndex(), j = cylinder->getLastIndex(); i < j; ++i) {
        Thing* thing = cylinder->getThing(i);
        if (!thing) {
            continue;
        }
        Item* item = thing->getItem();
        if (!item) {
            continue;
        }
        Container* container = item->getContainer();
        if (container) {
            containers.push_back(container);
        } else {
            const uint64_t worth = item->getWorth();
            if (worth != 0) {
                moneyCount += worth;
                moneyMap.emplace(worth, item);
            }
        }
    }
    size_t i = 0;
    while (i < containers.size()) {
        Container* container = containers[i++];
        for (Item* item : container->getItemList()) {
            Container* tmpContainer = item->getContainer();
            if (tmpContainer) {
                containers.push_back(tmpContainer);
            } else {
                const uint64_t worth = item->getWorth();
                if (worth != 0) {
                    moneyCount += worth;
                    moneyMap.emplace(worth, item);
                }
            }
        }
    }
    if (moneyCount < money) {
        return false;
    }
    for (const auto& moneyEntry : moneyMap) {
        Item* item = moneyEntry.second;
        if (moneyEntry.first < money) {
            internalRemoveItem(item);
            money -= moneyEntry.first;
        } else if (moneyEntry.first > money) {
            const uint64_t worth = moneyEntry.first / item->getItemCount();
            const uint32_t removeCount = std::ceil(money / static_cast<double>(worth));
            addMoney(cylinder, (worth * removeCount) - money, flags);
            internalRemoveItem(item, removeCount);
            break;
        } else {
            internalRemoveItem(item);
            break;
        }
    }
    return true;
}
then go to player.cpp and find line looks like this and add this instead
C++: 
if (itemId != ITEM_GOLD_COIN && itemId != ITEM_PLATINUM_COIN && itemId != ITEM_CRYSTAL_COIN && itemId != ITEM_SCARAB_COIN && itemId != ITEM_GOLD_NUGGET) {

in item.cpp change item:getWorth function with this one
C++: 
uint64_t Item::getWorth() const
{
    switch (id) {
    case ITEM_GOLD_COIN:
        return count;
    case ITEM_PLATINUM_COIN:
        return count * 100;
    case ITEM_CRYSTAL_COIN:
        return count * 10000;
    case ITEM_SCARAB_COIN:
        return count * 1000000ULL;
    case ITEM_GOLD_NUGGET:
        return count * 100000000ULL;
    default:
        return 0;
    }
}

since uint_32 maximum value is lower than 100 gold nugget,
open item.h
change this line
C++: 
uint32_t getWorth() const;
with this one
C++: 
uint64_t getWorth() const;

add those in const.h
C++: 
    ITEM_SCARAB_COIN = 2159,
    ITEM_GOLD_NUGGET = 2157,

and those in luascript.cpp
C++: 
    registerEnum(ITEM_SCARAB_COIN)
    registerEnum(ITEM_GOLD_NUGGET)

all credits goes to @Sarah Wesker and @Stigma , just simplified thier 2 posts in 1
Click to expand...
thats a nice one but this should be turned into /lib/ so you can add /delete easier ;)
 
Upvote 0 Downvote
Vizjus said:
thats a nice one but this should be turned into /lib/ so you can add /delete easier ;)
Click to expand...
add ? delete ? what are you talking about? how you are going to compile and you want to delete ITEM_GOLD_NUGGET = 2197 it will give you error "undeclared identifier"
 
Upvote 0 Downvote
Shadow_ said:
add ? delete ? what are you talking about? how you are going to compile and you want to delete ITEM_GOLD_NUGGET = 2197 it will give you error "undeclared identifier"
Click to expand...
im saying to make the code read from lib files for currencies. simplify it by making the structure inside of lua so you can add more when needed on the go because once compiled tfs is really poor with portability of the lua functions.
 
Upvote 0 Downvote
Vizjus said:
im saying to make the code read from lib files for currencies. simplify it by making the structure inside of lua so you can add more when needed on the go because once compiled tfs is really poor with portability of the lua functions.
Click to expand...
then develop your own one and tell me if it worked :D
 
Upvote 0 Downvote

Similar threads

C
  • Question
TFS 1.X+ Helps to add a new currency to a sales NPC with a trade similar to Eryn
Replies
0
Views
70
cleisson66
C
160312
  • Question
How can I add new items from newest version on map editor and how to add items to market on Sabrehaven?
Replies
2
Views
493
160312
160312
I
  • Question
C++ i have a few questions regarding implementing a new npc
Replies
2
Views
521
izaakbuwalda
I
D
TFS 1.4.2 more currencies
Replies
0
Views
179
Dercas
D
ralke
  • Question
AAC Paypal automatic payments doesn't load points on ZnoteAAC
Replies
4
Views
757
ralke
ralke
Piifafa
  • Question
C++ Activate new outfits
Replies
1
Views
161
Obito
Obito
R
  • Question
OTClient Extended Map Size - black screen? OTCV8
Replies
2
Views
530
roriscrave
R
G
  • Question
RevScripts Player Dead lose Skills/Magic level
Replies
0
Views
242
Gaber Zen
G
Duzo
  • Question
How to customize your own UI, implement your own settings as of walking with "WASD" keys
Replies
7
Views
980
samco
samco
PuszekLDZ
  • Question
Different corpse by vocation in 0.3.6
Replies
7
Views
358
djblah
D
Back
Top