[TFS 1.5] NPC buying rare equipped item

[popa45]

I have implemented a Rarity system in my Server where players have items classified as rare, epic, and legendary. Currently, when players sell items to NPCs, the NPC prioritizes buying the equipped item in the slot. I would like to modify this behavior so that only items from the backpack are eligible for sale, and equipped items are not purchased by NPCs.

How can I make this adjustment in the code?​

 

[excool]

I think it will be difficult, but I also join the request

 

[popa45]

I think it will be difficult, but I also join the request

i dont think so its difficult

 

[Tenzhiro]

Maybe this helps:

Solved - NPCs buy from EQ Slots bug. (clost it)

i've seen many people with this issue, sadly none of the existing threads have a fix for it. (as far as i know.) the issue: NPCs buy item from EQ Slots, example i have royal helmet on me and one in my backpack, the NPC will buy the one im wearing and leave the other helmet in my backpack. and...

otland.net

 

[popa45]

Maybe this helps:

Solved - NPCs buy from EQ Slots bug. (clost it)

i've seen many people with this issue, sadly none of the existing threads have a fix for it. (as far as i know.) the issue: NPCs buy item from EQ Slots, example i have royal helmet on me and one in my backpack, the NPC will buy the one im wearing and leave the other helmet in my backpack. and...

otland.net

its TFS 0.3 bro :/

 

[Sparkles]

add a check here to see if item is equipped or not

forgottenserver/data/npc/lib/npcsystem/modules.lua at f3d8747b537f3883b9204c1beb68cb69e8642917 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[popa45]

add a check here to see if item is equipped or not

forgottenserver/data/npc/lib/npcsystem/modules.lua at f3d8747b537f3883b9204c1beb68cb69e8642917 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

i dont got this in my modules.lua

 

[Mateus Robeerto]

So, I made a script from scratch that is quite practical and configurable. Check out the video showcasing how the item selling to the NPC works.

https://imgur.com/j3tPOqH

This NPC is functional. It doesn't sell items by slots, only by backpack. So, add the items you want to sell and complete the process there.

local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)
local talkState = {}

local items = {
    ["two handed sword"] = {itemid = 2377, price = 450},
    ["battle axe"] = {itemid = 2378, price = 80},
   -- Add more items as needed
}

function onCreatureAppear(cid)
    npcHandler:onCreatureAppear(cid)
end

function onCreatureDisappear(cid)
    npcHandler:onCreatureDisappear(cid)
end

function onCreatureSay(cid, type, msg)
    npcHandler:onCreatureSay(cid, type, msg)
end

function onThink()
    npcHandler:onThink()
end

function creatureSayCallback(cid, type, msg)
    if (not npcHandler:isFocused(cid)) then
        return false
    end

    local talkUser = NPCHANDLER_CONVBEHAVIOR == CONVERSATION_DEFAULT and 0 or cid
    local player = Player(cid)

    if msgcontains(msg, 'sell') or msgcontains(msg, 'sells') or msgcontains(msg, 'vende') then
        local itemList = "{"
        local isFirstItem = true
        for itemName, _ in pairs(items) do
            if isFirstItem then
                itemList = itemList .. itemName
                isFirstItem = false
            else
                itemList = itemList .. ", " .. itemName
            end
        end
        itemList = itemList .. "}"
        npcHandler:say("I'm interested in the items here: " .. itemList, cid)
        talkState[talkUser] = 1
    elseif talkState[talkUser] == 1 then
        local chosenItem = string.lower(msg)
        local itemData = items[chosenItem]

        local slotItem = player:getSlotItem(SLOT_ARMOR)

        if itemData and player:removeItem(itemData.itemid, 1, -1, true) then
            player:addMoney(itemData.price)
            npcHandler:say("So will you sell me " .. chosenItem .. " for " .. itemData.price .. " gold coins.", cid)
        else
            npcHandler:say("You do not have the item in your backpack or it cannot be in the sell slots.", cid)
        end

        talkState[talkUser] = 0
    elseif msgcontains(msg, 'offer') or msgcontains(msg, 'trade') then
        local offerList = "two handed sword - 450 gold coins\nbattle - 80 gold coins"
        npcHandler:say("Here are the available offers:\n" .. offerList, cid)
    end

    return true
end

npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())

 

[popa45]

So, I made a script from scratch that is quite practical and configurable. Check out the video showcasing how the item selling to the NPC works.

https://imgur.com/j3tPOqH

This NPC is functional. It doesn't sell items by slots, only by backpack. So, add the items you want to sell and complete the process there.

local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)
local talkState = {}

local items = {
    ["two handed sword"] = {itemid = 2377, price = 450},
    ["battle axe"] = {itemid = 2378, price = 80},
   -- Add more items as needed
}

function onCreatureAppear(cid)
    npcHandler:onCreatureAppear(cid)
end

function onCreatureDisappear(cid)
    npcHandler:onCreatureDisappear(cid)
end

function onCreatureSay(cid, type, msg)
    npcHandler:onCreatureSay(cid, type, msg)
end

function onThink()
    npcHandler:onThink()
end

function creatureSayCallback(cid, type, msg)
    if (not npcHandler:isFocused(cid)) then
        return false
    end

    local talkUser = NPCHANDLER_CONVBEHAVIOR == CONVERSATION_DEFAULT and 0 or cid
    local player = Player(cid)

    if msgcontains(msg, 'sell') or msgcontains(msg, 'sells') or msgcontains(msg, 'vende') then
        local itemList = "{"
        local isFirstItem = true
        for itemName, _ in pairs(items) do
            if isFirstItem then
                itemList = itemList .. itemName
                isFirstItem = false
            else
                itemList = itemList .. ", " .. itemName
            end
        end
        itemList = itemList .. "}"
        npcHandler:say("I'm interested in the items here: " .. itemList, cid)
        talkState[talkUser] = 1
    elseif talkState[talkUser] == 1 then
        local chosenItem = string.lower(msg)
        local itemData = items[chosenItem]

        local slotItem = player:getSlotItem(SLOT_ARMOR)

        if itemData and player:removeItem(itemData.itemid, 1, -1, true) then
            player:addMoney(itemData.price)
            npcHandler:say("So will you sell me " .. chosenItem .. " for " .. itemData.price .. " gold coins.", cid)
        else
            npcHandler:say("You do not have the item in your backpack or it cannot be in the sell slots.", cid)
        end

        talkState[talkUser] = 0
    elseif msgcontains(msg, 'offer') or msgcontains(msg, 'trade') then
        local offerList = "two handed sword - 450 gold coins\nbattle - 80 gold coins"
        npcHandler:say("Here are the available offers:\n" .. offerList, cid)
    end

    return true
end

npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())

Thanks bro! You're the best.