TFS 1.X+ [bug] buying items from eq

[Svira]

Hello gentlemen! I have a problem. I noticed that after adding the system slot, my NPCs dealing in item trading started buying items from EQ, where to look and how to fix this problem? I found some old solutions with old svn, I need a fix for tfs 1.2

npc/lib, I've probably searched everything!

 

[Mateus Robeerto]

I created a custom script a long time ago for a guy where NPCs don't trade with slots; they only trade with the player's backpack. I added a function 'local slotItem = player:getSlotItem(SLOT_ARMOR),' and it worked just fine. Take a look at this post!

[TFS 1.5] NPC buying rare equipped item

I have implemented a Rarity system in my Server where players have items classified as rare, epic, and legendary. Currently, when players sell items to NPCs, the NPC prioritizes buying the equipped item in the slot. I would like to modify this behavior so that only items from the backpack are...

otland.net

 

[Svira]

I created a custom script a long time ago for a guy where NPCs don't trade with slots; they only trade with the player's backpack. I added a function 'local slotItem = player:getSlotItem(SLOT_ARMOR),' and it worked just fine. Take a look at this post!

[TFS 1.5] NPC buying rare equipped item

I have implemented a Rarity system in my Server where players have items classified as rare, epic, and legendary. Currently, when players sell items to NPCs, the NPC prioritizes buying the equipped item in the slot. I would like to modify this behavior so that only items from the backpack are...

otland.net

In this solution I have to edit all npc.lua that deal with sales. Can it be converted to lib?

I have over 220 items purchasing and it will be very time-consuming ;/

 

[adric21]

use chatgpt? XD

 

[mano368]

In this solution I have to edit all npc.lua that deal with sales. Can it be converted to lib?

I have over 220 items purchasing and it will be very time-consuming ;/

You can try as follows:
open the following file npc/lib/npc.lua

search for:

function doPlayerSellItem(cid, itemid, count, cost)
    local player = Player(cid)
    if player:removeItem(itemid, count) then
        if not player:addMoney(cost) then
            error('Could not add money to ' .. player:getName() .. '(' .. cost .. 'gp)')
        end
        return true
    end
    return false
end

change for:

function doPlayerSellItem(cid, itemid, count, cost, itemSubType, ignoreEquipped)
    local player = Player(cid)
    if player:removeItem(itemid, count, itemSubType, ignoreEquipped == nil and true or ignoreEquipped) then
        if not player:addMoney(cost) then
            error('Could not add money to ' .. player:getName() .. '(' .. cost .. 'gp)')
        end
        return true
    end
    return false
end

also, go to npc/lib/npcsystem/modules.lua
search for:

local ret = doPlayerSellItem(cid, shop_itemid[cid], shop_amount[cid], shop_cost[cid] * shop_amount[cid])

change for:

            local itemSubType = -1
            if ItemType(shop_itemid[cid]):isFluidContainer() then
                itemSubType = 0
            end
            local ret = doPlayerSellItem(cid, shop_itemid[cid], shop_amount[cid], shop_cost[cid] * shop_amount[cid], itemSubType, true)

then, search for:

if player:removeItem(itemid, amount, subType, ignoreEquipped) then

change to:

if player:removeItem(itemid, amount, subType, ignoreEquipped == nil and true or ignoreEquipped) then