Lua Increase Damage dealt

[Apoccalypse]

Hello guys,
I am trying to make the specific item to increase all damage dealt.
I have the following script:

Spoiler: MoreDMG.lua

function onStatsChange(cid, attacker, type, combat, value)
   local config = {
       item_id = 2400, -- right or left hand
       more_dmg = 30, -- percent
       more_dmg_spell = 20, -- percent
       storage = 815869
   }
 
   if isPlayer(cid) and getPlayerStorageValue(cid, 815869) == 1  then
       if((type == STATSCHANGE_HEALTHLOSS or STATSCHANGE_MANALOSS) and (getPlayerSlotItem(cid, CONST_SLOT_LEFT).itemid == config.item_id or getPlayerSlotItem(cid, CONST_SLOT_RIGHT).itemid == config.item_id)) then
           if(combat == COMBAT_PHYSICALDAMAGE) then
               local correct = value + (value * config.more_dmg)
               doTargetCombatHealth(attacker, cid, combat, correct, correct, 255)
           else
               local correct = value + (value * config.more_dmg_spell)
               doTargetCombatHealth(attacker, cid, combat, correct, correct, 255)
           end
           return false
       end
   end
end

Spoiler: login.lua

registerCreatureEvent(cid, "MoreDMG")

Spoiler: creaturescripts.xml

<event type="statschange" name="MoreDMG"            event="script" value="MoreDMG.lua"/>

I use the storage ,because I was getting a stack overflow all over again.
The storage is set in movements:

Spoiler: Item 2400

function onEquip(cid, item, slot)
    local slots = getPlayerSlotItem(cid, slot)
    if slots then
        if slots.itemid ~= item.itemid then
            return true
        end
        if getPlayerStorageValue(cid, 815869) < 1 then
            setPlayerStorageValue(cid, 815869, 1)
        end
    end
    return  true
end
function onDeEquip(cid, item, slot)
    if getPlayerStorageValue(cid, 815869) > 0 then
        setPlayerStorageValue(cid, 815869, 0)
    end
    return  true
end

The problem is that I get no errors but the script is no working for me.
If anyone would help that would be great

 

[Xikini]

that's exactly how it should look
maybe swap attacker and cid in doTargetCombatHealth i guess?
doTargetCombatHealth(cid, attacker instead of the other way around
that's the only spot where an error would occur, the rest executes fine, just the damage isn't being output for some reason

You have the return false set incorrectly.
You want to return false the original damage only, not the second time too.
Move return false to line 33, just after that end.

 

[Apoccalypse]

Works prefect , thank you guys, especially you Static_ and Xikini , all credits for you

 

[Xikini]

Works prefect , thank you guys, especially you Static_ , all credits for you

Have you tested the script while the person receiving damage has mana shield active?
Just wondering if the script bypasses the shield and deals direct damage to their health.

Thanks in advance.

 

[Infernum]

You have the return false set incorrectly.
You want to return false the original damage only, not the second time too.
Move return false to line 33, just after that end.

oops
i just kept it from his original script