• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

TFS 0.X [OTX 2] Yellow skull bug

potinho

potinho

Advanced OT User
Joined
Oct 11, 2009
Messages
1,403
Solutions
17
Reaction score
151
Location
Brazil
Good evening guys, how are you? I saw that my engine has a Yellow Skull bug, I'll try to explain:

  • Player 1 attacks player two.
  • Player 2 Attacks player 3
  • Player 3 attacks player 1 (turning Yellow Skull)
  • Player 1 leaves, loses the skull and manages to attack player 3 without getting White Skull and does not get unjust killed.

I saw that we have some posts dealing with this bug but I didn't find the solution. Here's a video of the bug reproduction and my players.cpp attached.

 

Attachments

Sort by date Sort by votes
i think a fix would be to remove yellow skull from every player that had attacked back p1 at same time as he loses white skull, i noticed tfs missing it aswell
 
Upvote 0 Downvote
I changed this void

C++: 
void Player::setSkullEnd(time_t _time, bool login, Skulls_t _skull)
{
    if(g_game.getWorldType() != WORLDTYPE_OPEN
        || hasFlag(PlayerFlag_NotGainInFight) ||
        hasCustomFlag(PlayerCustomFlag_NotGainSkull))
        return;

    bool requireUpdate = false;
    if(_time > time(NULL))
    {
        requireUpdate = true;
        setSkull(_skull);
    }
    else if(skull == _skull)
    {
        requireUpdate = true;
        setSkull(SKULL_NONE);
        _time = 0;
    }

    if(requireUpdate)
    {
        skullEnd = _time;
        if(!login)
            g_game.updateCreatureSkull(this);
    }
}

Now Yellow Skull gone, but P1 can attack P3 without get skull, and if he kills, get no injust kill.
 
Upvote 0 Downvote
mano368 said:
otland.net

C++ - Skull system, help me do this

atm in downgraded versions it work like this A = WHITE SKULL worls B = YELLOW SKULL worls C = NO_SKULL
otland.net otland.net
Click to expand...
For 0.X i tried to use this one

C++: 
void Player::onTarget(Creature* target)
{
    Creature::onTarget(target);

    if(target == this)
    {
        addInFightTicks(false);
        return;
    }

    if(hasFlag(PlayerFlag_NotGainInFight))
        return;

    Player* targetPlayer = target->getPlayer();
    if(targetPlayer && !isPartner(targetPlayer) && !isAlly(targetPlayer))
    {
        if(!pzLocked && g_game.getWorldType() == WORLDTYPE_HARDCORE)
        {
            pzLocked = true;
            sendIcons();
        }

        if(getSkull() == SKULL_NONE && getSkullType(targetPlayer) == SKULL_YELLOW)
        {
            addAttacked(targetPlayer);
            targetPlayer->sendCreatureSkull(this);
        }
        else if(!targetPlayer->hasAttacked(this))
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }

            if(!Combat::isInPvpZone(this, targetPlayer) && !isEnemy(this))
            {
                addAttacked(targetPlayer);

                if(targetPlayer->getSkull() == SKULL_NONE && getSkull() == SKULL_NONE)
                {
                    setSkull(SKULL_WHITE);
                    g_game.updateCreatureSkull(this);
                }

                if(getSkull() == SKULL_NONE)
                    targetPlayer->sendCreatureSkull(this);
            }
        }
    }

    addInFightTicks(false);
}

Still not working.
 
Upvote 0 Downvote
mano368 said:
otland.net

C++ - Skull system, help me do this

atm in downgraded versions it work like this A = WHITE SKULL worls B = YELLOW SKULL worls C = NO_SKULL
otland.net otland.net
Click to expand...

I tested here, but it doesn't work.

My test is:

Player 3 (Orange) - Attack player 1 (get white skull)
Player 1 (Blue) - Attack player 2 (get white skull)
Player 2 (Black) - Attack player 3 (get yellow)

3e5d2eafe0202c5d256c35900cc86257.png


Until then, everything is fine.

Player 3 stops attacking and player 1 is attacking player 2 (which is yellow on player 3).

Player 3 loses the white skull, however, player 2 remains yellow skull for him (it should come out with player 3's white skull).
5c39ff4ff84a63aae529d02787f7fea6.png


This happens when player 2 is being attacked (pz).
 
Upvote 0 Downvote
LeOnArd0 said:
I tested here, but it doesn't work.

My test is:

Player 3 (Orange) - Attack player 1 (get white skull)
Player 1 (Blue) - Attack player 2 (get white skull)
Player 2 (Black) - Attack player 3 (get yellow)

3e5d2eafe0202c5d256c35900cc86257.png


Until then, everything is fine.

Player 3 stops attacking and player 1 is attacking player 2 (which is yellow on player 3).

Player 3 loses the white skull, however, player 2 remains yellow skull for him (it should come out with player 3's white skull).
5c39ff4ff84a63aae529d02787f7fea6.png


This happens when player 2 is being attacked (pz).
Click to expand...
My bad, I don't read propely the post
Post automatically merged:

potinho said:
For 0.X i tried to use this one

C++: 
void Player::onTarget(Creature* target)
{
    Creature::onTarget(target);

    if(target == this)
    {
        addInFightTicks(false);
        return;
    }

    if(hasFlag(PlayerFlag_NotGainInFight))
        return;

    Player* targetPlayer = target->getPlayer();
    if(targetPlayer && !isPartner(targetPlayer) && !isAlly(targetPlayer))
    {
        if(!pzLocked && g_game.getWorldType() == WORLDTYPE_HARDCORE)
        {
            pzLocked = true;
            sendIcons();
        }

        if(getSkull() == SKULL_NONE && getSkullType(targetPlayer) == SKULL_YELLOW)
        {
            addAttacked(targetPlayer);
            targetPlayer->sendCreatureSkull(this);
        }
        else if(!targetPlayer->hasAttacked(this))
        {
            if(!pzLocked)
            {
                pzLocked = true;
                sendIcons();
            }

            if(!Combat::isInPvpZone(this, targetPlayer) && !isEnemy(this))
            {
                addAttacked(targetPlayer);

                if(targetPlayer->getSkull() == SKULL_NONE && getSkull() == SKULL_NONE)
                {
                    setSkull(SKULL_WHITE);
                    g_game.updateCreatureSkull(this);
                }

                if(getSkull() == SKULL_NONE)
                    targetPlayer->sendCreatureSkull(this);
            }
        }
    }

    addInFightTicks(false);
}

Still not working.
Click to expand...
Thats for 1.5 tfs and this has nothing to do with "infight condition remove skull".
 
Upvote 0 Downvote
LeOnArd0 said:
I tested here, but it doesn't work.

My test is:

Player 3 (Orange) - Attack player 1 (get white skull)
Player 1 (Blue) - Attack player 2 (get white skull)
Player 2 (Black) - Attack player 3 (get yellow)

3e5d2eafe0202c5d256c35900cc86257.png


Until then, everything is fine.

Player 3 stops attacking and player 1 is attacking player 2 (which is yellow on player 3).

Player 3 loses the white skull, however, player 2 remains yellow skull for him (it should come out with player 3's white skull).
5c39ff4ff84a63aae529d02787f7fea6.png


This happens when player 2 is being attacked (pz).
Click to expand...
exactly, thats why i suggested to remove YS from players such as p2 as p3 drops WS : ) that would also solve p3 not getting white skull again when trying to attack p2, since this statement prevents that from happening
C++: 
if (getSkull() == SKULL_NONE && getSkullClient(targetPlayer) == SKULL_YELLOW) {
 
Upvote 0 Downvote
emil92b said:
exactly, thats why i suggested to remove YS from players such as p2 as p3 drops WS : ) that would also solve p3 not getting white skull again when trying to attack p2, since this statement prevents that from happening
C++: 
if (getSkull() == SKULL_NONE && getSkullClient(targetPlayer) == SKULL_YELLOW) {
Click to expand...

I understand. But wouldn't that solve just the visual part? A yellow skull would not appear, however, p2 could be killed in that period by p3 without him getting frag, right?
 
Upvote 0 Downvote
if p2 don't have YS anymore, p3 would gain WS again and if p2 dies i think both p1 and p3 gets frag on p2, since p1 was still attacking while p3 was dropping, resulting in p1 getting most damage and in this scenario p3 last hit
 
Last edited:
Upvote 0 Downvote
emil92b said:
if p2 don't have YS anymore, p3 would gain WS again and if p2 dies i think both p1 and p3 gets frag on p2, since p1 was still attacking while p3 was dropping, resulting in p2 getting most damage and in this scenario p3 last hit
Click to expand...

I tried to come up with something here, but it didn't work.

Have a suggestion to change this part of the code?

Lua: 
if (getSkull() == SKULL_NONE) {
            addAttacked(targetPlayer);
            targetPlayer->sendCreatureSkull(this);
        } else if (!targetPlayer->hasAttacked(this)) {
            if (!pzLocked) {
                pzLocked = true;
                sendIcons();
            }
 
Upvote 0 Downvote
i meant p1 getting most, not p2, typo :p
as for the change, i doubt it updates when p3 setting target but instead on infight dropping, someone should test it
 
Upvote 0 Downvote
I know TFS 0.4 Fire3Element had a fix for this issue, im looking entire web for this but found nothing atm.
 
Upvote 0 Downvote
Last edited:
Upvote 0 Downvote

Similar threads

LeOnArd0
  • Question
TFS 1.X+ Yellow Skull TFS 1.5
Replies
6
Views
809
LeOnArd0
LeOnArd0
X
  • Question
Summon Bug, Players can avoid skull
Replies
0
Views
313
X X X
X
potinho
  • Question
TFS 0.X Yellow skull fight back
Replies
2
Views
197
riderovsky
R
potinho
  • Question
TFS 0.X [C++] Player does not get PZ after attacking PK
Replies
6
Views
624
potinho
potinho
Jpstafe
  • Question
C++ Skull system, help me do this
Replies
11
Views
801
Jpstafe
Jpstafe
D
  • Question
If player have X storage then get 2 attacks per second
Replies
9
Views
508
Dran Ryszard
D
potinho
  • Question
Lua [TFS 0.X] Error when kill 2 bosses with reward system
Replies
6
Views
594
potinho
potinho
Back
Top