[Request] Change g helmet for piggybank

[Nevalopo]

[Request] Change g helmet for piggybank
Yeah well.. it sounds stupid lol i know but i want an npc to change a g helmet for a piggybank.. i tryed messing with the scripts but it fails all time so i need someone to help me
id g helmet: 2471
id piggybank: 2508
Thanks

 

[Chris]

if doPlayerRemoveItem(cid,2471,1) == TRUE then
    selfSay('Take this piggybank as a reward!')
    doPlayerAddItem(cid, 2508, 1)
else
    selfSay('You do not have the required item.')
end

That should do (thank you Marcinek for the clearance).

 

[EvulMastah]

    if doPlayerRemoveItem(cid, 2471, 1) == TRUE then

And checking count is not necessery when you are removing the item o,o

 

[Chris]

Thank you, updated my first post.

 

[Nevalopo]

ehm...

Euhm.. Im a newbie on scripts... Can you plx give the full script? If i just put this in test.lua my tfs alpha 03 crashes when i summon the npc :S

 

[Chris]

local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)

-- OTServ event handling functions start
function onCreatureAppear(cid)                npcHandler:onCreatureAppear(cid) end
function onCreatureDisappear(cid)             npcHandler:onCreatureDisappear(cid) end
function onCreatureSay(cid, type, msg)     npcHandler:onCreatureSay(cid, type, msg) end
function onThink()                         npcHandler:onThink() end
-- OTServ event handling functions end


function creatureSayCallback(cid, type, msg)
    -- Place all your code in here. Remember that hi, bye and all that stuff is already handled by the npcsystem, so you do not have to take care of that yourself.
    if(npcHandler.focus ~= cid) then
        return false
    end

    if msgcontains(msg, 'piggybank') or msgcontains(msg, 'golden helmet') then
        if doPlayerRemoveItem(cid,2471,1) == TRUE then
            selfSay('Take this piggybank as a reward!')
            doPlayerAddItem(cid, 2508, 1)
        else
            selfSay('You do not have the required item.')
        end  
    end
end

npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())

There you go. ^^

 

[EvulMastah]

local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)
local talkState = {}

function onCreatureAppear(cid)				npcHandler:onCreatureAppear(cid)			end
function onCreatureDisappear(cid)			npcHandler:onCreatureDisappear(cid)			end
function onCreatureSay(cid, type, msg)			npcHandler:onCreatureSay(cid, type, msg)		end
function onThink()					npcHandler:onThink()					end

function creatureSayCallback(cid, type, msg)
	if(not npcHandler:isFocused(cid)) then
		return false
	end

	local talkUser = NPCHANDLER_CONVBEHAVIOR == CONVERSATION_DEFAULT and 0 or cid

	if(msgcontains(msg, 'golden helmet') or msgcontains(msg, 'trade')) then
		selfSay("I will trade a piggy bank for your golden helmet. Deal?", cid)
		talkState[talkUser] = 1
	elseif(msgcontains(msg, 'deal') or msgcontains(msg, 'yes') and talkState[talkUser] == 1) then
		if doPlayerRemoveItem(cid,2471,1) == TRUE then
			selfSay('Take this piggybank as a reward!')
			doPlayerAddItem(cid, 2508, 1)
		else
			selfSay('You do not have the required item.')
		end
		talkState[talkUser] = 0
	elseif(msgcontains(msg, 'no') and talkState[talkUser] == 1) then
		selfSay("Then not, gtfo.", cid)
		talkState[talkUser] = 0
	return true
end

npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())

Should do the thing.