The answer is: when contributors help us close issues marked for 1.4 milestone.
Personal reasons.@fabian766
I admire you and admire your work with your tfs.
why don't you write in the official tfs or because your tfs doesn't become the official?
1. Yeah, it can but why should the code look elegant? It isn't casting or anything like that. About loops if you're a programmer you should know that you should use loops only when completely necessary so stop abusing those poor loops.1. Pretty sure the conditions could be written in a more elegant way (some loop very likely).
2. enter key not used enough, everything is just clumped together
3. adding condition, sending a message and sending magic effect could be moved to some configurable table
4. things from point 3 anditem:remove(1)
could be moved outside of if/elseif chain because it's a single instruction that runs in every case so the code could be a few lines shorter. Cases in which the food can't be used could be handled by return statement before reaching item removing instruction.
5.Creature(cid):addHealth(getCreatureMaxHealth(cid) - getCreatureHealth(cid))
Why are they even using cid to add health to player when player variable is available and proper methods to do that without using cid were introduced?
The great thing about programming is that there isn't something like correctly code design, you can code as you want if you're write proper code that actually works. Saying things like this you're only scaring new people to even try to learn anything.It is not a complaint that the code work bad, just that someone else should have taught him to design the code correctly and then be merged, and please do not come out and insult me, I already know that I am not good with codes UwU
I'll leave it to myself as it is more funny that way because I can later laugh at people that think how good the code from main repository is or even crash servers from people I don't like(currently there aren't any of those but who knows what will bring future).@fabian766 I would like to see an example of a badly designed or cumbersome-looking code in the official TFS, just out of curiosity, I like gossip
I ran out of the gossip uwuPersonal reasons.
1. Yeah, it can but why should the code look elegant? It isn't casting or anything like that. About loops if you're a programmer you should know that you should use loops only when completely necessary so stop abusing those poor loops.
2. Yeah, similarly in STL libraries that every programmer like to use them, then authors of those libraries write bad code?
3. Making simple script over-configurable? Yeah why not. Just because script doesn't have "local config = {someshit}" doesn't mean it is bad.
4. So having disability to use enter key is bad because you're saving so much lines but having additional lines that does the same thing is bad? Interesting.
5. I already asked who decided that it is wrong? Those compatibility functions are there to be used even if it looks weird, if it is that bad then why keeping them at all?
The great thing about programming is that there isn't something like correctly code design, you can code as you want if you're write proper code that actually works. Saying things like this you're only scaring new people to even try to learn anything.
I'll leave it to myself as it is more funny that way because I can later laugh at people that think how good the code from main repository is or even crash servers from people I don't like(currently there aren't any of those but who knows what will bring future).
No.Just because it works doesn't mean its good.
kekw for youNo.
When code work it mean that it is good, but that doesn't mean it can't be written better.
kekw for you.
Yeah, no.No.
When code work it mean that it is good, but that doesn't mean it can't be written better.
kekw for you.
There is a correct way to write code. That would be the most efficient, and readable is the correct way. Just because it works doesn't mean its good.
Yeah, no.Yeah, no.
Its okay if you can't understand what I'm saying. Just say that. If you go to school for coding at all they will teach you this stuff. I'm not being paid so I'm not going to sit here and teach you.Yeah, no.
The correct code is the code that works as it should and have the least amount of bugs(if possible doesn't have any).
"most efficient" okay how did you measure that the way you write code is the most efficient? What if you're wrong and using your local config hashtable is actually less efficient than using simple elseif's? Stop forcing premature optimizations on others because you think it is the right way to do things. If they'll face performance problems then it is theirs problem and they'll look for ways to optimize their code(and learn how to write "better" code that way).
"readable" you know that depends from person to person? If someone write code it is fully readable for him/her but might not be for you so stop imposing to others your personal opinion whether their code is readable because it is useless.
"clean code", i love that bookMy goal always been to write clean code. It's easy to understand and easy to change.
Yeah, no.
The correct code is the code that works as it should and have the least amount of bugs(if possible doesn't have any).
"most efficient" okay how did you measure that the way you write code is the most efficient? What if you're wrong and using your local config hashtable is actually less efficient than using simple elseif's? Stop forcing premature optimizations on others because you think it is the right way to do things. If they'll face performance problems then it is theirs problem and they'll look for ways to optimize their code(and learn how to write "better" code that way).
"readable" you know that depends from person to person? If someone write code it is fully readable for him/her but might not be for you so stop imposing to others your personal opinion whether their code is readable because it is useless.
local cid = player:getId()
doPlayerAddItem(player:getId(), 2160, 5)
player:addItem(2160, 5)
The hostility is coming from him acting like it doesn't matter how you code. That is not what we should be teaching people. His attitude is screw it, its not our problem if they don't code correctly. Considering my coding journey started here, for someone to have an attitude like that on this forum is disgusting.I keep hearing that our average age has gone up in the OT community, this thread is kinda worrying in that regard. Part of growing up is learning what is subjective and why arguing about such things is nonsense.
Chill bros, Merry Christmas and stop being so hostile over such nonsense. OPEN Tibia, cmon man.
I still have luascript.cpp open when I code new things. It's so clean that it can be read as a documentation.is there away you guys can keep the same Functions? help a noob become a coder. I keep stopping every time at Luascript.cpp to learn and figuring out them functions. is like a school that never ends.
Never, cause you pushed some unrelated changes to your pull request, one pull request one change. You are opening it and naming it for a reason.1.4 is ready when they apply my pull request?
Fix Sight Line for players/monsters by gigastar · Pull Request #3265 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/3265)
When you want to fix another problem that has nothing to do with the first fix, then you create another branch for it.1.4 is ready when they apply my pull request?
Fix Sight Line for players/monsters by gigastar · Pull Request #3265 · otland/forgottenserver (https://github.com/otland/forgottenserver/pull/3265)