Add % Damage

[Roa Supporter]

Hey I know its possible to make a script that adds % dmg could anyone make 1?

For example: a shield that when u put it on adds 100% magic dmg


REP ++++

 

[breadmaker]

hmm...

 

[Fresh]

@ Up
Spammer ? -.-"

@ Topic

<attribute key="increaseMagicPercent" value="10"/>

<attribute key="increaseMagicPercent" value="%"/>

example:

<item id="2656" article="a" name="blue robe">
<attribute key="description" value="It is a magic robe."/>
<attribute key="weight" value="2200"/>
<attribute key="armor" value="11"/>
<attribute key="slotType" value="body"/>
<attribute key="increaseMagicPercent" value="10"/>

If you put on Blue Robe, you have 10% more magicpercent dmg!
It works in tibia: 8.10 and above!

 

[Fresh]

Warning!
If up post dont work (if you dont have this function in your OT) just add it in C++ :

1) In the function Combat::doCombat(Creature* caster, const Position& pos) after:

getMinMaxValues(caster, minChange, maxChange);

add:

		if(Player* player = caster->getPlayer()){
			int32_t newMinChange = minChange;
			int32_t newMaxChange = maxChange;
 
			for(int i = SLOT_FIRST; i < SLOT_LAST; i++){
				Item* item = NULL;
				if(player->inventory[i]){
					item = player->inventory[i];
					int increaseMagicPercent = Item::items[item->getID()].increaseMagicPercent;
 
					if(item && item->getSlotPosition() << i && increaseMagicPercent != 0){
						minChange += (newMinChange * increaseMagicPercent)/100;
						maxChange += (newMaxChange * increaseMagicPercent)/100;
					}
				}
			}
		}

2) In the function ItemType::ItemType() after:

breakChance   = 0;

add:

	increaseMagicPercent = 0;

3) Now declare the variable in items.h after:

uint32_t breakChance;

add:

	int increaseMagicPercent;

4) And in the last function
Items::loadFromXml(const std::string& datadir) after:

							else if(strcasecmp(strValue.c_str(), "decayTo") == 0){
								if(readXMLInteger(itemAttributesNode, "value", intValue)){
									it.decayTo = intValue;
								}
							}

add:

							else if(strcasecmp(strValue.c_str(), "increaseMagicPercent") == 0){
								if(readXMLInteger(itemAttributesNode, "value", intValue)){
									it.increaseMagicPercent = intValue;
								}
							}

 

[Exedion]

not work for me

 

[Roa Supporter]

Wow thx it worked for me
REP ++

@Exedion: Add a movement

 

[Fresh]

No problem.
Now come and help my friend :
http://otland.net/f132/few-scripts-can-u-help-92570/

 

[Exedion]

Wow thx it worked for me
REP ++

@Exedion: Add a movement

i can't compile this option xD

in tfs 0.3.6 are these options

1070 	 else if(tmpStrValue == "increasemagicvalue")
1071 	{
1072 	if(readXMLInteger(itemAttributesNode, "value", intValue))
1073 	it.abilities.increment[MAGIC_VALUE] = intValue;
1074 	}
1075 	else if(tmpStrValue == "increasemagicpercent")
1076 	{
1077 	if(readXMLInteger(itemAttributesNode, "value", intValue))
1078 	it.abilities.increment[MAGIC_PERCENT] = intValue;
1079 	}

 

[Fresh]

@Up
Better TFS (higher than 0.3.5pl1) got this function, i think.

 

[JuanC]

This works in TFS 0.3.6?

 

[soul4soul]

i cant get it to work.

../player.h: In member function 'void Combat::doCombat(Creature*, const Position&) const':
../player.h:877: error: 'Item* Player::inventory [11]' is private
../combat.cpp:816: error: within this context
../player.h:877: error: 'Item* Player::inventory [11]' is private

../combat.cpp:817: error: within this context

mingw32-make: *** [obj//combat.o] Error 1

Execution terminated
t