Solved All Npcs Do not speak

[magdy capone]

Hello
My all Npcs Do not speak To me when say hi Do not speak

Please Help Me

 

[Limos]

http://otland.net/threads/cant-talk-to-npc.168734/#post-1631363

 

[magdy capone]

i added
function NpcHandler:isInRange(cid)
local distance = getDistanceBetween(getCreaturePosition(getNpcCid()), getCreaturePosition(cid))
if(distance == -1) then
return false
end

return (distance <= self.talkRadius)
end
in my NpcHandler file but its not worked :/ :/

 

[Limos]

You have to replace it, if you still have errors after that, post the errors.

 

[magdy capone]

This my proplem now

 

[Limos]

Replace the function, not add that function so you have it twice, if you don't know what replace means: https://translate.google.com/

 

[Snavy]

When He Say TO npc Hi Npc Can't SPamm With any player When Sy HI

 

[magdy capone]

Some people told me that you want to good lib file for tfs 0.4 but I did not find it

 

[Limos]

Just replace that function..

Find this in npchandler.lua

  function NpcHandler:isInRange(cid)
     local distance = getDistanceTo(cid) or -1
     if(distance == -1) then
       return false
     end

     return (distance <= self.talkRadius)
   end

Remove that.

Then add this instead.

  function NpcHandler:isInRange(cid)
       local distance = getDistanceBetween(getCreaturePosition(getNpcCid()), getCreaturePosition(cid))
       if(distance == -1) then
           return false
       end

       return (distance <= self.talkRadius)
   end

Or just replace

local distance = getDistanceTo(cid) or -1

With

local distance = getDistanceBetween(getCreaturePosition(getNpcCid()), getCreaturePosition(cid))

 

[magdy capone]

Very Thank's its Worked

 

[Tarek]

Just replace that function..

Find this in npchandler.lua

  function NpcHandler:isInRange(cid)
     local distance = getDistanceTo(cid) or -1
     if(distance == -1) then
       return false
     end

     return (distance <= self.talkRadius)
   end

Remove that.

Then add this instead.

  function NpcHandler:isInRange(cid)
       local distance = getDistanceBetween(getCreaturePosition(getNpcCid()), getCreaturePosition(cid))
       if(distance == -1) then
           return false
       end

       return (distance <= self.talkRadius)
   end

Or just replace

local distance = getDistanceTo(cid) or -1

With

local distance = getDistanceBetween(getCreaturePosition(getNpcCid()), getCreaturePosition(cid))

Doesnt work...

 

[Limos]

Instead of "doesn't work", give an explanation of your problem, what happens after you made those changes?

 

[Tarek]

Instead of "doesn't work", give an explanation of your problem, what happens after you made those changes?

it gives me same error message
My npchandler.lua

-- Returns true if cid is within the talkRadius of this npc.
      function NpcHandler:isInRange(cid)
       local distance = getDistanceBetween(getCreaturePosition(getNpcCid()), getCreaturePosition(cid))
       if(distance == -1) then
           return false
       end

       return (distance <= self.talkRadius)
   end
       
        local sx, sy, sz = selfGetPosition()
        local dx = math.abs(sx-playerPos.x)
        local dy = math.abs(sy-playerPos.y)
        local dz = math.abs(sz-playerPos.z)
       
        local dist = (dx^2 + dy^2)^0.5
       
        return (dist <= self.talkRadius and dz == 0)
    end

 

[Limos]

Then you did it wrong, post your npchandler.lua.
After you made the changes, you have to save it and restart the server.

 

[Tarek]

Then you did it wrong, post your npchandler.lua.
After you made the changes, you have to save it and restart the server.

The server was offline when i saved it.
http://pastebin.com/LWGbDGfd

 

[Limos]

It can't give the same error since getDistanceTo is no longer in the script.
Make sure you saved the right script.

 

[Tarek]

It can't give the same error since getDistanceTo is no longer in the script.
Make sure you saved the right script.

maybe its not same error message
https://imgur.com/Dxujkmt

 

[Limos]

In the script you posted in pastebin, getDistanceTo is not in the script, so it can't give that error.
If you still get the same error, it means you didn't save it or you edited the wrong script.

 

[Tarek]

https://imgur.com/cXIleJY

In the script you posted in pastebin, getDistanceTo is not in the script, so it can't give that error.
If you still get the same error, it means you didn't save it or you edited the wrong script.

https://imgur.com/cXIleJY

 

[Limos]

If you still get the same error, it means you didn't save it or you edited the wrong script.

Or you didn't restart your server.

It is not possible to get an error about getDistanceTo in a script when getDistanceTo is not in that script.