Game freezes when loot is being sold by mass quantity in backpacks to NPC

[Serene]

Hello Otland friends, I have a problem in my server that I believe is a recurrence in majority of TFS, however I believe that not a lot of people know about this bug, or else it would've been fixed. I didnt find any topic regarding this, thats why I'm posting here.

When a player sell loot to the NPC and this loot is divided within many backpacks (by many i mean a lot ranging from thousands) the server begins to freeze and lag constantly. I believe that this forces the server to search a lot within these backpacks of loot.


I tried resolving this by placing an exhaust on the sale to the NPC however it did not help, it still feezes.

 

[Eddie TheGod]

Well who is going to sell thousands of items at a time? Lol and how the hell does someone have that much cap,

 

[Serene]

Well who is going to sell thousands of items at a time? Lol and how the hell does someone have that much cap,

My server is of highexp and the lag happens when the player sells in stack of 100 and these items are separated from thousands backpacks.

 

[Eddie TheGod]

Hmm, well it is also probably because it really is too many items. Lol, can't you limit it? To like 5 thousand items only? Or 1 thousand to be safer?

 

[Serene]

Hmm, well it is also probably because it really is too many items. Lol, can't you limit it? To like 5 thousand items only? Or 1 thousand to be safer?

If I could do that, to sell the items in smaller quantities, would solve the problem. But I don't know how to do it. For example, limiting the sell in a quantity of 10 items would solve the problem.

sorry for my english

 

[Infernum]

If I could do that, to sell the items in smaller quantities, would solve the problem. But I don't know how to do it. For example, limiting the sell in a quantity of 10 items would solve the problem.

sorry for my english

use the actual shop window so they can only sell 100 at a time.

 

[Serene]

use the actual shop window so they can only sell 100 at a time.

It is precisely this window that runs the npc. If they sell 100 at a time with a lot of backpacks and items in the backpack the freeze happens

Remember that this happens when the player is selling about 1000 identical items separated into more than 500 backpacks, I found this bug today. Yes, it is rare that a player go do this, but there is the possibility of anyone lag the server if they discover this bug.

EDIT: As I said, If there was the possibility of limit the sale of items in a 10 stacks on max, then the problem would be solved.

 

[Eddie TheGod]

There is one way to see what luas are running whenever your server lags/crashes
Go into your servergame>data>lib> create a new .lua
now put this

local ignore = {"=%[C%]", "@data/lib/.+"}
function isInPatternArray(str, array)
  for i, x in pairs(array) do
     if str:match(x) then
       return true
     end
   end

   return false
end

debug.sethook(function()
   local info = debug.getinfo(2)
   if info and info.source and not isInPatternArray(info.source, ignore) then
     if info.source == "=[C]" then
       print(info.name or "=[C]")
     else
       print(info.source)
     end
   end
end, "c")

After you put that run the server again, and go into the npc and sell items. if it bugs/crashes it will tell you which .luas are being runned when you sell your items and you will see the cause of your problem

 

[Serene]

There is one way to see what luas are running whenever your server lags/crashes
Go into your servergame>data>lib> create a new .lua
now put this
local ignore = {"=%[C%]", "@data/lib/.+"}
function isInPatternArray(str, array)
for i, x in pairs(array) do
if str:match(x) then
return true
end
end

return false
end

debug.sethook(function()
local info = debug.getinfo(2)
if info and info.source and not isInPatternArray(info.source, ignore) then
if info.source == "=[C]" then
print(info.name or "=[C]")
else
print(info.source)
end
end
end, "c")
After you put that run the server again, and go into the npc and sell items. if it bugs/crashes it will tell you which .luas are being runned when you sell your items and you will see the cause of your problem

Thank You, Eddie.

This script seems to me to be quite useful, however the server nor starts with him.

It begins a infinite loop of loading just as it arrives at part of the npcs,

here's the screenshot

Do you think may have some relation with my problem?

 

[Eddie TheGod]

Could you enter your server after you opened the .exe? Becasue it is going to spam a lot of stuff even after the server has opened, get yourself a backpack, /i a lot of x100 items to sell and go to the npc, sell them all and then check your .exe, you will see the .luas runned there. Then it will tell you the luas that are being bugged after you sell the x100s of items

 

[Serene]

Could you enter your server after you opened the .exe? Becasue it is going to spam a lot of stuff even after the server has opened, get yourself a backpack, /i a lot of x100 items to sell and go to the npc, sell them all and then check your .exe, you will see the .luas runned there. Then it will tell you the luas that are being bugged after you sell the x100s of items

Unfortunately the server does not start with script. Its is that loop before starting,

 

[Eddie TheGod]

You need to wait a while, after you waited for about 1-2 minutes try to enter with your god char into the game

 

[Serene]

You need to wait a while, after you waited for about 1-2 minutes try to enter with your god char into the game

I waited for a long time, it's not working

 

[Eddie TheGod]

Damn, dude to be honest I don't know how to help you anymore :/ Sorry dude

 

[Wason]

I think it will help

https://otland.net/threads/exhausted-on-buying-from-npcs.121305/

 

[Serene]

Damn, dude to be honest I don't know how to help you anymore :/ Sorry dude

No problem, thanks for the help

I think it will help

https://otland.net/threads/exhausted-on-buying-from-npcs.121305/

I've used tried using exhaust, was not effective :\

 

[Wason]

Try to do like that

       <parameter key="shop_buyable" value="
            stone skin amulet, 2197, 500, 5;"

maybe try to add ,5; in every item you got

 

[Pretx]

what rev are you using?

 

[Serene]

Damn, dude to be honest I don't know how to help you anymore :/ Sorry dude

Try to do like that

       <parameter key="shop_buyable" value="
            stone skin amulet, 2197, 500, 5;"

maybe try to add ,5; in every item you got

It didn't work, I think this is only for buy not for sell :\

what rev are you using?

[8.60] The Forgotten Server 0.3.6 (Crying Damson) V8

 

[Itutorial]

Here is a hint...

-- Handles onBuy events. If you wish to handle this yourself, use the CALLBACK_ONBUY callback.
    function NpcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks)
        local callback = self:getCallback(CALLBACK_ONBUY)
        if(callback == nil or callback(cid, itemid, subType, amount, ignoreCap, inBackpacks)) then
            if(self:processModuleCallback(CALLBACK_ONBUY, cid, itemid, subType, amount, ignoreCap, inBackpacks)) then
                --
            end
        end
    end

-- Handles onSell events. If you wish to handle this yourself, use the CALLBACK_ONSELL callback.
    function NpcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks)
        local callback = self:getCallback(CALLBACK_ONSELL)
        if(callback == nil or callback(cid, itemid, subType, amount, ignoreCap, inBackpacks)) then
            if(self:processModuleCallback(CALLBACK_ONSELL, cid, itemid, subType, amount, ignoreCap, inBackpacks)) then
                --
            end
        end
    end