• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Lua TFS 1.3 - Exercises Weapons infinite

ftsys

ftsys

New Member
Joined
Sep 1, 2022
Messages
8
Reaction score
0
When the Exercise Weapon reaches a charge of 0 it is possible to relog it and it comes back completely full...


use until you reach 0
You see an Lasting Exercise Wand that has 0 charges left.
relog... shazam!
You see an Lasting Exercise Wand that has 14400 charges left.

how can i fix?
maybe with a
If < 1 remove
😅😅
 
Solution
M
@ftsys

line 85 already has set to remove the exercise weapon when its below 1 charge

exercise:remove(1)

oh sorry, i get know, they wait until charge one turn in 0 and stop attacking

Line 59, change the >= to only >

After the else in line 84 add:

Lua: 
                            if skills[itemid].id == SKILL_MAGLEVEL then
                                if not bonusDummy then
                                    player:addManaSpent(math.ceil(650*magicRate))
                                else
                                    player:addManaSpent(math.ceil(650*magicRate)*1.1) -- 10%
                                end
                            else
                                if not bonusDummy then...
Sort by date Sort by votes
ftsys said:
When the Exercise Weapon reaches a charge of 0 it is possible to relog it and it comes back completely full...


use until you reach 0
You see an Lasting Exercise Wand that has 0 charges left.
relog... shazam!
You see an Lasting Exercise Wand that has 14400 charges left.

how can i fix?
maybe with a
If < 1 remove
😅😅
Click to expand...
yes or post here

the weapon doesnt broken as default?

something like:

if weapon_charges <= 1 then
weapon:remove()
else
weapon_charges = weapon_charges - 1
end
 
Upvote 0 Downvote
Lua: 
local skills = {
    [32384] = {id=SKILL_SWORD,voc=4}, -- KNIGHT
    [32385] = {id=SKILL_AXE,voc=4}, -- KNIGHT
    [32386] = {id=SKILL_CLUB,voc=4}, -- KNIGHT
    [32387] = {id=SKILL_DISTANCE,voc=3,range=CONST_ANI_SIMPLEARROW}, -- PALADIN
    [32388] = {id=SKILL_MAGLEVEL,voc=2,range=CONST_ANI_SMALLICE}, -- DRUID
    [32389] = {id=SKILL_MAGLEVEL,voc=1,range=CONST_ANI_FIRE}, -- SORCERER
   
    [32124] = {id=SKILL_SWORD,voc=4}, -- KNIGHT
    [32125] = {id=SKILL_AXE,voc=4}, -- KNIGHT
    [32126] = {id=SKILL_CLUB,voc=4}, -- KNIGHT
    [32127] = {id=SKILL_DISTANCE,voc=3,range=CONST_ANI_SIMPLEARROW}, -- PALADIN
    [32128] = {id=SKILL_MAGLEVEL,voc=2,range=CONST_ANI_SMALLICE}, -- DRUID
    [32129] = {id=SKILL_MAGLEVEL,voc=1,range=CONST_ANI_FIRE}, -- SORCERER
   
    [41857] = {id=SKILL_SWORD,voc=4}, -- KNIGHT
    [41858] = {id=SKILL_AXE,voc=4}, -- KNIGHT
    [41859] = {id=SKILL_CLUB,voc=4}, -- KNIGHT
    [41860] = {id=SKILL_DISTANCE,voc=3,range=CONST_ANI_SIMPLEARROW}, -- PALADIN
    [41861] = {id=SKILL_MAGLEVEL,voc=2,range=CONST_ANI_SMALLICE}, -- DRUID
    [41862] = {id=SKILL_MAGLEVEL,voc=1,range=CONST_ANI_FIRE}, -- SORCERER
   
    [41863] = {id=SKILL_SWORD,voc=4}, -- KNIGHT
    [41864] = {id=SKILL_AXE,voc=4}, -- KNIGHT
    [41865] = {id=SKILL_CLUB,voc=4}, -- KNIGHT
    [41866] = {id=SKILL_DISTANCE,voc=3,range=CONST_ANI_SIMPLEARROW}, -- PALADIN
    [41867] = {id=SKILL_MAGLEVEL,voc=2,range=CONST_ANI_SMALLICE}, -- DRUID
    [41868] = {id=SKILL_MAGLEVEL,voc=1,range=CONST_ANI_FIRE} -- SORCERER
   

}

local houseDummies = {32143, 32144, 32145, 32146, 32147, 32148}
local freeDummies = {32142, 32149}



local function start_train(pid,start_pos,itemid,fpos, bonusDummy, dummyId)
    local player = Player(pid)
    if player ~= nil then

    local skillRate = 1
    local magicRate = 1

    if skills[itemid].id == SKILL_MAGLEVEL then
        magicRate = getMagicLevelStage(player:getMagicLevel(SKILL_MAGLEVEL))
    else
        skillRate = getSkillStage(player:getSkillLevel(skills[itemid].id))
    end

    if Tile(fpos):getItemById(dummyId) then
        local pos_n = player:getPosition()
        if start_pos:getDistance(pos_n) == 0 and getTilePzInfo(pos_n) then
            if player:getItemCount(itemid) >= 1 then
                local exercise = player:getItemById(itemid,true)
                if exercise:isItem() then
                    if exercise:hasAttribute(ITEM_ATTRIBUTE_CHARGES) then
                        local charges_n = exercise:getAttribute(ITEM_ATTRIBUTE_CHARGES)
                        if charges_n >= 1 then
                            exercise:setAttribute(ITEM_ATTRIBUTE_CHARGES,(charges_n-1))

                            local voc = player:getVocation()

                            if skills[itemid].id == SKILL_MAGLEVEL then
                                if not bonusDummy then
                                    player:addManaSpent(math.ceil(650*magicRate))
                                else
                                    player:addManaSpent(math.ceil(650*magicRate)*1.1) -- 10%
                                end
                            else
                                if not bonusDummy then
                                    player:addSkillTries(skills[itemid].id, 2*skillRate)
                                else
                                    player:addSkillTries(skills[itemid].id, (2*skillRate)*1.1) -- 10%
                                end
                            end
                                fpos:sendMagicEffect(CONST_ME_GROUNDSHAKER)
                            if skills[itemid].range then
                                pos_n:sendDistanceEffect(fpos, skills[itemid].range)
                            end
                           
                            local training = addEvent(start_train, voc:getAttackSpeed(), pid,start_pos,itemid,fpos,bonusDummy,dummyId)
                            player:setStorageValue(Storage.isTraining,1)
                        else
                            exercise:remove(1)
                            player:sendTextMessage(MESSAGE_INFO_DESCR, "Your training weapon vanished.")
                            stopEvent(training)
                            player:setStorageValue(Storage.isTraining,0)
                        end
                    end
                end
            end
        else
            player:sendTextMessage(MESSAGE_INFO_DESCR, "Your training has stopped.")
            stopEvent(training)
            player:setStorageValue(Storage.isTraining,0)
        end
    else
    stopEvent(training)
            player:sendTextMessage(MESSAGE_INFO_DESCR, "Your training has stopped.")
            player:setStorageValue(Storage.isTraining, 0)
            end
            else
        stopEvent(training)
        if player then
            player:sendTextMessage(MESSAGE_INFO_DESCR, "Your training has stopped.")
            player:setStorageValue(Storage.isTraining,0)
        end
    end
 
    return true
end

function onUse(player, item, fromPosition, target, toPosition, isHotkey)
   
    local start_pos = player:getPosition()
    if player:getStorageValue(Storage.isTraining) == 1 then
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You are already training.")
        return false
    end
    if target:isItem() then
        if isInArray(houseDummies,target:getId()) then
            if not skills[item.itemid].range and (start_pos:getDistance(target:getPosition()) > 1) then
                player:sendTextMessage(MESSAGE_INFO_DESCR, "Get closer to the dummy.")
                stopEvent(training)
                return true
            end
            player:sendTextMessage(MESSAGE_INFO_DESCR, "You started training.")
            start_train(player:getId(),start_pos,item.itemid,target:getPosition(), true, target:getId())
       
        elseif isInArray(freeDummies, target:getId()) then
            if not skills[item.itemid].range and (start_pos:getDistance(target:getPosition()) > 1) then
                player:sendTextMessage(MESSAGE_INFO_DESCR, "Get closer to the dummy.")
                stopEvent(training)
                return true
            end
            player:sendTextMessage(MESSAGE_INFO_DESCR, "You started training.")
            start_train(player:getId(),start_pos,item.itemid,target:getPosition(), false, target:getId())
        end
    end
    return true
end
Click to expand...


Where can i apply?
 
Upvote 0 Downvote
@ftsys

line 85 already has set to remove the exercise weapon when its below 1 charge

exercise:remove(1)

oh sorry, i get know, they wait until charge one turn in 0 and stop attacking

Line 59, change the >= to only >

After the else in line 84 add:

Lua: 
                            if skills[itemid].id == SKILL_MAGLEVEL then
                                if not bonusDummy then
                                    player:addManaSpent(math.ceil(650*magicRate))
                                else
                                    player:addManaSpent(math.ceil(650*magicRate)*1.1) -- 10%
                                end
                            else
                                if not bonusDummy then
                                    player:addSkillTries(skills[itemid].id, 2*skillRate)
                                else
                                    player:addSkillTries(skills[itemid].id, (2*skillRate)*1.1) -- 10%
                                end
                            end
                                fpos:sendMagicEffect(CONST_ME_GROUNDSHAKER)
                            if skills[itemid].range then
                                pos_n:sendDistanceEffect(fpos, skills[itemid].range)
                            end

That part is not necessary, but, this will add a last spent of mana or skilltries, show effect and vanish with the weapon(if they pay, they deserve)
 
Last edited:
Upvote 0 Downvote
Solution
mano368 said:
@ftsys

line 85 already has set to remove the exercise weapon when its below 1 charge

exercise:remove(1)

oh sorry, i get know, they wait until charge one turn in 0 and stop attacking

Line 59, change the >= to only >
Click to expand...

Thanks!!!😊
I just change line 59, >= to only >
 
Upvote 0 Downvote

Similar threads

Unknown Soldier
  • Question
TFS 1.X+ Training weapons used directly from players store inbox
Replies
5
Views
241
Unknown Soldier
Unknown Soldier
donabimbo
  • Question
TFS 1.X+ NPC, When purchasing they do not bring me the charges.
Replies
1
Views
283
Klank
Klank
H
  • Question
TFS 1.2 Attribute bug when adding on weapon slot
Replies
11
Views
537
henkas
H
zbizu
[France][13.20] Noveria Online - 1st July 2023 - FULL LAUNCH!
2 3
Replies
43
Views
6K
zbizu
zbizu
2
  • Question
owner of the item purchased in the game shop
Replies
9
Views
824
2057623
2
potinho
  • Question
Lua [TFS 0.X] NPC - Correct doRemoveMoney
Replies
10
Views
567
Mateus Robeerto
Mateus Robeerto
I
  • Question
Lua TFS 1.3 Task System with points
Replies
4
Views
711
Icaraii
I
A
[Canada] [13.21] Elysiera | low-rate non-pvp | Global content with customizations
Replies
7
Views
1K
Astalavista
A
Olireyin
[Canada] [13.20] ReboOT started 15/07/2023
2
Replies
20
Views
2K
Olireyin
Olireyin
Back
Top