Peonso
Godly Member
- Joined
- Jan 14, 2008
- Messages
- 1,768
- Solutions
- 30
- Reaction score
- 1,558
Well id more or less say what Mark and most of the others prefer (seeing as it now looks like TFS).
If you read the thread, you will notice that I was correct, people seem to prefer a code that is easy to read.
Just take this:
Code:1*3/2+2+4*mfs-mvn*2/3
Things like that are imposible to read, but they are still approved in PRs.
Same with for loops;
Code:for(int i=0;i<mxlm;i++)
Or what about the one liners if statments that you always miss?
Code:if player:getHealth()<0 or player:getMana()/2>player:getHealth()/2 then return end
Wierd things that you miss = truoble.
That is most likely the main reason why Mark changed the code style with 1.0.
About the spaces, sure some prefer them saying they prefer the "shorter tabs" - but a tab is a thing you can change, a tab could look like 100 spaces or 2 spaces - learn to work with your code editor.
But yes the code style was a #1 for me, it makes it easier to find the issues aswell as learning the codes.
I have started with some smaller things, but it's really hard to even understand the grafics code since it's split out everywhere(thanks Gesior for telling me this) and how it's all so boxed.
So please don't say it won't provide any gain, the things ive already started to change to be more like the standalone client I would never have been able to do if the code was a mess, not even using serach tools.
You kinda just proved my point. As I had no trouble at all reading any of those and I'm not even that used to coding. I do sometimes, depending on the language, have problem with one-line statements, it's just because I never bothered looking/learning how that language handle one-line statements, not code style fault at all.