OTClient Screen render freezing while keyboard walking

[joaobobalhao]

Hello,
I'm using 772 client (edubart otclient) with Nostalrius server (772)

When I walking on otclient using keyboard happens small cuts for each walking SQM:

Another example on different ground:

But on click map (autowalk) this work very well:

I tested keyboard walking on otclientv8 and it works better (more smooth too):

These little freezes on keyboard walking occur at any speed and on different ground.

I tried to implement otv8 walk system but it wasn’t cool because they use another way of drawing (they don't share full source =[)

Can someone help me think of a way to render more smoothly or render normal walking like auto walk (when you click on the map)?

 

[joaobobalhao]

I can't find the problem, I tested OTHire with the same OTClient and it is much smoother with fewer frames locking when walking.

I tried to change the getSpeedDuration method of creature.cpp and leave the duration equal to that of OTHire, but that didn't work either.
I tried to change several parts of the code from player.cpp, creature.cpp and even OTClient but nothing works. Nostalrius is much slower / freezing when using otclient.

 

[Lording]

The same happens to me with a downgraded TFS. Another OTClient with modified walksystem is @Mehah (no support for old versions). Maybe if we convert it to works for 7.x this issue get fixed.
I will link the github:

GitHub - mehah/otclient: An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to custom...

github.com

 

[wlucas]

found a solution?

Hello,
I'm using 772 client (edubart otclient) with Nostalrius server (772)

When I walking on otclient using keyboard happens small cuts for each walking SQM:

Another example on different ground:

But on click map (autowalk) this work very well:

I tested keyboard walking on otclientv8 and it works better (more smooth too):

These little freezes on keyboard walking occur at any speed and on different ground.

I tried to implement otv8 walk system but it wasn’t cool because they use another way of drawing (they don't share full source =[)

Can someone help me think of a way to render more smoothly or render normal walking like auto walk (when you click on the map)?

found a solution?

 

[ralke]

@joaobobalhao @wlucas try this and see if works
First go to your server sources (not OTC sources) and find

int64_t Creature::getStepDuration() const
{
    if (isRemoved()) {
        return 0;
    }

Then replace this

uint32_t calculatedStepSpeed;
uint32_t groundSpeed;

int32_t stepSpeed = getStepSpeed();
if (stepSpeed > -Creature::speedB) {
    calculatedStepSpeed = floor((Creature::speedA * log((stepSpeed / 2) + Creature::speedB) + Creature::speedC) + 0.5);
    if (calculatedStepSpeed <= 0) {
        calculatedStepSpeed = 1;
    }
}
else {
    calculatedStepSpeed = 1;
}

Item* ground = tile->getGround();
if (ground) {
    groundSpeed = Item::items[ground->getID()].speed;
    if (groundSpeed == 0) {
        groundSpeed = 150;
    }
}
else {
    groundSpeed = 150;
}

double duration = std::floor(1000 * groundSpeed / calculatedStepSpeed);
int64_t stepDuration = std::ceil(duration / 50) * 50;

const Monster* monster = getMonster();
if (monster && monster->isTargetNearby() && !monster->isFleeing() && !monster->getMaster()) {
    stepDuration *= 2;
}

return stepDuration;

For this

uint32_t groundSpeed;
int32_t stepSpeed = getStepSpeed();

Item* ground = tile->getGround();
if (ground) {
    groundSpeed = Item::items[ground->getID()].speed;
    if (groundSpeed == 0) {
        groundSpeed = 150;
    }
} else {
    groundSpeed = 150;
}

double duration = std::floor(1000 * groundSpeed) / stepSpeed;
int64_t stepDuration = std::ceil(duration / 50) * 50;

const Monster* monster = getMonster();
if (monster && monster->isTargetNearby() && !monster->isFleeing() && !monster->getMaster()) {
    stepDuration *= 3;
}

return stepDuration;

Regards!

 

[potinho]

@joaobobalhao @wlucas try this and see if works
First go to your server sources (not OTC sources) and find

int64_t Creature::getStepDuration() const
{
    if (isRemoved()) {
        return 0;
    }

Then replace this

uint32_t calculatedStepSpeed;
uint32_t groundSpeed;

int32_t stepSpeed = getStepSpeed();
if (stepSpeed > -Creature::speedB) {
    calculatedStepSpeed = floor((Creature::speedA * log((stepSpeed / 2) + Creature::speedB) + Creature::speedC) + 0.5);
    if (calculatedStepSpeed <= 0) {
        calculatedStepSpeed = 1;
    }
}
else {
    calculatedStepSpeed = 1;
}

Item* ground = tile->getGround();
if (ground) {
    groundSpeed = Item::items[ground->getID()].speed;
    if (groundSpeed == 0) {
        groundSpeed = 150;
    }
}
else {
    groundSpeed = 150;
}

double duration = std::floor(1000 * groundSpeed / calculatedStepSpeed);
int64_t stepDuration = std::ceil(duration / 50) * 50;

const Monster* monster = getMonster();
if (monster && monster->isTargetNearby() && !monster->isFleeing() && !monster->getMaster()) {
    stepDuration *= 2;
}

return stepDuration;

For this

uint32_t groundSpeed;
int32_t stepSpeed = getStepSpeed();

Item* ground = tile->getGround();
if (ground) {
    groundSpeed = Item::items[ground->getID()].speed;
    if (groundSpeed == 0) {
        groundSpeed = 150;
    }
} else {
    groundSpeed = 150;
}

double duration = std::floor(1000 * groundSpeed) / stepSpeed;
int64_t stepDuration = std::ceil(duration / 50) * 50;

const Monster* monster = getMonster();
if (monster && monster->isTargetNearby() && !monster->isFleeing() && !monster->getMaster()) {
    stepDuration *= 3;
}

return stepDuration;

Regards!

in which file? i got the same behauvior

 

[ralke]

@potinho Can't remember when I posted on this thread but here you go, this is how I have it on my server

creature.cpp line 1400

TFS-1.5-Downgrades/src/creature.cpp at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

int64_t Creature::getStepDuration() const
{
    if (isRemoved()) {
        return 0;
    }

    uint32_t groundSpeed;
    int32_t stepSpeed = getStepSpeed();
    Item* ground = tile->getGround();
    if (ground) {
        groundSpeed = Item::items[ground->getID()].speed;
        if (groundSpeed == 0) {
            groundSpeed = 150;
        }
    } else {
        groundSpeed = 150;
    }

    double duration = std::floor(1000 * groundSpeed) / stepSpeed;
    int64_t stepDuration = std::ceil(duration / 50) * 50;

    const Monster* monster = getMonster();
    if (monster && monster->isTargetNearby() && !monster->isFleeing() && !monster->getMaster()) {
        stepDuration *= 3;
    }

    return stepDuration;
}