• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Party crash

oshrigames

oshrigames

Active Member
Joined
Nov 9, 2012
Messages
222
Reaction score
47
Location
israel
game crash once i try to from a party..

i use tfs 1.1 protocol for tibia 9.86.
this is the Error

error.png

note: i don't get error in server console when this happen, is this client issue or server?
how can i solve this ?
 
Sort by date Sort by votes
jigsaw said:
This happened when you tried to party with admin... ever tried with player only?
Click to expand...
Yes.
2 players report that they crash once they try to from a party and since I did not get error in my console I had no idea where to start looking for the fix, so I try it myself (with GM and without) hoping to get an error to analyze..

this is the error i got without a GM / Admin

error 1.png

note: i know in the bug report it says operating system is vista, but i use win 10.
 
Last edited:
Upvote 0 Downvote
do you have any party scripts? have you made any edits to sources?
according to the error message, your client is receiving packets it cannot read

@offtopic is your computer language set to hebrew?
 
Upvote 0 Downvote
Sun said:
do you have any party scripts? have you made any edits to sources?
according to the error message, your client is receiving packets it cannot read

@offtopic is your computer language set to hebrew?
Click to expand...

this is my party script (the only one i manage to find.)

Lua: 
function Party:onJoin(player)
    return true
end

function Party:onLeave(player)
    return true
end

function Party:onDisband()
    return true
end

Edited:
and in the events.xml
ive found this

Code: 
    <!-- Party methods -->
    <event class="Party" method="onJoin" enabled="0" />
    <event class="Party" method="onLeave" enabled="0" />
    <event class="Party" method="onDisband" enabled="0" />

i haven't edit source.

and yes its set to hebrew.. (how did you know? :x)
 
Last edited:
Upvote 0 Downvote
Then I don't really know, can only guess.
default client or edited?

about the hebrew, a close friend of mine has shown me some research he does on hebrew & zulu (apparently they're extremely similar)
 
Upvote 0 Downvote
Sun said:
Then I don't really know, can only guess.
default client or edited?

about the hebrew, a close friend of mine has shown me some research he does on hebrew & zulu (apparently they're extremely similar)
Click to expand...

default client (as far as i know)
aperently working link for 9.86 is rare to find. so im not sure the one i found is default
i used advance search in google and manage to find only this one Baixando Tibia 9.86
i also found this 15 min ago HalfAway - Tools & Layouts

i just did test with the client from halfaway and still crash me out.

i invite a GM to party (since his crash don't result in DC so the invitation still apply when leader crash)
party.png

but still both clients crash after few secs.
 
Last edited:
Upvote 0 Downvote
yea most likely problem with sources (not my field of expertise).
I wonder tho, why 9.86 and tfs 1.1? Isn't 9.86 pretty much the same as 10.9x with less sprites & animations?
 
Upvote 0 Downvote
Sun said:
yea most likely problem with sources (not my field of expertise).
I wonder tho, why 9.86 and tfs 1.1? Isn't 9.86 pretty much the same as 10.9x with less sprites & animations?
Click to expand...

tbh i can't figure how to run those servers, theforgottenserver.exe is missing in most of them and i just can't understand how it all works :x

anyways, look like i gonna have to change source (again).
i might try this one: [9.80-9.86] The Forgotten Server v0.2.15 (Mystic Spirit)
 
Upvote 0 Downvote
Upvote 0 Downvote
thanks, if i fail to fix this party crash ill try mystic spirit 0.2.15 then only as last resoult compile one myself.

anyone know what should i look for when edit my source?
its tfs 1.1

all i want is fix the crash bug.

Edit: i just found this "bug report", this is above my understanding since i don't mess around in core code.
its a report of players that crash NOTE: server still runnig well it is just the client crash.

Code: 
----- 09/03/2018 18:29:57 - Admin (127.0.0.1) -----
Debug Assertion 9.86 Map.cpp 920
Fri Mar 09 18:17:23 2018
Graphic Engine: OpenGL (1)
Operating System: Windows Vista Family in ISR
Processor: Intel Core i7 -6700K @
Video Card: NVIDIA GeForce GTX 1070
Last Packet Types: 133 109 108 109 109 107 162 162 146 100
Last Packet: 133 232 003 232 003 007 225 003 227 003 007 000 133 232 003 232
Player Position: [1000,1000,7]
Player Name: Admin (Forgotten)
Player Action: 049 050 055 046 048 046 048 046 049 058 055 049 055 050
Player.cpp 343: exception occurred, reason:
Network.cpp 979: exception occurred (ErrorCode = 0), reason:
Control.cpp 1496: exception occurred (Type = 133) (MainWindow = 125530392), reason:
Communication.cpp 2897: exception occurred (sx = 8) (sy = 6), reason:
Map.cpp 920: assertion failed (Type = 0), reason:
Type>0
Comment:
----- 15/03/2018 22:48:55 - Admin ({my ip} *** * ** ***) -----
Debug Assertion 9.86 Container.h 230
Thu Mar 15 22:47:55 2018
Graphic Engine: DirectX9 (2)
Operating System: Windows Vista Family in ISR
Processor: Intel Core i7 -6700K @
Video Card: NVIDIA GeForce GTX 1070
Last Packet Types: 109 103 109 109 109 103 109 109 102 109
Last Packet: 109 233 003 233 003 005 001 233 003 234 003 005 103 000 000 106
Player Position: [1001,1002,5]
Player Name: Admin (Relencia RPG)
Player Action: 056 052 046 049 048 057 046 050 050 052 046 049 052 050 058 055 049 055 050
Player.cpp 343: exception occurred, reason:
Player.cpp 447: exception occurred, reason:
Control.cpp 2030: exception occurred (MessageType: 0 MaW: 788EF90 MoW: 0), reason:
Control.cpp 2025: exception occurred, reason:
Control.cpp 524: exception occurred (Force?1:0 = 0), reason:
MainWindow.cpp 126: exception occurred (Surface = 1), reason:
GUI.cpp 1650: exception occurred (Surface = 1), reason:
MapWindow.cpp 863: exception occurred (Surface = 1), reason:
MapWindow.cpp 542: exception occurred (Obj = 0), reason:
MapWindow.cpp 1163: exception occurred (posx = 160) (posy = 371), reason:
MapWindow.cpp 974: exception occurred, reason:
MapWindow.cpp 958: exception occurred (Creature->OutfitType = 433) (Creature->CreatureID = -2147483612), reason:
Objects.cpp 806: exception occurred (Number = 688) (Flag = 24), reason:
Container.h 230: index out of range (original i: 688, i: 687, min: 1, d: 548)
Comment:
----- 16/03/2018 23:06:39 - Absolian ({my ip} *** * ** ***) -----
Debug Assertion 9.86 Control.cpp 1491
Fri Mar 16 23:06:23 2018
Graphic Engine: OpenGL (1)
Operating System: Windows Vista Family in ISR
Processor: Intel Core i7 -6700K @
Video Card: NVIDIA GeForce GTX 1070
Last Packet Types: 148 145 109 106 029 109 109 109 109 109
Last Packet: 145 078 000 000 016 011 148 078 000 000 016 002 000 145 078 000
Player Position: [997,1000,7]
Player Name: Absolian (Relencia RPG)
Player Action: 056 052 046 049 048 057 046 050 050 052 046 049 052 050 058 055 049 055 050
Player.cpp 343: exception occurred, reason:
Network.cpp 979: exception occurred (ErrorCode = 0), reason:
Control.cpp 1496: exception occurred (Type = 148) (MainWindow = 117043080), reason:
Control.cpp 1491: unknown packet type during game (Type = 148)

----- 17/03/2018 13:10:46 - Jhonson ({my ip} *** * ** ***) -----
Debug Assertion 9.86 Control.cpp 1491
Sat Mar 17 13:08:26 2018
Graphic Engine: DirectX9 (2)
Operating System: Windows 7 Home Premium Edition 64 Bit in ISR
Processor: Intel CORE I3 M
Video Card: Intel (R) HD GR
Last Packet Types: 148 145 107 109 109 131 180 104 109 131
Last Packet: 145 063 000 000 016 011 148 063 000 000 016 002 000 145 063 000
Player Position: [1051,1059,6]
Player Name: Jhonson (Relencia RPG)
Player Action: 056 052 046 049 048 057 046 050 050 052 046 049 052 050 058 055 049 055 050
Player.cpp 343: exception occurred, reason:
Network.cpp 979: exception occurred (ErrorCode = 0), reason:
Control.cpp 1496: exception occurred (Type = 148) (MainWindow = 59462632), reason:
Control.cpp 1491: unknown packet type during game (Type = 148)
Comment:
----- 18/03/2018 03:38:56 - Absolian ({my ip} *** * ** ***) -----
Debug Assertion 9.86 Control.cpp 1491
Sun Mar 18 03:38:13 2018
Graphic Engine: OpenGL (1)
Operating System: Windows Vista Family in ISR
Processor: Intel Core i7 -6700K @
Video Card: NVIDIA GeForce GTX 1070
Last Packet Types: 148 145 109 109 109 109 109 109 108 109
Last Packet: 145 006 000 000 016 011 148 006 000 000 016 002 000 145 006 000
Player Position: [1000,998,7]
Player Name: Admin (Relencia RPG)
Player Action: 056 052 046 049 048 057 046 050 050 052 046 049 052 050 058 055 049 055 050
Player.cpp 343: exception occurred, reason:
Network.cpp 979: exception occurred (ErrorCode = 0), reason:
Control.cpp 1496: exception occurred (Type = 148) (MainWindow = 88731528), reason:
Control.cpp 1491: unknown packet type during game (Type = 148)

----- 18/03/2018 03:44:24 - Admin ({my ip} *** * ** ***) -----
Debug Assertion 9.86 Control.cpp 1491
Sun Mar 18 03:43:58 2018
Graphic Engine: OpenGL (1)
Operating System: Windows Vista Family in ISR
Processor: Intel Core i7 -6700K @
Video Card: NVIDIA GeForce GTX 1070
Last Packet Types: 148 145 109 109 109 109 109 109 109 109
Last Packet: 109 238 003 236 003 006 001 238 003 235 003 006 109 238 003 240
Player Position: [996,1003,7]
Player Name: Jiraiya (Relencia RPG)
Player Action: 056 052 046 049 048 057 046 050 050 052 046 049 052 050 058 055 049 055 050
Player.cpp 343: exception occurred, reason:
Network.cpp 979: exception occurred (ErrorCode = 0), reason:
Control.cpp 1496: exception occurred (Type = 148) (MainWindow = 123989896), reason:
Control.cpp 1491: unknown packet type during game (Type = 148)

----- 18/03/2018 03:46:04 - Jiraiya ({my ip} *** * ** ***) -----
Debug Assertion 9.86 Control.cpp 1491
Sun Mar 18 03:44:45 2018
Graphic Engine: OpenGL (1)
Operating System: Windows Vista Family in ISR
Processor: Intel Core i7 -6700K @
Video Card: NVIDIA GeForce GTX 1070
Last Packet Types: 148 180 144 145 109 109 109 109 109 109
Last Packet: 145 000 000 000 016 004 144 000 000 000 016 002 180 020 082 000
Player Position: [1000,998,7]
Player Name: Admin (Relencia RPG)
Player Action: 056 052 046 049 048 057 046 050 050 052 046 049 052 050 058 055 049 055 050
Player.cpp 343: exception occurred, reason:
Network.cpp 979: exception occurred (ErrorCode = 0), reason:
Control.cpp 1496: exception occurred (Type = 148) (MainWindow = 89779848), reason:
Control.cpp 1491: unknown packet type during game (Type = 148)

any of you can analyze it and help me please, i've worked so hard on this server to give it up for one bug.
 
Last edited:
Upvote 0 Downvote
Every single crash report is telling you the problem: Control.cpp 1491: unknown packet type during game (Type = 148)

It's really simple, the client is receiving a packet, of type 148 (0x94), that it doesn't recognize. If you look through the outgoing packets in protocolgame.cpp in the TFS source, you'll find that packet 0x94 is ProtocolGame::sendCreatureHelpers. This is more than likely the culprit (another possibility is that another packet being sent to the client is wrong and sending additional information that the client doesn't recognize, and causing the client to think the extra data is a new packet and it just happens to be 148 every time, but let's start with the easier path), so let's follow the call-chain up to see what parts of TFS can cause this function to be called.

ProtocolGame::sendCreatureHelpers is only called from Player::sendCreatureHelpers, so let's see what calls this higher function. Game::updatePlayerHelpers is the only place that calls it, so let's find what calls this new function. This is more like it, we see that it's called from party.cpp (twice in Party::disband, twice in Party::leaveParty, once in Party::joinParty, twice in Party::removeInvite, and twice in Party::invitePlayer) and guild.cpp (once in Guild::addMember and twice in Guild::removeMember).

This lines up with you getting client crashes only when doing things related to parties, so we can be pretty confident that removing this will solve the issue. Since the client version you're using doesn't use this packet, it's safe to just remove it completely from the source code. Remove the functions ProtocolGame::sendCreatureHelpers, Player::sendCreatureHelpers, and Game::updatePlayerHelpers, then you can remove all the calls to g_game.updatePlayerHelpers() from party.cpp and guild.cpp (there may be additional ones that I overlooked, remove any so there's no errors when compiling).
 
Upvote 0 Downvote
Jo3Bingham said:
Every single crash report is telling you the problem: Control.cpp 1491: unknown packet type during game (Type = 148)

It's really simple, the client is receiving a packet, of type 148 (0x94), that it doesn't recognize. If you look through the outgoing packets in protocolgame.cpp in the TFS source, you'll find that packet 0x94 is ProtocolGame::sendCreatureHelpers. This is more than likely the culprit (another possibility is that another packet being sent to the client is wrong and sending additional information that the client doesn't recognize, and causing the client to think the extra data is a new packet and it just happens to be 148 every time, but let's start with the easier path), so let's follow the call-chain up to see what parts of TFS can cause this function to be called.

ProtocolGame::sendCreatureHelpers is only called from Player::sendCreatureHelpers, so let's see what calls this higher function. Game::updatePlayerHelpers is the only place that calls it, so let's find what calls this new function. This is more like it, we see that it's called from party.cpp (twice in Party::disband, twice in Party::leaveParty, once in Party::joinParty, twice in Party::removeInvite, and twice in Party::invitePlayer) and guild.cpp (once in Guild::addMember and twice in Guild::removeMember).

This lines up with you getting client crashes only when doing things related to parties, so we can be pretty confident that removing this will solve the issue. Since the client version you're using doesn't use this packet, it's safe to just remove it completely from the source code. Remove the functions ProtocolGame::sendCreatureHelpers, Player::sendCreatureHelpers, and Game::updatePlayerHelpers, then you can remove all the calls to g_game.updatePlayerHelpers() from party.cpp and guild.cpp (there may be additional ones that I overlooked, remove any so there's no errors when compiling).
Click to expand...
this explain makes me hornyy
 
Upvote 0 Downvote

Similar threads

Shoorkill
  • Question
TFS 1.5 HELP ME PARTY/GUILD
Replies
0
Views
384
Shoorkill
Shoorkill
Onimusha
  • Question
ERROR: invalid encrypted network message 24569
Replies
1
Views
549
Sanzenkai
Sanzenkai
johnsamir
  • Question
TFS 1.X+ market system debug otclient
Replies
3
Views
391
johnsamir
johnsamir
R
  • Question
C++ Party shared experience issue
2
Replies
37
Views
3K
Rodrigo Tolomeo
R
juansanchez
  • Question
TFS 0.X RSA_Decrypt issue
Replies
0
Views
191
juansanchez
juansanchez
DaMaoKaiz
  • Question
Changing maps
Replies
0
Views
222
DaMaoKaiz
DaMaoKaiz
O
  • Question
Client 10.00 Bug When Player uses any magic or positions
Replies
2
Views
208
Odisk
O
2
  • Question
Shop in game OTV8 does not appear
Replies
2
Views
663
zeeb
zeeb
Jpstafe
  • Question
OTClient green skull at party otcv8
Replies
0
Views
240
Jpstafe
Jpstafe
B
  • Question
DBKO Error in OTC whit sprite
Replies
0
Views
149
braianlomas
B
Back
Top